Cleaned up EditPage, removing and fixing comments etc.
The most prominent changes are:
* improved handing for parse errors
* improved handling for image redirects
* better readability because one huge try/catch block was removed
Change-Id: Ie33720922eb05dda89a22ca1f5f0cba4b1d31129
a) when testing deprecated functions, use $this->hideDeprecated() to
suppress warnings.
b) use doEditContent() instead of doEdit()
Change-Id: Ifa9e0ef373ed72ef7d4a3c2dd558483af4a3fd55
Content::updateRedirect may be used to change the redirect target
without knowing anything about the content's format.
Change-Id: Ifaf8f2bdd9d1cbf984e2ef3c60d0282c984c18c1
Reverting unrelated changes to DairikiDiff. Slight refactoring would
make the diff classes much more reusable and flexible, but that needs
some more thought, and is unrelated to the task at hand.
Change-Id: I9f132985207096676cbb6139c7d37572a10b8806
Allows Content objects to control how magic worlds are applied to it.
Useful mainly when magic words are used outside the parser.
Change-Id: I9711f580f8beadfb9f93a706f87c97c7cf667f6c
Revision::getContent must return a cloned instance of the Content object
if the Content object is mutable to avoid confusion.
Content::copy is used to achieve this, which is specified to return $this
for immutable Content.
Change-Id: Iace17b6ae8aa85a3500624441b69bc067c1ade00
ContentHandler::runLegacyHooks can be used to run hooks that don't
supprot Content objects yet. runLegacyHooks will issue a warning and take
case of serialization/unserialization of the content as appropriate.
Changeset 2: rebased.
Change-Id: I31109061110f87c38bdeebf30d520c8e1241bb29
Due to bug 38800. Just reverting to prevent accidental deployment in
1.20wmf9. I would set a fixme status instead if there was such a thing.
The problem with this is that it breaks formatting of thousands of
Wikipedia articles due to interaction with SyntaxHighlight_GeSHi. I'm
sure some satisfactory solution can be found which fixes both bugs, but
leaving this commit deployed is not a good interim solution.
This reverts commit 782b9f1774.
Change-Id: I1977f093563b5658def9ba57a6ea6cfa9796f795
We are using '@var' to document our variables and class properties,
which is unfortunately not working since '@var' is really meant to
document a function or method.
The way to fix it is to use an input filter that will rewrite our PHP
source code to pretends variables are typed. Aka something like:
/**
* A title object
* @var Title
*/
var $title;
Will be made:
/**
* A title object
* @var Title
*/
Title $title;
That is incorrect PHP code but it is properly recognized by Doxygen.
This patch as a side effect, all variables and properties will end up
being documented in addition of type hinting.
Use a hack authored by Goran Rakic at:
http://stackoverflow.com/a/8472180/276152
Change-Id: I4ead1bd1feace44496b45ed8c55f5e52c59e7694
When looking only for local files, the localonly param skipped the
mabye expensive look up inside the file repos.
Change-Id: Ib8f38d6abf9238a349bbfd617a36933bdfe74b5c
For files the file name with underscores is often used,
than the compare method should do that also.
This matches than the ORDER BY img_name done by some query.
Change-Id: Ia1b89577538bdfdf751c7b9584e7c008a8c2bb1e
MemcachedClient output a generic error message: "Error parsing memcached
response\n" whenever it is not able to read from the socket. It is also
lacking the remote peer it is reading from.
This patch add a new message when fgets( <socket> ) return false, which
means we could not read from the file pointer. It also get the stream
remote name for debugging purposes.
Change-Id: I9b8a25a03af0d730aa3b4830a44b1ea739343274
$wgRequirePasswordforEmailChange to control whether password
confirmation is required for changing an email address or not.
Change-Id: Iaef440ef56d391bf9e68d15899fc81c6050722fb