Commit graph

97458 commits

Author SHA1 Message Date
Kunal Mehta
3dc37a14af shell: Demonstrate that ->restrict( RESTRICT_NONE ) is broken
Adds an intentionally failing test to demonstrate that calling
Command::restrict( Shell:RESTRICT_NONE ) is broken.

Bug: T257278
Change-Id: I0c305ae6ca8e5811f3c7b87ad5892985de19314c
2020-07-06 17:18:39 -07:00
jenkins-bot
7b453ef90f Merge "mediawiki.ui: Deprecate colorLightenPercentage and colorDarkenPercentage var" 2020-07-06 22:36:50 +00:00
jenkins-bot
dd40955a7d Merge "mediawiki.skinning: Add 'normalize' module and 'normalize.less'" 2020-07-06 22:01:51 +00:00
Volker E
6923d35ab3 mediawiki.skinning: Add 'normalize' module and 'normalize.less'
Adding 'normalize' module for stylesheet file exclusively carrying
normalizing rules for HTML elements and attributes targeted at
cross-browser bugs and inconsistencies.
'normalize.less' is heavily inspired by https://github.com/necolas/normalize.css v7.0.0
fine-tailored to only include MediaWiki specific rules and reflecting
browsers from our Basic (Grade C) support matrix.

Starting with sensible defaults:
- `body` already in use in Vector and MinveraNeue skin
- `main` already in use in MinervaNeue; fixing Vector IE 10-11 bug
- `hr` from normalize as `hr`s are in use in various skins and benefit from
  cross-browser normalization
- `abbr[ title ]` from 'elements.less'
- `pre` etc. from 'elements.less'
-  `sub, sup` from 'legacy.less' and in use by MinervaNeue
- `img` from 'elements.less'
- `::-moz-focus-inner` already in use mediawiki.ui and ULS
- `legend` already in use in MobileFrontend and numerous skins based on normalize.

Bug: T256092
Bug: T256520
Change-Id: I4601cc938f7a10dce4f643e22356f8c5a39e4ac9
2020-07-06 21:36:11 +00:00
jenkins-bot
2da65625b7 Merge "HISTORY: s/dependancies/dependencies/" 2020-07-06 20:47:21 +00:00
James D. Forrester
f1377932a7 HISTORY: s/dependancies/dependencies/
Change-Id: I6e754d3a63d5ab0dc854f869d7ae4fe513cf5394
2020-07-06 21:17:22 +01:00
jenkins-bot
5983c3650a Merge "RCFilters: Add a11y label to buttons for filtering by changes and days" 2020-07-06 19:20:21 +00:00
jenkins-bot
db314646a1 Merge "Deprecate Skin::generateDebugHTML()" 2020-07-06 18:31:53 +00:00
jenkins-bot
f98cbe4762 Merge "Fix SpecialUserrights for UserRightsProxy" 2020-07-06 18:14:00 +00:00
jenkins-bot
de1652b051 Merge "[EditPage] Mark public fields not used outside of core as internal" 2020-07-06 18:09:31 +00:00
jenkins-bot
fcf6127ecf Merge "OutputPage: Use @unstable instead of @internal for addHtmlClasses()" 2020-07-06 18:07:28 +00:00
Ammar Abdulhamid
eb1cdeaec1 Deprecate Skin::generateDebugHTML()
Users should call MWDebug::getHTMLDebugLog() directly
or get it from the data provided by SkinTemplate

Bug: T256927
Depends-On: If4c7f66198e65546ebc15401d345fbf990cb9eb2
Change-Id: I14473388ca5a254cdf487620ad95eb4b00e97efc
2020-07-06 15:53:34 +00:00
jenkins-bot
8ada06dca1 Merge "Hard deprecate the rest of the Revision class" 2020-07-06 13:57:55 +00:00
jenkins-bot
595056a4fd Merge "Use OOUI to toggle watchthis checkbox" 2020-07-06 13:24:22 +00:00
Sam Wilson
ef45410254 Use OOUI to toggle watchthis checkbox
Use OOUI instead of jQuery to toggle the edit form's watch-this
checkbox when the page's watch status is changed via the watchstar
link.

Because of this OOUI events will be fired, and the expiry dropdown
will correctly disable when the watch-this checkbox is toggled.

This is a follow-up to 4fa7d4d7a7

Bug: T248494
Change-Id: I6aa11d703a08f2f9b0dbbe29b0145ced3c5167b8
2020-07-06 12:48:18 +00:00
Thiemo Kreuz
4f814708de parser: Make use of PHP7 array deconstruction in LinkHolderArray
Change-Id: I3d4ea0726b76e9b5c1daacc379141b164e6e05cd
2020-07-06 12:30:50 +00:00
daniel
c1a73e64e1 REST me/contributions/count endpoint
Introduce endpoint for getting a uer's contribution count.

Bug: T251805
Change-Id: I409b7943941437f46dd8cdb2194fca9b7404f185
2020-07-06 09:28:33 +00:00
DannyS712
32f8a86c72 [EditPage] Mark public fields not used outside of core as internal
To simplify the upcoming refactor, mark all public fields that are
currently only used in core as internal

Bug: T247862
Bug: T20654
Change-Id: Ibee4ec1f2e750cc85d449b6e1f84d867a9604cfb
2020-07-06 09:24:58 +00:00
Translation updater bot
7402801bcb Localisation updates from https://translatewiki.net.
Change-Id: Ia829a152081287e1ab43964e3cfa03044333e8d7
2020-07-06 09:47:51 +02:00
jenkins-bot
12b002104b Merge "Fix param type in EditPage__showStandardInputs_optionsHook" 2020-07-06 07:10:19 +00:00
jenkins-bot
30add78a9a Merge "me/contributions: filter by tag" 2020-07-06 06:01:52 +00:00
jenkins-bot
e0e9d8e35b Merge "rdbms: Fix case of class name in phpdoc" 2020-07-06 03:28:20 +00:00
jenkins-bot
f3314b54b7 Merge "preferences: Fix case of wfEscapeWikiText" 2020-07-06 03:28:15 +00:00
Umherirrender
e591232e79 preferences: Fix case of wfEscapeWikiText
Change-Id: If241255f6e9d2188ba2745796209eca727ab3fb3
2020-07-05 16:51:47 +02:00
Umherirrender
2c54d984c9 rdbms: Fix case of class name in phpdoc
Change-Id: I04b6fd37c76370bda6848cf727fb0f4b35205d91
2020-07-05 16:38:48 +02:00
DannyS712
c66e3d6208 Fix SpecialUserrights for UserRightsProxy
Bug: T232568
Change-Id: Ice334c86e10e68cabaca060f2cac5f4918047f91
2020-07-04 14:23:45 +00:00
JJMC89
b18bc92c6b Create mergehistory grant for mergehistory
Bug: T257097
Change-Id: Ia726cc5fc4a1e09ce3f1a55cc75cb26b44b86b7d
2020-07-04 06:21:39 +00:00
Akinwale Alagbe
178740f130 RCFilters: Add a11y label to buttons for filtering by changes and days
Screen reader just announced "x changes, y days", it didn't announce the meaning
of the button. We added an aria-label property to the button to make it
accessible to visually impaired audiences.

Bug: T246178
Change-Id: I89d3e434f87d7997b1200133a9286ad35556442a
2020-07-03 20:19:01 +00:00
Lucas Werkmeister
2585f244c4 Fix param type in EditPage__showStandardInputs_optionsHook
In EditPage::showStandardInputs, where the hook is called, the $tabIndex
looks like it will always be an int, not a string.

Change-Id: If3bd9f628e29d078b524242f51f120a27f7ed35e
2020-07-03 18:31:05 +02:00
jenkins-bot
5de63c7396 Merge "Revert "Adding = as a parser function"" 2020-07-03 15:21:54 +00:00
C. Scott Ananian
9bd4fc0ae9 Revert "Adding = as a parser function"
This reverts commit 4bc0dc348a.

Reason for revert: Dutch Wikitionary uses {{=}} for something else;
see https://phabricator.wikimedia.org/T91154#6276915 for details.

Revert for now so it doesn't disrupt next week's train, we'll add it back with a config var or some other mitigation.

Bug: T91154
Change-Id: I9f81c7b73a04d6c1d77b67ce311cc7e6d279eb8b
2020-07-03 14:52:27 +00:00
jenkins-bot
804abf07f3 Merge "Fix some incomplete PHPDocs in Revision and related" 2020-07-03 11:57:32 +00:00
jenkins-bot
6f53c6279e Merge "Enforce maximum reason length in forms" 2020-07-03 11:54:24 +00:00
jenkins-bot
c3ca89215b Merge "EditResultBuilder: use RevisionRecord::hasSameContent" 2020-07-03 11:33:20 +00:00
jenkins-bot
9587703066 Merge "skins: Remove unused by-reference & from BaseTemplate" 2020-07-03 09:17:55 +00:00
Thiemo Kreuz
6e246aa176 skins: Remove unused by-reference & from BaseTemplate
Change-Id: Id40d2732332b1a0b186917927645c65ccd60abe6
2020-07-03 08:41:27 +00:00
Translation updater bot
39688e358e Localisation updates from https://translatewiki.net.
Change-Id: I294072b05910dcbff2207af8570fef4fb9f79dd1
2020-07-03 08:30:59 +02:00
jenkins-bot
5f021592d5 Merge "SpecialUserrights: If a viewer lacks hideuser, ignore hidden users" 2020-07-03 05:05:24 +00:00
jenkins-bot
759e58082f Merge "DBConnRef: Remove check for spl_object_id existing, always available" 2020-07-03 04:23:42 +00:00
jenkins-bot
508b851296 Merge "Debug: include username in User::getBlockedStatus wfDebug call" 2020-07-03 04:23:36 +00:00
jenkins-bot
4eecaeecf9 Merge "HookRunner: Add missing return for RevisionFromEditComplete" 2020-07-03 04:23:30 +00:00
jenkins-bot
f7ec52ebd0 Merge "maintenance/blockUsers.php: Check only for prior DatabaseBlocks" 2020-07-03 04:19:11 +00:00
jenkins-bot
96baa0693d Merge "Replace uses of Revision constants" 2020-07-03 04:19:05 +00:00
DannyS712
0867a4e870 SpecialUserrights: If a viewer lacks hideuser, ignore hidden users
Hidden users will be treated as if the account doesn't exist.

Bug: T232568
Change-Id: I8ebe77cbae9891ea2e58c837983860762c4d3794
2020-07-03 04:15:04 +00:00
DannyS712
f60b1c4240 HookRunner: Add missing return for RevisionFromEditComplete
Change-Id: I7f523f3cbfacea62bb245a112e4377a81ce53e08
2020-07-03 03:58:59 +00:00
Thalia
0a847ae6dd maintenance/blockUsers.php: Check only for prior DatabaseBlocks
BlockUsers needs to know if there is a block stored in the database
against a particular user account. This is answered by
DatabaseBlock::newFromTarget.

Prior to this, the script called User::getBlock, which can return
SystemBlocks and CompositeBlocks too. These are not stored in the
database, so are irrelevant and would cause an error on attempting to
update them.

It also meant parameter types for BlockIpCompleteHook needed to be
changed to AbstractBlock in a302833fc3.
This changes them back to DatabaseBlock.

Change-Id: Iec90d4938e76d76ac1f5b1d1e9ffb736a58d5c53
2020-07-03 03:50:56 +00:00
jenkins-bot
5499034af2 Merge "HeaderCallback: Sanitize cookie values in debug logs" 2020-07-03 03:28:53 +00:00
jenkins-bot
f38a514785 Merge "Set X-Request-Id on all web responses" 2020-07-03 03:23:05 +00:00
DannyS712
2f4b71fc6c Replace uses of Revision constants
Bug: T257010
Change-Id: Id63123e8b8becd31756d5b68ca11edb238ec8a59
2020-07-03 01:23:44 +00:00
Volker E
7ed868cc4e mediawiki.ui: Deprecate colorLightenPercentage and colorDarkenPercentage var
Deprecate both variables, that have not been standardized to Wikimedia Design
Style Guide and are not part of WikimediaUI Base. They are exclusively used by
'anchors.less' mixin, which is going to be removed and Flow, the only
product that will continue to have an extension specific 'anchors.less'.

Change-Id: Ie0bd6403f906a172d606c18176cc60acc72b7662
2020-07-02 16:45:46 -07:00