Readd the language Toki Pona (tok) to Names.php, this time with a
ISO 639-3 code.
Bug: T300378
Bug: T236938
Change-Id: I5c8a7079d05b8d3d4104ae4c908aff55acf4c20f
Two micro-optimizations are done in this patch:
1. We know exactly how these placeholders are built in the makeHolder()
method. In »<!--IWLINK'" 1-->« it's guaranteed to be a single number
and in »<!--LINK'" 1:2-->« it's two numbers.
The most extreme synthetic micro benchmark I did cuts the runtime of
these regular expressions down to about 25%. It won't make much of a
difference in real-world scenarios but is still worth it, I believe.
It also makes the code more specific and less confusing (see below).
2. We don't need to use the full string »<!--LINK'" 1:2-->« as array
key when the only thing that matters is the part »1:2«. Note the same
is done just a few lines below in the replaceInterwiki() method.
This code does have outstanding test coverage via all the parser tests,
I believe. Any change here that doesn't make a test fail should be safe.
Note the unit tests have been written many years later via I2c12cc7,
using "dummy" strings and such instead of the expected numeric
namespace and link ids. Most of this is already fixed via previous
patches. The last mistake addressed in this patch is that
getPrefixedDBkey() is supposed to be a title. It can't contain one of
these placeholders.
Follow-Up: I2c12cc76a9bf01eb527db3ea038e4adc59446cac
Change-Id: Ie994059092df8861ddb97c098acd082698d45c53
When gauging the state of servers during LoadMonitor cache regeneration,
use these flags to prevent expensive timeouts and stalls while trying to
pick a server to use for DB_REPLICA.
Note that https://bugs.php.net/bug.php?id=76703 prevents the changing of
read timeouts after connection.
Removed some outdated Database::getConnection() comments.
Bug: T265386
Change-Id: I20ff8f761290dcb69d7971a91091bb950c0afe38
When calling UserOptionsManager to "change" an option to a value
equal to the default, when that option wasn't overriden (inherits the
default), it still sent a delete query to the database when we knew
the row doesn't exist.
Bug: T301506
Change-Id: I9bd1f188a977d966b40c1320c105dbc9bfd0eb3c
* Move `deadlockLoop()` entry that was wrongly in the Deprecations
section to the Breaking changes section.
* Fix `getTransactionRoundStage()` entry which wrongly claimed to
be in LBFactory but was in LoadBalancer.
Change-Id: I77830899909159d2604bcd494b5b863cacfe08f3
- Use a non-capturing group and positive look-ahead assertion, use the
overall capture as result
- Use substr_compare to compare strings
- Remove unneeded variable assigment
- Use array_pop to get the last element
- Remove unneeded isset/empty checks
- Change behaviour of $wsEnd to avoid +1 everywhere
Change-Id: Ifc1728b09743ec91908b59c09ac34598d9cd8b49
Creation of dynamic property Mock_AuthenticationRequest_4d271de1::$done
is deprecated in php8.2
Bug: T314099
Change-Id: I21e7a257a5e695cc32f183add5ba6785a6898118
Creation of dynamic property GIFMetadataExtractorTest::$mediaPath is
deprecated in php8.2
Bug: T314099
Change-Id: I3247925a548586713d4363fc9e11625bc4c9ad46
Creation of dynamic property UploadSourceAdapter::$context is deprecated
in php8.2
Prototyp says this property must exists
https://www.php.net/manual/en/class.streamwrapper.php
Bug: T314099
Change-Id: I8f8b42c2ea3351a3becdfac36248f6d371c32fe3
Deprecated: Creation of dynamic property
Wikimedia\Reflection\GhostFieldTestClass::$privateField is deprecated in
/workspace/src/tests/phpunit/includes/libs/serialization/SerializationTestUtils.php
on line 150
Bug: T314099
Change-Id: Ic1cd7a3560e6fe39e6c7b077f42c90fbc844c202
The gallery code should be more resilient to HTML transformations
that can occur inside mobile app and MobileFrontend (or gadgets).
Data attributes are generally left untouched, so provide this
information as part of the output of the LI element so that the
gallery code can make use of it where possible.
This resolves the problem of lazy loaded images in the mobile site
meaning the hook added for MobileFrontend can also be removed.
Follow up to I58e18924c02fe12baba820f25b7a6f0c437a206b
Bug: T194887
Change-Id: I186bb0dbbea84d4dbb1d7b55278c69b2b46603de
Some minor changes to silence the IDE
- Removed some unnecessary branching
- Use strict comparison where possible
- Use self::
Change-Id: Ica98f2d02520c9537f71dfd517a397828bf68848
