Just disabling the `declaration-property-unit-disallowed-list` failures
for now, but it looks like at least most of these could be switched over
to ems without breaking anything. For another patch!
Change-Id: I9220334d670f71eba1b0e392da826036d54bc2f3
`list-style: none none` was a workaround for an IE 6 & 7 rendering issue.
Same goes for `list-style-image: none; list-style-type: none;` combination.
Let's unify to shorthand `list-style: none` for any non-ancient browser.
Change-Id: I05f00db8a08a9fc1523ea00fab91e91d3c00cab3
The installer needs a handful of the styles provided by
ResourceLoaderSkinModule. Reduce it to the minimum required in
preparation for the deprecation of the `legacy` feature.
Bug: T232903
Change-Id: I6a718232897448a94fe1ddda547ae5a5c671b7aa
Now that Html::infobox is deprecated in 1.36 let's make sure it's
clear the styles are too.
No release note is needed given the already existing note about
Html::infobox.
Styles are copied to the installer for now, but please note
their future standardization in T232903.
Bug: T268194
Change-Id: I5f7929e698c99e73f5186aa4d9bfe5f7788c12a1
Follows-up 00e8bde685, which removed loading of Vector styles.
Let the Installer maintain its own appearance instead.
Bug: T248133
Change-Id: Ibdb0a72083a837a369d8d660c79fecd5aac55407
This avoids an overlap of the help box with the floating page list.
The min-width:min-content prevents that long words get cut.
Change-Id: I2d9f38e84d6030de6b00f7105a8373ff9b69e0f9
`dirname()`: https://www.php.net/manual/en/function.dirname.php,
has a levels param that can be used for indicate the number of parent
directories to go up!
Change-Id: Ibdf6fbedbcf9b0eead1cfbf822d24ccae6652f3f
Changes in the behavior:
* The expanding/collapsing now works even with disabled JavaScript.
* There is no FOUC on loading anymore.
* The animation on show/hide is absent.
Change-Id: I1b88d8e2cdbb1c969670a7a8637dba10bf447330
Wow, so many opt-outs, and a lot of probably-not-going-to-change ones.
Actually wanted pattern:
* "^mw-…"
Content-related classes we're probably not going to scrap:
* "^wikitable$"
Hard-to-change classes used in lots of skins:
* "^toc$"
* "^toctoggle$"
* "^tochidden$"
Necessary for over-rides/specificity battles:
* "^oo-ui-…"
Probably worth considering changing soon:
* "^client-js$"
* "^client-nojs$"
Some of the exemptions have been applied to deprecated styles (where they're being
renamed); some are for code in entirely deprecated areas themselves; some have the
"wrong" name but sit alongside classes with an appropriate one. And some are, very
clearly, in the wrong repo. Such sigh.
Change-Id: I9b8423d53b6750b5ca79d2f69e111f75c93c5bdc
This is inspired by Ib117e05.
As far as I can tell this is functionally identical. Even arrays should
behave the same, as both the getVal() and getCheck() methods do have a
special case that returns the `null` default in case the user tried to
pass multiple values instead of a single scalar.
Change-Id: Id4e4ec91f39d3c39461bd41673bdafc3bde11737
* Remove obsolete handling for 'load.php', which no longer
uses this check. This hasn't been used for several releases.
* Remove the 'entryPoint' parameter in favour of 'format',
which it was already a proxy for.
* Move the double dirname() logic to mw-config/index.php.
Bug: T189966
Change-Id: I343216442475d36e61213900f196ab6ec5f6b747
Follows-up Id6d13bbea6:
- '$': mw.loader.implement does this already.
- 'mw': Use the canonical name directly.
This replaces the following patterns:
File closures (common):
- `( function ( $, mw ) {` => `( function () {`
- `( function ( $ ) {` => `( function () {`
- `( function ( mw ) {` => `( function () {`
- `( function ( mw, $ ) {` => `( function () {`
File closures (rare):
- `( function ( mw, $, OO ) {` => `( function () {`
- `( function ( mw, OO, $ ) {` => `( function () {`
- `( function ( mw, document ) {` => `( function () {`
Combined dom-ready and file closure (rare):
- `jQuery( function ( $ ) {` => `$( function () {
- `jQuery( function () {` => `$( function () {
Remaining references in files without a closure, as found by
the new ESLint setting (rare):
- `jQuery` => `$`
- `mediaWiki` => `mw`
Change-Id: I7cf2426cde597259e8c6f3f6f615a1a81a0ca82b
When the radio button is already on "other" then the input field for
the namespace should not get hidden by JavaScript on load.
Also remove the readonly attribute in HTML because the readonly
attribute can not get removed with disabled JavaScript.
Change-Id: I8cfde90d791765234572caf00b731881ac2eda48
Follows-up c8833d8e8e.
* Select the input elements by class to avoid accidentally trigging
on unrelated elements elsewhere on the page in the future, given
the generic selector.
* Use on('change') instead of deprecated change() alias.
* Set properties directly instead of via prop() indirection.
* Get attribute directly instead of via data() indirection.
Change-Id: I5158aa26b5fd7327d6795f0a31bbffbe99043fbf
As there will likely be extensions bundled with the 1.31 release that
depend upon other extensions, we should have the installer prevent users
from enabling extensions that depend on other, not-enabled extensions.
We can build a dependency map from extension.json's "requires"
component. On the client-side, we'll first disable all checkboxes that
require other extensions, and evaluate each checkbox click, updating the
disabled checkboxes as possible.
This required some refactoring of how ExtensionRegistry reports issues
with dependency resolution so we could get a list of what was missing.
While we're at it, sort the extensions under headings by type.
This does not support skins that have dependencies yet (T186092).
Bug: T31134
Bug: T55985
Change-Id: I5f0e3b1b540b5ef6f9b8e3fc2bbaad1c65b4b680
The textarea is for extension update messages to go, but in some cases
extensions don't create any tables so you're left with an empty,
confusing textbox. Hide it with CSS if it's empty, since that's an
expected condition.
Bug: T48802
Change-Id: I798d07d1d6ed65011e9f2a2ac5cc77ad0595df7d
Because it doesn't work. `phpcs:ignoreFile` is intended as a performance
shortcut, and gives up on the file as soon as that token is found.
Instead, use `phpcs:disable` which does support selectively disabling
some sniffs. And since disabling is local to the file, there's no need
to re-enable it at the bottom of the file.
<https://github.com/squizlabs/PHP_CodeSniffer/issues/1903> has some
relevant discussion and clarification from upstream on this.
And make the files that are now being re-enabled pass PHPCS.
Change-Id: Ia4d8c45045f61cf9f24eb1d8631ff98d99c82d69
`$textbox.removeProp('readonly')` has no effect and leaves the input
still as readonly, so instead use `$textbox.prop( 'readonly', false )`,
which does work.
Bug: T188415
Change-Id: I898c5605caf383cc992a948f14294193460f761b
Clean up use of @codingStandardsIgnore
- @codingStandardsIgnoreFile -> phpcs:ignoreFile
- @codingStandardsIgnoreLine -> phpcs:ignore
- @codingStandardsIgnoreStart -> phpcs:disable
- @codingStandardsIgnoreEnd -> phpcs:enable
For phpcs:disable always the necessary sniffs are provided.
Some start/end pairs are changed to line ignore
Change-Id: I92ef235849bcc349c69e53504e664a155dd162c8
This file should remain compatible with PHP 5.3, so that we can
actually display the error message about old PHP version, rather than
a syntax error.
Change-Id: If12f79f5d375e925291728aac7c9db18ca226d26
Instead of "don't edit this file, edit that file", do it settings.d
style where packagers can drop their stuff in mw-config/overrides.
I propose to backport it to 1.27 because LTS.
Bug: T135695
Change-Id: I2661ba2036b2887d31ab356751d731cc8b499f26
* Function calls to calc should use operators with spaces
* Function calls should not be split over lines
* Function calls should have a space after each comma
* Function calls should have space inside of the parentheses
* Function calls should not quote url parameters
Change-Id: Ia35f0bb5ca2dde23ce4ec90256b4fa958203e1cc
* Font families should be quoted unless keywords (''Times'' not 'Times')
* Font weights should be named where possible ('bold' not '700')
Change-Id: I20194c2998efb71db4da5ea79234a81dc90b55ea
* Hex colours must be in short form where possible ('fff' not 'ffffff')
* Hex colours must be used over named colours ('fff' not 'white')
* Hex colours must be valid ('fff' not 'ffq')
Change-Id: I2ba04cc3ad9898c17fee3c65bb3bead834c3a1fd
