For example, leftover cruft in `log_search` will cause spurious
associated_rev links between unrelated revisions and log entries.
Bug: T227849
Change-Id: Ie344522229e4142f2c61a267b4d693051b813236
Test the intersection of $tablesUsed with each set of tables
separately and only update it afterwards. Without this fix, overlaps
between the table groups would cause additional groups to be pulled in
unnecessarily.
Change-Id: I1b2a6eb47e061dee8a27fb4779809b4684c05104
Using * in select is not the prefered way.
List all needed columns to make the use visible and to avoid issues when
new fields gets added with big data.
As each column name is unique there is no need to get the table name for
prefixing the columns
The following columns no longer selected:
- log_user_text -> not used due to use of ActorMigration class
- log_actor -> Add by ActorMigration class
- log_comment_id -> Added by CommentStore
- log_page -> Unused in the writer, the ns/title pair is used instead
Move the arrays out of the loop, because there are not depending on
values changing in the loop
Change-Id: I140641b7ed75bc2b8db2e7612020d668f1be663b
Mail::send accepts mixed for recipients and only array for headers
The documentation for recipients allows string with comma-separated list
or a string array
https://github.com/pear/Mail/blob/master/Mail/mail.php#L115-L119
Change-Id: Ia8269e91a7dcfe09d41bd03f8830b83f28812564
I would like to argue this is best practice. This also currently blocks
https://gerrit.wikimedia.org/r/521480
Change-Id: I8477f8280038c383c35bebf559ba2b5841748821
JPEG files can have trailing \0 chars at the end of the XMP value. Use
trim() to remove these from the string value.
Bug: T118799
Change-Id: Id4ab223ef432e5d2c0dd3b4e332320db02422700
Should be string or bool and not a float. The reason 49bbfc7 was
not triggered is because the deprecated code path is no longer being
executed in production.
Change-Id: Ieeffb8a6cc7177c52b4c54d66152c90ded1dc248
If the foreign API has the same host as the current page (e. g. if it’s
actually the same wiki, or multiple wikis are installed under different
paths on the same host), then the browser will not send an Origin
header, and if we still set an origin parameter, then the API will
complain that the two don’t match. Detect this and unset the origin
parameter in that case.
Bug: T208601
Change-Id: Ia006f3dc3283ce3f81d4d72cbe9676a00797c4d0
This adds a parameter to SpecialRunJobs that lets it output statistics
about the jobs it has run.
The 'reached' field can be used to detect when the queue is emopty,
which is essential to know for clients that want to flush the entire
job queue, to ensure that all effects of any actions they have taken
have been processed.
More specifically, this provides a way for an external testing framework
to run all jobs after an action, so it can observe and assert the
effects of that action.
Bug: T231822
Change-Id: Ibb38490afca71efeb67300b9665951c429c19a3c
