Also, as this method is never called with an argument in any Gerrit-hosted
extension, shortened it to just `throw new ReadOnlyError;` on the assumption
that the removed portion was only left in for EditPage.
Change-Id: Icc2fc166b155eac548dfd5f3e67b0b1f92ef90d3
* Regular unchecked
* Regular checked (added)
* Disabled unchecked
* Disabled checked
Although you can obviously check and uncheck it yourself, it's easier
for the user to show them the permutations on page load. Otherwise,
they might not even notice the special check mark image.
Also, fix a couple unrelated typos in buttons.less.
Change-Id: I17b63eeb424e23d1c3b9ce9ab8bfaa66b5bf4a46
Per Tim Starling's review of Icb239471, reverted back to the version of
the function from Patch Set 1 of Iece006ec, which did not have the bug.
This version does not attempt to minimize the inevitable leakage of the
string's length.
Also revised the doc comment to explain more effectively what the problem
with a normal (===) string comparison is for the use cases of this function.
Follows-up b9e1d5f5c0.
Change-Id: I1b347e69b39af3d7d8ba6673af63f1a616befbdf
Avoid an unnecessary serialize() call on get() requests, which makes it
faster and also happens to work around a nasty crash bug which is
causing lots of segfaults right now.
CAS semantics should be the same, if the caller handles a CAS token in
an opaque way and does not assume it is a string. I could only find one
caller of cas() in core and WMF deployed extensions, and that is
BagOStuff::mergeViaCas(), which does correctly handle CAS tokens of any
type.
Bug: 71724
Change-Id: I0b0b5f0157c005ec7f76210dfb8576c056314733
Follows-up af66c04.
The tests depend indirectly on wgSecretKey (used by
MWCryptHKDF::generateHex). On test installs I tend to set this
to "example" or "***", which is less than 16 characters and thus
the unit tests failed with "MWCryptHKDF secret was too short".
Change-Id: I9a85fd9fbb345863e4837fed2910d60ebf1b0d83
Abstracts the logic for restoration into the built-in teardown()
handler.
Also purify the test configuration by setting wgHooks and
wgFileExtensions to otherwise empty arrays instead of extending
existing ones.
Change-Id: Ied65ee62f658dd650c603a54e72cd19965867a8f
Previously, non-MediaWiki exceptions were logged only for api requests,
job runner, resource loader, etc. but not for general requests
such as page views.
Bug: 61914
Change-Id: Id4de5cac0b9996a98cdaf5e73655d49fa55ea8c3
This adds the mw-searchInput class so suggestions are given by
mediawiki.searchSuggest (if loaded by the skin).
Bug: 65209
Change-Id: If4ae687ba125c002eedce114820a271cf615011b
This has been broken since r9199 / e0ce5a322e41; a DB query error will occur
because the links table no longer exists, and even if the table were to
exist, the pl_* columns would not exist in that table.
There is no usage in core or Gerrit-hosted extensions.
Change-Id: I4922f85417bfb4d40f08662ba100ab5b78edd5fb
New changes:
6c91643 Make buttons respond to :active events
9137aaf Move window overlay up to be a sibling of the frame
19d8c83 ComboBoxWidget: Append menu to $overlay option
eb0fcb8 InlineMenuWidget: Fix documentation
19d2c2b SelectWidget: Fix typos in documentation
495d281 TextInputMenuWidget: Fix typo in documentation
b4ae961 Toolbar: Correctly display "More" label on catch-all groups
32e769e Toolbar demo: Fix tool name mismatch
e9983b6 build: Clean up Grunt config and add missing csscomb run
Change-Id: I1ee2e51460c709fa01934ae7d58ac8411b124867
Show the categories box at the bottom of the page,
which more accurately represents what the page would
look like and allows users to see the effective
categories of the expanded page.
Bug: 71633
Change-Id: I4c003fb1f42b29602cd8924b224ff7642e8cf857
Just preload user page and talk, when the personal bar is shown.
Use Skin::getRelevantTitle for the title to have the correct title
preloaded, when using for example [[Special:WhatLinksHere]].
Change-Id: I4363a9f3fd909cfdc341dc1a8c6c0189efd9b736
Replaced by an array() and removed an unused variable near by.
Follow-Up: I61bb3c358f755ed9f2153d94b744c1a9da02c456
Change-Id: I5c4dc22e1e9346bfc410a9dda4353d5297a5825e
Some platforms (especially certain linux distros) use slightly wider
sans-serifs than others by default. Bolding these wider fonts has a
more significant size impact than with narrower ones, so because the
h3 is bold and the h2 is not, a little more distance between their
defined sizes should ensure that the h3 will remain smaller than the
h2 regardless of platform.
Bug: 69999
Change-Id: I667c60f553d67e5208c708446f13b0773ad11ace
