I believe we don't need this any more. A test should never leave an
uploaded image behind, but delete it. It should be totally fine when
the same trivial test uploads the same image over and over again. All
the extra complexity to trick MediaWiki's duplicate detection shouldn't
be necessary (any more).
Also change the default to svg instead of jpg. Again, this creates much
smaller files with much less effort.
Note this code was already mostly unused because of the previous patch
I7f3d586.
Change-Id: I5c16ba7bed0fffa43549b786e50d6d1dd5592ad0
This allows a primary auth providers to update the "remember me" status
of another primary provider in the same login request flow. If authentication
that happened elsewhere and a "remember me" / "keep me logged in" (extended
login period is selected), the value of this action applied by the remote
primary provider should be applied to the local wiki when the user is
redirected back to continue authentication there.
This is useful because:
In the case of Wikimedia's central domain wiki in SUL3 mode, we want to
apply the remember me (keep me logged in) flag value from the central domain
to the local domain.
Bug: T369668
Change-Id: I6e2e2d892d2b777cb4757c7c0d222afad9da506c
Add doc-typehints to class properties found by the PropertyDocumentation
sniff to improve the documentation.
Once the sniff is enabled it avoids that new code is missing type
declarations. This is focused on documentation and does not change code.
Change-Id: I1106dd167dc2188ed91d1884e979b5cea303f722
Conventions for extension REST module names, and the associated
versions, are being established. Initial speculation was to use
a period as a separator, but consensus instead was to use a slash.
Modify the content module's paths accordingly.
Change-Id: Iea9e3fda8d274ebd341d9331458d37247a0384e2
It removes use of already deprecated global functions,
wfParseUrl and wfAssembleUrl by use of PHP's parse_url
and use of UrlUtils::assemble copy.
Change-Id: I07a5b351973228ea2e4545d042bb53ddf2c5730a
Better emphasize that there should only be one string that callers use
to reference a given table. This is what ChangedTablesTracker relies on
for write queries. For read queries, databases can be vertically sharded
on different servers or remapped using virtual domains, so the use of
"db.table" notation should be discouraged there as well.
Mention that "information_schema." is allowed as well as unqualified
table names.
Change-Id: I0b6295d0dd58aafd09a5c99aaf0ae9a81641d55a
Why:
* The 'logout' API allows users to logout of their account
* This calls the "UserLogoutComplete" hook which users assume
is only called when a logout is successful.
* However, the hook is called by the API even if the user making
the request was not logged in
* The Special:UserLogout page does not call the hook if the user
performing the request is already logged out.
What:
* Return early in ApiLogout::execute if the user is not logged
in, and also add a warning to the response to indicate this.
Bug: T374353
Change-Id: I72e73c2391a475cec2e5cb24250f9aa2b792e5de
Why:
- In WDIO < 9, the function to be run by browser.execute() must be
synchronous.[1] Asynchronous code should be run via executeAsync()
instead.[2]
- isTargetNotWikitext() however runs asynchronous code via execute(),
which may be interfering with tests.
What:
- Have isTargetNotWikitext() use executeAsync() instead.
[1] https://v7.webdriver.io/docs/api/browser/execute/
[2] https://v7.webdriver.io/docs/api/browser/executeAsync/
Change-Id: I05aaf8d89c5b52ffc94f70a4f887a98a99037027
