Commit graph

103 commits

Author SHA1 Message Date
James D. Forrester
4bae64d1c7 Namespace includes/context
Bug: T353458
Change-Id: I4dbef138fd0110c14c70214282519189d70c94fb
2024-02-08 11:07:01 -05:00
Amir Sarabadani
877546a2de installer: Make logo preview use codex elements
Currently, it is unstyled divs that don't look very well.
Alternative approach to I85e38a9ff16979f

Change-Id: Ic5cb76dbc4c919e059a6648200feecc037326230
2024-02-06 23:40:02 +00:00
Reedy
8600ee105c installer: Namespace more installer classes
Change-Id: If58d96c311bef728446b517bb7a81316b23aad4d
2024-01-13 23:42:08 +00:00
Tim Starling
9e0ab669f0 Installer: Remove Creative Commons license chooser iframe
This chooser has been removed from the Creative Commons website, and the
URL we are using now redirects to an apparently random 2006 blog post.

There is a new license chooser, with source at
https://github.com/creativecommons/chooser , but it does not support the
kind of embedding we need.

So, remove the feature.

Change-Id: I400777b2ae80198ba1db6bd105de38903afced6f
2024-01-11 14:05:11 +11:00
Amir Sarabadani
bccdfd85da Redesign the installer with Codex
It is not perfect, but it's a major improvement compared the existing
one. We need to clean up a lot more once it has landed but it's a good
start.

Bug: T337435
Change-Id: I1f85110e754546c797d3325b8dd6878093790266
2023-12-13 14:25:38 +01:00
thiemowmde
ce95ca5321 Make use of jQuery method chaining where it makes sense
It's not always better to arrange code this way because it makes the
lines depend on each other and makes it a little harder to change one
line without changing the others. But I feel like it makes a lot of
sense in these cases. These method calls are not independend from
each other.

Change-Id: I6b223018d900b907933e9d4ed010af47f92ed37d
2023-02-14 09:17:04 +01:00
jenkins-bot
dde9c55fd6 Merge "Use SVG instead of GIF for help-questionmark" 2022-10-26 17:08:31 +00:00
Fomafix
addf41d06d Use SVG instead of GIF for help-questionmark
Change-Id: Ibcaba746b912aa17da8423115d633a074c2f6038
2022-10-26 16:49:39 +00:00
Jon Robson
d3f34664d7 Installer: Disable logo dropper for now
A follow up will restore this with required
functionality

Bug: T318753
Change-Id: I1a41d83594497ea7c64f358145d4eb24429fd7a5
2022-10-06 11:49:31 -07:00
Volker E
96fb3fb408 WebInstaller: Increase #mw-panel width to 11em
Take all available space to improve rendering of portal contents
in languages like German and Russian with long words.

Bug: T318205
Change-Id: I6e8a5fe4e8358751085ecadf0a6c63a007095584
2022-09-30 17:47:26 +02:00
Volker E
0738913d65 WebInstaller: Lighten success message and add top margin
Lighten success message slightly while still complying to WCAG 2.0 AA
contrast ratio. Also add top margin to the message to set it better
apart from installer config messages above.

Bug: T318204
Change-Id: Ic9b8b940f1598667bb5e184ac14dc3b9ab474d38
2022-09-30 17:47:26 +02:00
Volker E
c304af2a45 WebInstaller: Remove inlined inconsistent bullet image and indent
Removing the bullet image and indent the (fake) list items to
makes the text more readable.

Bug: T318203
Change-Id: I495b0a6a3c4c28a40fadbf054396d38ada1d550c
2022-09-30 17:47:26 +02:00
Volker E
644af7fac8 WebInstaller: Unify background colors and sort background props first
Use one background color shade `#f7f7f7` and not two similar ones
including `#f6f6f6`.
Also sort the background properties first to better orientate in the
code aligning to CSS property order proposal.

Change-Id: I70ed641521640218c8d17c10a021df9b1e52dc30
2022-09-30 17:38:34 +02:00
Volker E
32dd10b1b2 WebInstaller: Increase line-height for legibility
Bug: T318202
Change-Id: Ie0d0e177b8c8aad9db295bc5bfabf1abbff1bc87
2022-09-30 17:38:33 +02:00
Volker E
b39e48a54a WebInstaller: Increase color contrast of coming installation steps
Bug: T318200
Change-Id: I9ff6e79842ea8a8aa746897854712e0cf4cca838
2022-09-30 17:38:33 +02:00
Ed Sanders
4c845198b0 build: Update stylelint-config-wikimedia to 0.13.0
Change-Id: I59c7507fef057a880bca62a156662ee66f89ed94
2022-05-04 23:17:03 +01:00
Jon Robson
9bd3af32fc Update installer to reflect modern logos
There are now 4 types of logos, only one of which is needed.
Update documentation in installer to reflect this.
Also make it possible to drag and drop files into the installer
and see live previews of what the logos will look like to aid
setup.

The 1x is no longer required.

Bug: T255913
Change-Id: I58226ae8fb02c32d2eeea65a50aaabbc193cb51c
2022-03-10 16:48:39 +00:00
Ed Sanders
9e234e6a37 eslint: Only apply client rules to client files
Change-Id: I757b9616ce69b6020e9f0e556e006d39de59eb01
2022-02-09 02:40:11 +00:00
James D. Forrester
d3078c0926 build: Upgrade stylelint-config-wikimedia from 0.10.3 to 0.11.1
Just disabling the `declaration-property-unit-disallowed-list` failures
for now, but it looks like at least most of these could be switched over
to ems without breaking anything. For another patch!

Change-Id: I9220334d670f71eba1b0e392da826036d54bc2f3
2021-06-29 11:22:30 +01:00
Ed Sanders
b089533e03 stylelint: Enforce no-unsupported-browser-features
Change-Id: Ic4fb9d27aa94594584327a3d1fc5495861e09ebd
2021-06-05 14:42:03 +01:00
Volker E
14dc9229b4 Unify list-style CSS
`list-style: none none` was a workaround for an IE 6 & 7 rendering issue.
Same goes for `list-style-image: none; list-style-type: none;` combination.
Let's unify to shorthand `list-style: none` for any non-ancient browser.

Change-Id: I05f00db8a08a9fc1523ea00fab91e91d3c00cab3
2021-05-03 01:26:50 -07:00
jdlrobson
046c0b8a9a Installer: Simplify stylesheet
The installer needs a handful of the styles provided by
ResourceLoaderSkinModule. Reduce it to the minimum required in
preparation for the deprecation of the `legacy` feature.

Bug: T232903
Change-Id: I6a718232897448a94fe1ddda547ae5a5c671b7aa
2021-04-20 00:53:13 +00:00
jdlrobson
251405ed02 Installer: The installer should use .warningbox for styling warnings, not .mw-infobox
Bug: T232903
Change-Id: Ibf6426ab90445d7aac94d59336e25957cf48fc1f
2021-04-15 20:55:44 +00:00
Amir Sarabadani
ba3a2b0c40 Use the new mediawiki logos
These logos are approved as part of a community decision making in https://w.wiki/33kx
(Long URL [1]). The rights have been transferred to WMF now.

License: CC-BY-SA 4.0
Author: https://commons.wikimedia.org/wiki/User:Serhio_Magpie
Source: https://commons.wikimedia.org/wiki/Category:MediaWiki_logo_(2020)
[1]: https://www.mediawiki.org/wiki/Project:Proposal_for_changing_logo_of_MediaWiki,_2020

Bug: T268230
Change-Id: Ia588ca79a721f4796e7fe688dd7e538a009f706d
2021-04-01 01:22:33 +02:00
jdlrobson
ee0c7798cc Mark .mw-infobox styles as deprecated
Now that Html::infobox is deprecated in 1.36 let's make sure it's
clear the styles are too.

No release note is needed given the already existing note about
Html::infobox.

Styles are copied to the installer for now, but please note
their future standardization in T232903.

Bug: T268194
Change-Id: I5f7929e698c99e73f5186aa4d9bfe5f7788c12a1
2021-02-09 12:46:18 +01:00
jenkins-bot
9f868e6803 Merge "installer: Add overflow:hidden to help box" 2020-05-28 20:36:41 +00:00
jdlrobson
28090bfe39 installer: Add Installer-specific stylesheet
Follows-up 00e8bde685, which removed loading of Vector styles.
Let the Installer maintain its own appearance instead.

Bug: T248133
Change-Id: Ibdb0a72083a837a369d8d660c79fecd5aac55407
2020-04-03 21:00:19 +00:00
Fomafix
4e7c376d29 installer: Add overflow:hidden to help box
This avoids an overlap of the help box with the floating page list.

The min-width:min-content prevents that long words get cut.

Change-Id: I2d9f38e84d6030de6b00f7105a8373ff9b69e0f9
2020-03-30 14:42:52 +02:00
Jforrester
c9d34f345c Revert "mw-config: Avoid nested calls to dirname(), use levels"
This reverts commit 7099094805.

Reason for revert: Let's maintain PHP4-compat.

Change-Id: I47b9b758fc3cf4df5c49bd148706f69e567b2440
2020-02-07 17:55:04 +00:00
Derick A
7099094805 mw-config: Avoid nested calls to dirname(), use levels
`dirname()`: https://www.php.net/manual/en/function.dirname.php,
has a levels param that can be used for indicate the number of parent
directories to go up!

Change-Id: Ibdf6fbedbcf9b0eead1cfbf822d24ccae6652f3f
2020-02-04 16:53:09 +00:00
Aryeh Gregor
0de9c47b50 Remove Language::factory and getParentLanguage use
Change-Id: I11f8801ef47ec1a1f63d840116e69667e6f3ae3c
2019-10-27 12:34:28 +02:00
Volker E
05bd4c6aa5 Remove obsolete IE 6 & 7 specific comments
Bug: T234582
Change-Id: I9c29ba771d7963492d9cc231069a5283c1ee7760
2019-10-04 19:01:56 +00:00
Volker E
93643275a0 Remove IE 6 & 7 hasLayout hacks
Bug: T234582
Change-Id: I029f41c468a4d7bae9b0d2657dacb91401c8f91a
2019-10-04 19:01:48 +00:00
Volker E
4d8763ef49 Remove unused .success-box class
Change-Id: Ie5ecaed60fc7f6342301550c57b238044c20e4a4
2019-09-17 15:24:24 -07:00
Ed Sanders
689d07b81d build: Update eslint-config-wikimedia to 0.13.0
Change-Id: I7df5840bc97f8bbcd8cfc875c2b48b3061ef2c9e
2019-07-05 13:32:26 -07:00
Fomafix
1dc40b1cb3 Installer: Use HTML/CSS instead of JavaScript to toggle the help message
Changes in the behavior:
* The expanding/collapsing now works even with disabled JavaScript.
* There is no FOUC on loading anymore.
* The animation on show/hide is absent.

Change-Id: I1b88d8e2cdbb1c969670a7a8637dba10bf447330
2019-06-15 12:29:07 +02:00
Fomafix
0f346d6822 Installer: Move style of background image from HTML to CSS
Change-Id: I5fb8a9fc87290c407be123238397accbc5a886dc
2019-06-14 10:46:40 +02:00
James D. Forrester
ae3f5f12ff linting: Start enforcing a basic CSS class naming rule (with lots of opt-outs)
Wow, so many opt-outs, and a lot of probably-not-going-to-change ones.

Actually wanted pattern:
* "^mw-…"

Content-related classes we're probably not going to scrap:
* "^wikitable$"

Hard-to-change classes used in lots of skins:
* "^toc$"
* "^toctoggle$"
* "^tochidden$"

Necessary for over-rides/specificity battles:
* "^oo-ui-…"

Probably worth considering changing soon:
* "^client-js$"
* "^client-nojs$"

Some of the exemptions have been applied to deprecated styles (where they're being
renamed); some are for code in entirely deprecated areas themselves; some have the
"wrong" name but sit alongside classes with an appropriate one. And some are, very
clearly, in the wrong repo. Such sigh.

Change-Id: I9b8423d53b6750b5ca79d2f69e111f75c93c5bdc
2019-04-12 10:18:45 -07:00
Thiemo Kreuz
a2c1d8c043 Use the WebRequest::getCheck() shortcut where possible
This is inspired by Ib117e05.

As far as I can tell this is functionally identical. Even arrays should
behave the same, as both the getVal() and getCheck() methods do have a
special case that returns the `null` default in case the user tried to
pass multiple values instead of a single scalar.

Change-Id: Id4e4ec91f39d3c39461bd41673bdafc3bde11737
2019-03-11 09:50:52 +01:00
Derick Alangi
770ee82374 installer: Code augmentation in wfInstallerMain function
Cleanup null checks and string literals in wfInstallerMain function.

Change-Id: Ib117e05faf899b0c46820d337f1bd3ebd4272419
2019-03-09 17:43:02 +01:00
Derick Alangi
41822a6b9e installer: Get WebRequest in mw-config via RequestContext
Change-Id: I535a91d09cc74ab08b782973a946dcf3fc3e6b46
2019-03-09 15:42:45 +00:00
Ed Sanders
9097f95ecc build: Update eslint-config-wikimedia to 0.11.0
Change-Id: Iee025a518962e68c5ec2c07d952f402cd2a7f69b
2019-02-20 23:36:03 +00:00
Ed Sanders
b3e490bba6 build: Update eslint-config-wikimedia to 0.10.0
Change-Id: I2930bcabeeb7b7b2eb36063e77b26e664a691b43
2019-01-08 17:40:11 +00:00
Volker E
d939ca58a4 build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass
Change-Id: I648375927bace5fc21bd842268c645570759ce85
2018-11-28 16:30:32 -08:00
Volker E
14f60cb34c Add generic font-family fallback
Change-Id: I65fb9eff81729f7d320d0fa73f88e6c8c5571100
2018-11-16 20:36:05 -08:00
Timo Tijhof
e6763161e7 PHPVersionCheck: Remove obsolete load.php code and simplify
* Remove obsolete handling for 'load.php', which no longer
  uses this check. This hasn't been used for several releases.

* Remove the 'entryPoint' parameter in favour of 'format',
  which it was already a proxy for.

* Move the double dirname() logic to mw-config/index.php.

Bug: T189966
Change-Id: I343216442475d36e61213900f196ab6ec5f6b747
2018-10-28 14:12:54 -07:00
Timo Tijhof
add9bd191f resources: Strip '$' and 'mw' from file closures
Follows-up Id6d13bbea6:
- '$': mw.loader.implement does this already.
- 'mw': Use the canonical name directly.

This replaces the following patterns:

File closures (common):
- `( function ( $, mw ) {`     => `( function () {`
- `( function ( $ ) {`         => `( function () {`
- `( function ( mw ) {`        => `( function () {`
- `( function ( mw, $ ) {`     => `( function () {`

File closures (rare):
- `( function ( mw, $, OO ) {`    => `( function () {`
- `( function ( mw, OO, $ ) {`    => `( function () {`
- `( function ( mw, document ) {` => `( function () {`

Combined dom-ready and file closure (rare):
- `jQuery( function ( $ ) {` => `$( function () {
- `jQuery( function () {` => `$( function () {

Remaining references in files without a closure, as found by
the new ESLint setting (rare):
- `jQuery`    => `$`
- `mediaWiki` => `mw`

Change-Id: I7cf2426cde597259e8c6f3f6f615a1a81a0ca82b
2018-09-14 00:59:27 +01:00
Fomafix
31a472655b installer: Do not wrongly hide namespace input field
When the radio button is already on "other" then the input field for
the namespace should not get hidden by JavaScript on load.

Also remove the readonly attribute in HTML because the readonly
attribute can not get removed with disabled JavaScript.

Change-Id: I8cfde90d791765234572caf00b731881ac2eda48
2018-05-08 02:39:52 +00:00
Timo Tijhof
fd8a4c707a installer: Clean up ext-dependency jQuery code
Follows-up c8833d8e8e.

* Select the input elements by class to avoid accidentally trigging
  on unrelated elements elsewhere on the page in the future, given
  the generic selector.

* Use on('change') instead of deprecated change() alias.

* Set properties directly instead of via prop() indirection.
* Get attribute directly instead of via data() indirection.

Change-Id: I5158aa26b5fd7327d6795f0a31bbffbe99043fbf
2018-04-18 03:14:30 +01:00
jenkins-bot
cb20bab28c Merge "Handle extension dependencies in the installer" 2018-04-17 15:18:39 +00:00