MWCryptRand already has some useful utility functions wrapping PHP's
hash() and hash_hmac(). Let's make them public so we can use them from
other code.
But since "MWCryptRand" isn't really a good place for hashing functions,
let's move them to "MWCryptHash" instead.
Change-Id: I7542c719ac72beba7b0f6aa170bdb4c69fa6beab
These test runs don't seem very valuable and take up a lot of
slots that could be used for other wikimedia/* repos.
Change-Id: I47ff3a31883d02ec6b535e411d92ada92a84aa2f
This adds optional flags to Revision::getRecentChange
And uses them in CategoryMembershipChange
Bug: T109700
Change-Id: I197ebccf1f62cdcb03ce4daa2527b973e495236c
When minifying JavaScript, never put each statement on a separate line, and
always set a target maximum line length of 1000. These behaviors were
previously configurable via $wgResourceLoaderMinifierStatementsOnOwnLine and
$wgResourceLoaderMinifierMaxLineLength, respectively.
Change-Id: I0b0eb632875b5e16f728fd0aa62f7f5ecd79ef62
As Timo noted in a review of I1ff6115, using '+=' to combine file dependencies
is incorrect here. I fixed it in one place but not the other, causing the file
dependencies to vary based on whether a .lesscache file was used.
Change-Id: Ie3f48048febc32c5c2d45acd87e10f946f6dfc94
Any error apart from 503's can't be recovered just by hitting 'Try
Again'. The user will _have_ to make some changes before the process
can continue.
Bug: T114130
Change-Id: I8e2d619be5b7e47bc903155c353bc1da36a62bb6
We were checking for uploadToStash errors in saveFile, instead of in
uploadFile itself. Apart from being just wrong it was causing two
issues:
1. We would show an upload error until after you've tried to save the
file.
2. If there was an error in saving, and you try again, the first thing
it would do is check mw.Upload.State to hopefully check for
uploadToStash errors. Instead of running the finishStashUpload again
it would fail because of the earlier error, thus making all errors
unrecoverable.
Bug: T114130
Change-Id: I56f4ef6e6536840a63402688eb2a1875a6876fcc
Follows-up 77cdf19 which accidentally removed it.
It is used to host the mw.page.watch method.
Bug: T114288
Change-Id: I1aad9c3c46c3765b6b241cf3fd7b2f1956b8cfa0
Retuning another Promise from a .done() callback does nothing, it's
only meaningful for .then(). Looking at other code, the .done() rather
than .then() was intended, the 'return' wasn't.
Change-Id: I1022ba45b8f422a626246fa38c4fe81428acb3bc
Per post-merge feedback on 795922d59c,
the changes to message contents are not substantial enough to
invalidate all existing translations.
Change-Id: Ifbbfd27c8ca6a4abe71e91e6fb7d61155a7be955
