Commit graph

103616 commits

Author SHA1 Message Date
jdlrobson
7cda5b0bf8 Make mw-content-body universal to all skins
1) Rename content-parser-output to `content-body`

Widen the scope of this module to apply to anything that can be rendered
as the article body. Improve the documentation on what is allowed here.

For early-adopter skins already using content-parser-output,
map the feature to the new name and add tests.

2) Reclaim the `mw-body-content` class for result of
SkinTemplate::wrapHTML

The `mw-body-content` has been used in skins to wrap various elements.
Going forward we will use it to wrap any HTML content generated by
OutputPage.

See dependent patches, which we're not directly depending on to avoid
a CI gremlin:

 - I90d85c21f4a62e6697f24e3ce388445a0a53c2b0 (MonoBook)
 - I11242e243c9a529b72972089af9ac2a8c906331a (Modern)
 - I87942c60e62f6f14acdfeaa1836ace4eac9252ac (CologneBlue)
 - I4c1b15d90bacbc9b13782a1d8f52e838ce8ecd83 (Vector)

Bug: T279388
Change-Id: I3a91b294fcb3724cd46743e497dff723de0490a6
2021-05-13 16:53:52 -07:00
jenkins-bot
4590d6bdd1 Merge "Drop global function wfAppendToArrayIfNotDefault, deprecated in 1.36" 2021-05-10 22:19:56 +00:00
jenkins-bot
b9b94021cb Merge "manageForeignResources: Use Maintenance::fatalError, not exceptions" 2021-05-10 22:12:32 +00:00
ZabeMath
e6640038ee Drop global function wfAppendToArrayIfNotDefault, deprecated in 1.36
No uses known in code search.

Bug: T264975
Change-Id: I5e739d8de4a4739c0d7014439f3d49ee67addc16
2021-05-10 14:55:31 -07:00
Ammarpad
be4e48e93f manageForeignResources: Use Maintenance::fatalError, not exceptions
Change-Id: Ic6a4e42793d5f2d3e874e155ccbad1467e25698f
2021-05-10 21:48:29 +00:00
jenkins-bot
2ee2ec0e52 Merge "Convert File to Authority/UserIdentity" 2021-05-10 19:54:31 +00:00
jenkins-bot
3f55d6d7dc Merge "PageArchive: prepare for converting to DI" 2021-05-10 19:54:25 +00:00
jenkins-bot
e8feb44f04 Merge "Add assertions about page IDs during undeletion." 2021-05-10 19:53:52 +00:00
daniel
b019b9ee24 Add assertions about page IDs during undeletion.
The additional assertions should help with identifying the cause
of T271644

Bug: T271644
Change-Id: Ic75069545f45ebc2eb09909f68581bc8429a929c
2021-05-10 15:14:53 -04:00
DannyS712
7855f60aa3 SqlBlobStoreTest: test against tt:10000 instead of tt:1000
The removal of the Revision class led to this test failing, since
tt:1000 started to have content - not sure why but I assume something
in the Revision tests was clearing the store - the text
was "UTContent" which is used in many tests via helper
method MediaWikiIntegrationTestCase::getExistingTestPage()
which can create pages with that text.

Change-Id: I04c669ad8c8a7166138eabc973140205b60536a5
2021-05-10 19:00:29 +00:00
jenkins-bot
b2480a7efe Merge "Add a JobQueueGroupFactory service" 2021-05-10 18:59:51 +00:00
jenkins-bot
dcfcd708de Merge "GetAllBlockActionsHook: Document avoiding blockable action ID conflicts" 2021-05-10 18:39:50 +00:00
Petr Pchelko
7b882b2e51 Convert File to Authority/UserIdentity
None of the changed methods actually are overridden
according to codesearch, so I guess it is ok
to change signatures.

Change-Id: I35bafb303163dfc1584a13b29675b5e10cd055fd
2021-05-10 10:57:06 -07:00
jenkins-bot
e56ca63098 Merge "IntegrationTestCase: Fix incomplete error message" 2021-05-10 17:53:23 +00:00
jenkins-bot
bb0c0d446f Merge "Remove hard deprecated methods from ApiBase" 2021-05-10 17:47:45 +00:00
jenkins-bot
9d3c293058 Merge "MediaSearch: Remove obsolete vendor prefixes" 2021-05-10 17:47:39 +00:00
Thalia
d85a4124e2 GetAllBlockActionsHook: Document avoiding blockable action ID conflicts
Change-Id: I2975d646f44a5dc1443d22a685565f14fdee614d
2021-05-10 18:35:58 +01:00
jenkins-bot
4d284420e4 Merge "ApiBase: deduplicate logic to avoid infinite loops for ApiMain methods" 2021-05-10 17:25:37 +00:00
jenkins-bot
334dfff732 Merge "User: Hard-deprecate the confusingly-named isLoggedIn() method" 2021-05-10 16:52:21 +00:00
jenkins-bot
2ff99a440a Merge "User::getID: Be lazier when fetching UserNameUtils" 2021-05-10 16:52:13 +00:00
Ammarpad
d90bff177f IntegrationTestCase: Fix incomplete error message
Change-Id: Id5bee445b67cf5339b0e3d7bb4376fb114312a06
2021-05-10 15:34:55 +01:00
James D. Forrester
6bbad15444 User: Hard-deprecate the confusingly-named isLoggedIn() method
This was soft-deprecated in 0171846c, since when all uses in Wikimedia
production code have been removed. As this is such a vital and widely-
used method, we'll want to deprecate it for at least two releases. and
so we should get this in at a time when we're willing to fix many such
uses. Why not now?

Bug: T270450
Change-Id: I8ac4a91d77c2bb748183b69b3e901cce93cbc940
2021-05-10 07:30:23 -07:00
jenkins-bot
a19532464d Merge "PageIdentityValue: apply basic validation of titles" 2021-05-10 14:11:39 +00:00
jenkins-bot
7d2920c842 Merge "LogPager: replace Title in method signatures" 2021-05-10 13:54:46 +00:00
jenkins-bot
fafcddb009 Merge "HTMLForm: accept PageReference instead of Title." 2021-05-10 13:49:31 +00:00
jenkins-bot
3d7868059d Merge "RevisionDeleter: Use PageIdentity instead of Title" 2021-05-10 13:41:25 +00:00
Gergő Tisza
2e7856a67c User::getID: Be lazier when fetching UserNameUtils
Given that User::getID is a very common method, used very early
during setup (e.g. during session initialization), only load
its dependency when it's really needed.

Bug: T282320
Change-Id: I6565426e9bf7084b1a33d39b2882639a03210460
2021-05-10 15:26:24 +02:00
jenkins-bot
b6fea99341 Merge "DatabaseBlockStore: fetch correct ActorNormalization" 2021-05-10 09:13:12 +00:00
jenkins-bot
7abcde069b Merge "Run tests with ONLY_FULL_GROUP_BY" 2021-05-10 08:12:57 +00:00
Translation updater bot
79bd45e8c7 Localisation updates from https://translatewiki.net.
Change-Id: I10cd64bcebfc0885a2071fbbbe7ab1383f82c1a4
2021-05-10 08:49:07 +02:00
jenkins-bot
e4c260496a Merge "RequestContext: add @param documentation to setAuthority()" 2021-05-10 05:59:54 +00:00
jenkins-bot
9c3aa308a7 Merge "Update OOjs from v5.0.0 to v6.0.0" 2021-05-10 00:30:42 +00:00
Universal Omega
bed2c33c7b RequestContext: add @param documentation to setAuthority()
Change-Id: I78caeb1d76aebcf3e8c6ba48128078a0bbec520c
2021-05-09 23:18:48 +00:00
jenkins-bot
d55e11258e Merge "Simplify database handling in CategoryTest" 2021-05-09 18:45:46 +00:00
DannyS712
2192f54a23 Remove hard deprecated methods from ApiBase
* ::explodeMultiValue
* ::parseMultiValue
* ::validateLimit
* ::validateTimestamp

Change-Id: I326abedc01d7096e67e193c7967b107e253b8916
2021-05-09 02:00:42 +00:00
DannyS712
96b99076e6 ApiBase: deduplicate logic to avoid infinite loops for ApiMain methods
Add private helper ApiBase::dieIfMain()

Change-Id: I3d9881356bd66447e67ccccf20697f4b88885854
2021-05-09 01:45:40 +00:00
DannyS712
d2a0b3976c Simplify database handling in CategoryTest
Use addDBData() and tables used

Change-Id: Ib9c9e9dcd2ddfad4ab9d4780c44fbc94a7a85d77
2021-05-09 00:53:31 +00:00
James D. Forrester
d13b4678a6 DatabaseBlock: Hard-deprecate calls to isWhitelistedFromAutoblocks()
Bug: T277987
Change-Id: Ic14f38e0e60bd156d1ff04392e65eeceb3ba77b2
2021-05-08 11:40:56 -07:00
James D. Forrester
f121d0fbde DatabaseBlock::isExemptedFromAutoblocks: Drop fallback message load
This is no longer needed in Wikimedia production. Third
party users will have had a release to adjust to one of
the three called-out migration issues. It's time.

Bug: T277987
Change-Id: Ia4a797afc71441ed9a7a90ff4f1e72cc4495cf63
2021-05-08 11:39:28 -07:00
jenkins-bot
c1d1d65d6c Merge "resourceloader: Fix path-only URLs in wiki modules when script path is docroot" 2021-05-08 17:21:07 +00:00
jenkins-bot
397752a0d2 Merge "Update wikimedia/minify to 2.2.2" 2021-05-08 17:18:58 +00:00
jenkins-bot
234103c2e7 Merge "Rename page_timestamp revision index" 2021-05-08 08:27:51 +00:00
jenkins-bot
fc9c300567 Merge "Do not call SpecialPage::addHelpLink in constructor" 2021-05-08 07:49:04 +00:00
jenkins-bot
32d1ce99a7 Merge "registration: Allow multi-line strings in "@" note keys" 2021-05-08 05:13:42 +00:00
Timo Tijhof
321f85580b resourceloader: Fix path-only URLs in wiki modules when script path is docroot
When a wiki is installed with its script path as the document root,
then WikiModule would pass MediaWiki's wgScriptPath value (empty string)
to CSSMin as base url, which is invalid.

A similar bug was recently fixed in FileModule with I16abf482e3a1a.

Bug: T282280
Change-Id: I0b9a67aa912eb3a0320631027303cedf3f348bb8
2021-05-08 00:27:50 +01:00
Timo Tijhof
7fef1bea61 Update wikimedia/minify to 2.2.2
Bug: T282280
Depends-On: I1d2f958a7a3c594e020bb19c5284b3dbe69d7ebd
Change-Id: I759c47f87e47c27bba479b4e4f10e53d2c722e8c
2021-05-08 00:27:50 +01:00
daniel
39a6e11310 HTMLForm: accept PageReference instead of Title.
Note that this changes the effective type of the protected mCancelTarget
field. This fields has no declared type, and does not seem to be used in
any subclass. The type of mTitle is not changed at this time, but
nothing seems to rely on that either.

Bug: T278459
Change-Id: I4bf0d46c74b53ffc9cb3e6e497c789ef6b3bab6a
2021-05-07 23:36:49 +02:00
jenkins-bot
41d7fa917f Merge "Split TimeCorrection parser into separate class" 2021-05-07 18:43:08 +00:00
Derk-Jan Hartman
65c955746c Split TimeCorrection parser into separate class
The parsing of the timecorrection useroption was split over multiple
classes. Combine into a single class and add some testcases.

Change-Id: I2cadac00e46dff2bc7d81ac2f294ea2ae4e72f47
2021-05-07 10:43:09 -07:00
jenkins-bot
b6744c24fb Merge "ForkController: Throw more meaningful error for missing PHP extensions" 2021-05-07 16:54:46 +00:00