Commit graph

1578 commits

Author SHA1 Message Date
Sam Reed
84fed26fd4 Add missing credits from r75975
Remove a few unused array keys in API foreach loops

Remove part of Html::Hidden comment
2010-11-06 15:10:18 +00:00
Sam Reed
9826f4a7df Followup r75999, use the correct variable. Zak confused me with having one thing in the bug title, and another in the bug content! :P 2010-11-05 22:24:07 +00:00
Roan Kattouw
79b4e0fdd8 Revert r76077, r76079, they were an overreaction to a security bug that wasn't really a security issue at all. The API will currently echo your session cookie back at you, but an attacker can only read that output using same-domain AJAX, and if they can do that they can do worse things (and steal the user's session in easier ways). 2010-11-05 11:54:35 +00:00
Roan Kattouw
def196d137 (bug 25793) Don't output the session ID over HTTP, allows session hijacking because logins that failed because no token was specified would output the session ID 2010-11-05 11:42:41 +00:00
Sam Reed
1d0acc5fb4 Fixup r75999, add missing ./PhpStorm-98.240/bin/webide.sh Wheee r76000 2010-11-04 13:20:58 +00:00
Sam Reed
bfd1fd770a * (bug 25760) counter property still reported by the API when wgDisableCounters enabled. If it's enabled, don't request counter information, and just display , to avoid breaking any backwards compatability 2010-11-04 13:10:38 +00:00
Sam Reed
68e1a821f4 Capitalise first letters 2010-11-04 13:07:57 +00:00
Sam Reed
36dd87f3b6 Followup r28029, we should probably at least pay attention to the parameter... 2010-11-04 00:55:30 +00:00
Sam Reed
a7b545fb40 Tab out for alignment, and normalise capitalisation of first letters 2010-11-03 17:01:21 +00:00
Sam Reed
bc25b2b427 Tab out siprop, so they are a bit more aligned 2010-11-03 13:00:24 +00:00
Chad Horohoe
65871ee245 Cleanup r65183, fix ugly stylize.php formatting 2010-11-03 12:49:21 +00:00
Neil Kandalgaonkar
902995cb1d core changes for UploadWizard (merged from r73549 to HEAD in branches/uploadwizard/phase3) 2010-11-03 04:32:41 +00:00
OverlordQ
f2df835d56 Revert r69337 (Removal of minordefault preference) 2010-11-01 18:58:24 +00:00
Sam Reed
ce9bd7697e * (bug 25741) Add more data to list=search's srprop. Patch by Brad Jorsch 2010-11-01 18:14:45 +00:00
Sam Reed
563eb117f5 Followup r75641, improve function documentation 2010-11-01 11:57:23 +00:00
Derk-Jan Hartman
dcd547218f Use isset to protect against Undefined index PHP notice. 2010-10-31 22:10:44 +00:00
Bryan Tong Minh
d9b9b14d57 r75621 copy-paste fail 2010-10-29 20:33:27 +00:00
Sam Reed
2b81e29ac5 Followup r75554, functionise Export code, allows for return to be used "non scarily"
Remove some extra blank comment lines
2010-10-29 12:20:11 +00:00
Sam Reed
d39cd01149 Minor followup to r75621, add whitespace
Add getVersion to ApiFormatXmlRsd
2010-10-28 22:56:43 +00:00
Bryan Tong Minh
e9fd126b9a (bug 25648) API discovery information has been added as RSD link in page <head> and by providing an API module action=rsd. Added hook ApiRsdServiceApis for extensions to add their own service to the services list.
Patch by Brion Vibber and Bryan Tong Minh.
2010-10-28 19:20:21 +00:00
Sam Reed
fcb749bd0c Function return type hints
Explicit class variable definition
2010-10-28 00:04:48 +00:00
Sam Reed
f1335b34bf * (bug 25463) Export header should not be shown if no pages were requested, to reduce confusion
Patch by Umherirrender, with a tweak to inverse logic to reduce nesting
2010-10-27 15:42:32 +00:00
Roan Kattouw
6fff1a0529 Followup to r75266: remove warning "rvlimit may not be less than 1 (set to )" when rvparse is set but rvlimit is not set 2010-10-27 11:50:20 +00:00
Bryan Tong Minh
9af2264645 Follow-up r75282
* Use addWhere instead of addWhereFld
* Don't add properties twice if there is a continue
* Add comments
2010-10-26 19:31:47 +00:00
Sam Reed
d194b9a179 Followup r75282, remove now unused class variables 2010-10-26 16:37:15 +00:00
Sam Reed
a14da45336 * If a action=parse request provides an oldid that is actually the current revision id, try the parser cache, and save it to it if necessary 2010-10-24 19:16:46 +00:00
Bryan Tong Minh
3f603335f3 Remove unnecessary @error surpressing operator. $pageSet is always defined and getGoodTitles() always returns an array 2010-10-24 14:56:13 +00:00
Bryan Tong Minh
fae7025644 Follow-up r70638:
* Use a single query to get the page_props instead of one per page
* Removed the $wgPageProps global
* Removed a lot of useless crap
2010-10-23 18:53:39 +00:00
Roan Kattouw
d1c9916e9c Revert r70703 and followup r70715: broke &redirect for API edit with a fatal error 2010-10-23 17:48:08 +00:00
Roan Kattouw
cb8dad9da4 BREAKING CHANGE: Per r70640 CR, salt patrol tokens with rcid in the API too. This means patrol tokens are now different for every recentchanges entry. 2010-10-23 17:22:38 +00:00
Bryan Tong Minh
e9d2674e11 Added rvparse to parse revisions. For performance reasons if this option is used, rvlimit is enforced to 1. 2010-10-23 16:41:20 +00:00
Bryan Tong Minh
7f71612ac8 Added iiprop=parsedcomment to prop=imageinfo, similar to prop=revisions 2010-10-23 15:40:55 +00:00
Sam Reed
661d26c9a3 Followup r75096 per Platonides, name the stuff better, rather than just fixing the typo.. 2010-10-20 23:36:21 +00:00
Sam Reed
2a103ae8d7 Few more explicit class variable declarations 2010-10-20 20:16:46 +00:00
Sam Reed
8b03a013a1 Fix some method documentation
Fix some typos

Some explicit class members
2010-10-20 18:50:33 +00:00
Sam Reed
056b646308 Followup r74988, brion wins again ;D 2010-10-19 18:40:43 +00:00
Sam Reed
c85bf31cf3 Swap usage of create_function for defined function as a callback 2010-10-19 00:44:28 +00:00
Roan Kattouw
9c0b26028f Revert r74810 (vary API help cache on $wgUser->isAnon()) and move the POST check into the purge module. Also fix the permissions check in action=purge, which was totally broken and based on a misunderstanding of what the 'purge' right means. 2010-10-18 09:19:20 +00:00
Sam Reed
9e549e437a Followup r74392. Also cache result of getUser call (may be called twice) 2010-10-17 18:54:39 +00:00
Roan Kattouw
3adc35f790 Fix r72905: don't run $endTime through wfTimestamp() twice 2010-10-16 16:53:10 +00:00
Sam Reed
14b6fbb3be * (bug 24792) API help caching doesn't vary on $wgUser->isAnon(), causes staleness 2010-10-15 17:13:38 +00:00
Sam Reed
a2589ff8c6 Assignment in loop conditions suck
while ( $row = $dbw->fetchObject( $res ) ) { to foreach ( $res as $row ) in includes

Add some braces
2010-10-13 23:11:40 +00:00
Sam Reed
c1f84d0cef Not sure why watch was marked as deprecated, but unwatch wasn't... Marking unwatch deprecated 2010-10-09 13:59:15 +00:00
Sam Reed
4a0c3d8ff5 Comment return types, some explicit class variable declaration 2010-10-09 00:01:45 +00:00
Sam Reed
550271e806 Explicit class variable definition
Parameter hints
2010-10-06 21:18:55 +00:00
Sam Reed
56f6d2975f Followup r71831, User::newFromName, not newFromText 2010-10-06 21:16:28 +00:00
Sam Reed
519173c0e4 Followup r74234 flip parameters 2010-10-04 21:18:38 +00:00
Roan Kattouw
adf4822d18 Per r74201 CR, make it clear that the list of languages supporting variant conversion may not be complete 2010-10-04 09:11:15 +00:00
Sam Reed
3629f272c4 Object return type hints 2010-10-03 22:13:04 +00:00
Sam Reed
9cda0105a9 Minor tweaks to r74232, add a value for $botMax on calls for integer validation (otherwise the bool gets pushed into it!)
Documentation in ApiDelete
2010-10-03 20:29:44 +00:00