The examples and comments were misleading with regard to the handling
of missing entities.
Bug: T303092
Change-Id: Ib672fd18d1270c35253683eb54b48be056e6dc3c
LinksUpdate is a group of deferrable updates, not jobs till now.
See HtmlCacheUpdater::purgeTitleUrls().
Bug: T165099
Change-Id: Icf40c4ff9e14ee06d48600bcbfdc39e2baf68b23
SuiteEventsTrait is a hack to support the parser test suite classes. If
the suite is empty due to e.g. group filters, doing setUp() and
tearDown() is unnecessary and expensive (requiring DB cloning). Also,
errors from setUp() or tearDown() on an empty suite were not properly
handled.
So if the suite is empty, do the same thing as TestSuite::run(), leave
the result unmodified.
Bug: T292239
Change-Id: I0828257d6dd0bbc5b1633afde5ff162e96169675
Use the LoadBalancer id in flushPrimarySessions(), not the LBFactory one,
and use assertOwnership() to check $owner, similar to other methods.
In DatabaseMysqlBase::doFlushSession(), change RELEASE_ALL_LOCKS() query
to use RELEASE_LOCK(), since only newer MariaDB versions (>=10.5.2) support
it. No errors were thrown in the method since they are suppressed, but the
syntax error would cause the transaction to be placed in an error state.
Add assertion to testTransactionCallbackChains() that would otherwise fail.
Randomize lock names in lock() tests to avoid contention.
Bug: T292239
Bug: T303887
Follow-Up: ee3c65d541
Follow-Up: 4cac31de4e
Change-Id: I414d737028338cfd5369eee24576df4aa26a2f6f
In T222953 we want "Move subpages" to be checked by default, but if the user
un-checks it, and then is prompted with a warning, like the page already
existing, we don't want to re-check it.
Test plan:
* Create pages Talk:A, Talk:A/1, Talk:B
* Open the form to move Talk:A
* Verify that "Move subpages" is checked by default
* Try to move it to Talk:B, which already exists
* Verify that you get a warning, and in the new form "Move subpages" is still
checked.
* Re-open the move form for Talk:A, un-check "Move subpages" and try to move
it to Talk:B.
* Verify that you get a warning but "Move pages" is still un-checked.
Bug: T304008
Change-Id: I4b6e64117c561173e9ff1bacd5741a5b20bc61f6
Group names can contains spaces in phpunit
Bug: T292239
Follow-Up: I7061f5e630858443e9127c3267069ae6bba192e2
Change-Id: I3b2e5a630e40bc55368784885ae221b0f925711b
This ensures that assertions work in a uniform way,
and provides meaningful messages in cause of failure.
Change-Id: Ic01715b9a55444d3df6b5d4097e78cb8ac082b3e
trySubmit() should happen before displayForm(), and loadData() should
be replaced with prepareForm(), so use convenience method show() which
handle all of them correctly.
Bug: T256805
Change-Id: Ia3cf0ac134c65ce6aa9001fb316b0eb2dc62fdce
UserNameUtils returns string|false. Check explicit for false to take the
string '0' as valid, which was a falsy check before.
Change-Id: I04c6b5303f9c2356ca85855686694b48f6448d56
The policy allows this and since 1.39 is going to be the next LTS
release, I think it is fine to do this now.
Change-Id: If426e0ee349252ccc0ba9c4222c7d6865ab57fa2
