Parser::makeImage always sets targetlang based on the page language. In
order for Parsoid to support that in standalone mode, we set it based on
the overloaded badfilecontexttitle, which is the only context we have
when making imageinfo requests.
Follow up to I348840ef405e1370cc0c17d69051bce30153c9c0
Bug: T208620
Change-Id: Id01b84907c6817194c53dbb9d731e5383e7a0056
Previously attempted in 07b4daf85d,
reverted in 8763d8e911.
Message parsing used to be the biggest part of loads during
DefaultPreferencesFactory::loadPreferenceValues(), since it need to
load form fields to validate existing user preferences.
Message names in form descriptor can be unset as much as possible,
but special cases should be carefully handled.
The attempt of loading value for info fields is skipped to avoid
issues described in T302643.
Bug: T58633
Bug: T302643
Change-Id: I05dcfd60d4103b447dea71851b8e4db9a5d0e1e6
This allows Parsoid to properly merge jsconfigvars via the external API
(ie, when Parsoid is run in 'standalone mode') when an extension uses
the new-in-1.38 ParserOutput::appendJsConfigVar() method.
Change-Id: I974d9ecfb4ca8b22361d25c4c70fc5e55c39d5ed
In a similar vein to I46033d5ddda055c275dbda71d5c38c4a7a858c9d
The documentation to WikiPage::doUpdateRestrictions is changed to remove
`|string|null`. ManualLogEntry::addTags can handle a string but it's
unexpected in the RevisionFromEditComplete hook. From codesearch,
ApiProtect is the only caller passing in $tags, and that's coming from
a PARAM_ISMULTI, which presumably can only be an array or null.
Bug: T302918
Change-Id: Icd8a7391f7a8c21b0cdb1f734e65ee5661c1075f
Application logic should use the BaseDirectory config variable.
Framework code should use MW_INSTALL_PATH to locate files should.
NOTE: Update https://www.mediawiki.org/wiki/Manual:$IP
Bug: T300301
Depends-On: I7142af16d692f26e90673b058029f572c1ea3991
Change-Id: Ib4caa80bb7007c4c7960a2fd370cf5da7d9ba344
If no tags are specified, null shouldn't be passed as it may
cause problems down the stack
Bug: T302918
Change-Id: I46033d5ddda055c275dbda71d5c38c4a7a858c9d
This reverts commit 07b4daf85d.
Due to the new method being used in both the API, and in the
loadPreferenceValues method (which is used by the main pref UI), this
change is not easy to reason about and is much wider in impact than
I had thought. More research and understanding is needed.
Bug: T302643
Change-Id: Ic420bc16ac5de8ce90343926e9c73815f3ff7479
Message parsing used to be the biggest part of loads during
DefaultPreferencesFactory::loadPreferenceValues(), since it need to
load form fields to validate existing user preferences.
Message names in form descriptor can be unset as much as possible,
but special cases should be carefully handled.
Bug: T58633
Change-Id: I1b5c2331e6d5a63f296b4147a91aecb39abf3530
Use bool instead of string, most caller provided int instead.
The InterwikiLookupAdapter class is strict comparing Interwiki::isLocal
(a bool) with the given $local value, which evaluates always to false
and the expected filter option is not working.
The unit tests is using bool, not the documented string.
The ClassicInterwikiLookup is not affected.
Found by phan strict checks
Change-Id: I63ed9772429c6f5bfe38a9fad190491812866f3f
This works thanks to the new "deletetalk" parameter (the name is
consistent with "movetalk" to ApiMove). The API will return with a
warning if the page is already a talk page, or if the talk page
doesn't exist.
Note that the API response doesn't expose information about the talk
page deletion. This would likely be a breaking change to the module, and
is also not too easy to implement until FileDeleteForm is refactored as
well.
Bug: T263209
Change-Id: I30f2da190433a3ef9c0ac375f23b68acd3d6f190
* Use lower case without a full stop
* Use standard muted colour for secondary information. The
red warning colour is still used on the param page itself.
Change-Id: I734a2f31f9139b8415bd61dcbe0561232e2632ee
The parameter is using the UserDef validation,
which provides all this features
Also all params are guarded to be set in the $params array after
extractRequestParams(), no need to use isset on $params.
Make explicit that empty bkusers= or bkids= are ignored,
instead using the implicit check in addWhereFld.
Doing nothing when requesting nothing would be a breaking change.
Change-Id: I3602412874b1b3a954037d95ad7cefbe865e3893
In that case the variable $toTalk is null,
but that is not allow for the moveSubpages() function
Found by phan strict checks
Change-Id: Ib1f67247277f44dc8c9b08eb5a287c701f45f918
