Add `aria-label` attribute with explanatory description as value to the
`wpTextbox1` to allow screen reader read the purpose of the textbox for
visually impaired contributors.
Bug: T245863
Bug: T252355
Depends-On: I0628486e2201975464a77a55053a8d74ddfc57fb
Change-Id: Ib6fe49ade878757594fd28dac2bfd0ef8a7a5e8f
Luckily this was not really broken. The old and the new code do the
exact same. The old code was just side-stepping the documented way
this method should be used.
Change-Id: I3f25ba159df5dbfc67eb7ade3fe29a017e601162
A deprecation warning will be triggered if the constructor is called without providing a ContentHandlerFactory
Bug: T235165
Depends-On: I5996f0f01e28edf50d3caf2ca4557d64271d8545
Change-Id: Ie552b33a5644fa2aefd826df8fd18184434677b7
Added:
- ContentHandlerFactory
Tests:
- PHPUnit
Changed
- Calls of changed and deprecated
- DI for some service/api
Deprecated:
- ContentHandler::* then similar to ContentHandlerFactory
- ContentHandler::getForTitle
- ContentHandler::$handlers
Bug: T235165
Change-Id: I59246938c7ad7b3e70e46c9e698708ef9bc672c6
The method is not used anywhere:
https://codesearch.wmflabs.org/search/?q=toEditContent&i=1
There is another method with the same name in the EditPage class. But
this is unrelated. As far as I can see the method I'm touching in this
patch was copied from the EditPage class.
Change-Id: I51d167723bd70220adbf4ac36f15f3290b7eb653
This is only called at one place in core and used in the TwoColConf
extention. The passed argument is always an array.
Change-Id: I4ca94442b79dc8871ed72943be733d100e093e44
Factored out some minor parts about building editor CSS classes.
getEditConflictMainTextBox() mainly mirrors showTextbox1 parts not
included were moved to the EditPage.
Change-Id: I671e095acc08382dd0a1c3d167fdaaa623ec5499
This is similar to the tracking of the occourance of
edit conflicts but tracks the resolution of the conflicts.
Bug: T182011
Change-Id: I9a0c05dc921946fb6e0580b56b663783ca0b1b6e
Extensions with custom content models (e.g. ProofreadPage) will extend
EditPage to provide a customized editing experience. However when
another extension like TwoColConflict wants to change just how edit
conflicts look, this causes problems since only one class can take the
place of EditPage.
So instead, split most of the frontend code for edit conflicts into
TextConflictHelper, and call it from edit page. Extensions can override
with the instance created by calling
EditPage::setEditConflictHelperFactory().
And to make that split possible also move EditPage::addNewLineAtEnd()
and ::buildTextboxAttribs() into a separate TextboxBuilder class that
both EditPage and TextConflictHelper can use.
Bug: T176393
Change-Id: Ie415edd84329c02d5762477f8a171fced85b01a2
