* Use the "profiler" channel consistently within this component,
and set it in the constructor of the base classes.
* Fold legacy "profilererror" channel into "profiler".
Previously, the wfDebugLog wrapper was using the INFO severity,
which is the default given wfDebugLog does not support severity.
Change-Id: I1e7dcbc221b395a4ea792e18f4d4da36b5ee40df
* Remove redundant file description for files that only define
a class where the class description suffices.
* Ensure the file has a license header and @file.
* Remove any @ingroup from the file comment block.
These clutter the Doxygen pages with duplicate entries.
* Ensure the class block has an @ingroup set.
* Remove @since when @internal is set.
* Add any missing @since to public classes that were created
recently enough to easily find out when:
- ProfilerExcimer was introduced in 1.33 (6373e3d1d4).
Change-Id: I6b18289a15a3085857acd7c9004ec819f7914b29
Make it Profiler.php's responsibility to enforce this, based on the
existing signal from ProfilerOutput::logsToOutput().
The ProfilerOutputText class should not have to double-check this
a second time.
Long-term, I'd like even this check in Profiler::logDataPageOutputOnly
to be removed, because really the external caller of that should
know whether it is safe to output stuff or not rather than stashing
its own state inside Profiler::$allowOutput and then implicitly
reading it back out again later on. But, that's for another time.
Also:
* Remove use of deprecated Profiler::setTemplated while at it.
* Make 'visible' parameter explicit, as for other parameters.
Change-Id: Iaa3fc4ea25a059b90235d769db60c04b8f152f05
Having such comments is worse than not having them. They add zero
information. But you must read the text to understand there is
nothing you don't already know from the class and the method name.
This is similar to I994d11e. Even more trivial, because this here is
about comments that don't say anything but "constructor".
Change-Id: I474dcdb5997bea3aafd11c0760ee072dfaff124c
* Added a standard getFunctionStats() method for Profilers to return
per function data as maps. This is not toolbar specific like getRawData().
* Cleaned up the interface of SectionProfiler::getFunctionStats() a bit.
* Removed unused cpu_sq, real_sq fields from profiler UDP output.
* Moved getTime/getInitialTime to ProfilerStandard.
Co-Authored-By: Aaron Schulz <aschulz@wikimedia.org>
Change-Id: I266ed82031a434465f64896eb327f3872fdf1db1
