Commit graph

5 commits

Author SHA1 Message Date
Umherirrender
d30b3d8926 Fix various documentation related to scalar types
Found by phan strict checks

Change-Id: If41d16b473baddd92cc4261cdc2bfbe65fedcb19
2022-03-09 20:49:51 +00:00
Bartosz Dziewoński
65b23eb0fb ProtectionForm: Use XmlSelect::parseOptionsMessage where appropriate
Previously done in 02db290c64, looks
like it was accidentally undone in 1262ca1897.

Change-Id: I227ed9c6ba146fa249756f444f5c96ac2b5022b6
2021-05-25 18:44:51 +00:00
Umherirrender
e9e784a09e build: Enable phan-taint-check-plugin and suppress issues
Taint check checks for possible security issues by tracking html
escaping and more by using phan.
This slows done the phan-job a bit and requires more ram

Keep the DoubleEscaped issues out to make reviewer easier

Adds suppression for false positives
Adds taint-annotation to help taint-check
Removes suppression for code phan now understand better by the tracking
of keys in taint-check
Fix some small issues by adding int cast or htmlspecialchars calls

Bug: T216348
Bug: T268920
Change-Id: I849ac4f120fd15b483e8939d4db45c98dc351259
2020-12-30 19:02:22 +01:00
Sam Wilson
02db290c64 Unify handling of options messages
There are a few messages that use a custom format for select
lists. This moves the parsing of these messages into a single
method.

Bug: T245565
Change-Id: I0a24d3458979d7cca2dc3cb38c1b0f700a88490a
2020-03-27 11:19:43 +08:00
Aaron Schulz
97fa6ff265 Move Xml* classes under /xml
Change-Id: I012648c9a860611a7cd809119073803e82429fc3
2020-03-19 19:23:47 -07:00
Renamed from includes/XmlSelect.php (Browse further)