Commit graph

5 commits

Author SHA1 Message Date
Umherirrender
a7bb7cc5c5 Remove unreachable code after exception/die/exit
Change-Id: Ia81903fb2a8157625fbe63115097eccc1161b5db
2021-09-03 23:14:28 +00:00
James D. Forrester
df5eb22f83 Replace uses of DB_MASTER with DB_PRIMARY
Just an auto-replace from codesniffer for now.

Change-Id: I5240dc9ac5929d291b0ef1c743ea2bfd3f428266
2021-04-29 09:24:31 -07:00
Timo Tijhof
3c27d8df30 changetags: Change new canDeleteTag() boolean param to int flag
Follows-up 38a9f0a42a, which recently introduced a boolean
parameter here. Replace this with an integer constant so that
the intent is more explicit in the caller, and also makes the
implementation more future-proof.

Bug: T75181
Change-Id: I575ad8648ce3aa41cbe45cfa41e97d2acc29b402
2019-11-17 10:22:02 -05:00
Max Semenik
3aab62ce11 deleteTag.php: Fix batching
* For some reason, deletion didn't go beyond the first batch in
  beta. Simplifying the check, removing the reliance on affectedRows().
* If the last deletions were the same number as the batch size, the
  script went for the second loop, feeding an empty array of IDs to
  delete(), causing an exception.

Change-Id: Id793aeef0517041a0216110abd8b64ec85deff1e
2019-11-10 22:30:00 -08:00
Max Semenik
38a9f0a42a Add a maintenance script to delete a change tag
Based on Ib8b96b8460db3832e9297a07922ee1d9d1af5ccb by Legoktm.

Bug: T75181
Change-Id: I0e61dfbc72fe27efa9c1deabc928e7c9af66e1bc
2019-11-07 16:57:51 -08:00