The examples and comments were misleading with regard to the handling
of missing entities.
Bug: T303092
Change-Id: Ib672fd18d1270c35253683eb54b48be056e6dc3c
LinksUpdate is a group of deferrable updates, not jobs till now.
See HtmlCacheUpdater::purgeTitleUrls().
Bug: T165099
Change-Id: Icf40c4ff9e14ee06d48600bcbfdc39e2baf68b23
SuiteEventsTrait is a hack to support the parser test suite classes. If
the suite is empty due to e.g. group filters, doing setUp() and
tearDown() is unnecessary and expensive (requiring DB cloning). Also,
errors from setUp() or tearDown() on an empty suite were not properly
handled.
So if the suite is empty, do the same thing as TestSuite::run(), leave
the result unmodified.
Bug: T292239
Change-Id: I0828257d6dd0bbc5b1633afde5ff162e96169675
Use the LoadBalancer id in flushPrimarySessions(), not the LBFactory one,
and use assertOwnership() to check $owner, similar to other methods.
In DatabaseMysqlBase::doFlushSession(), change RELEASE_ALL_LOCKS() query
to use RELEASE_LOCK(), since only newer MariaDB versions (>=10.5.2) support
it. No errors were thrown in the method since they are suppressed, but the
syntax error would cause the transaction to be placed in an error state.
Add assertion to testTransactionCallbackChains() that would otherwise fail.
Randomize lock names in lock() tests to avoid contention.
Bug: T292239
Bug: T303887
Follow-Up: ee3c65d541
Follow-Up: 4cac31de4e
Change-Id: I414d737028338cfd5369eee24576df4aa26a2f6f
Group names can contains spaces in phpunit
Bug: T292239
Follow-Up: I7061f5e630858443e9127c3267069ae6bba192e2
Change-Id: I3b2e5a630e40bc55368784885ae221b0f925711b
This ensures that assertions work in a uniform way,
and provides meaningful messages in cause of failure.
Change-Id: Ic01715b9a55444d3df6b5d4097e78cb8ac082b3e
UserNameUtils returns string|false. Check explicit for false to take the
string '0' as valid, which was a falsy check before.
Change-Id: I04c6b5303f9c2356ca85855686694b48f6448d56
The policy allows this and since 1.39 is going to be the next LTS
release, I think it is fine to do this now.
Change-Id: If426e0ee349252ccc0ba9c4222c7d6865ab57fa2
- Add private var, helper methods to format and set robots options.
- Add reference to new method in OutputPage::getHeadLinksArray().
Bug: T301584
Change-Id: I2652f20c9fe5f2d3e28e329d4eddc2a2ff88cf76
This adds full integration tests for extension registration, ensuring
that ExtensionProcessor and ExtensionRegistry work together as expected.
The existing tests for ExtensionProcessor and ExtensionRegistry are
converted to "pure" unit tests.
This change is intended to protect against bugs while refactoring
ExtensionProcessor and ExtensionRegistry to better integrate with the
new SettingsBuilder class.
Bug: T297166
Change-Id: I2d9cc373b8a4aa014aef93b0a8e8d83758851783
This test cannot be reasonably fixed because of the way
String.prototype.lastIndexOf works; which is used under the hood for
the extension extraction and it has been disabled for a long time.
Change-Id: Ibc7f5e09cd12e72bb9558d8619e93146a95a455e
The testUpgrades() method is slow and is easier to
parallelize via paratest if it lies in a separate class/file
Also make the test use a data provider
Bug: T50217
Change-Id: I5c8df6ae0ff34941f4cf7275680b309e79565925
If we are creating a Mock title, the ID should be set to 0
for any Titles that are in "virtual" namespaces (e.g.
any with a namespace ID < 0, which is Special: or
Media:)
Change-Id: I6aae00ae8f68ad3a93d9edd1194e828735e2a878
