The property OutputPage::mBodytext does not always hold the full
HTML to be output only the body text which will be greatly altered
when Skin::outputPage is called.
I noticed this when a test that tries to check existence of a
'blocklink' in Special:Contributions subtitle consistently fails.
This happens because the links are only added when Skin::outputPage is
called but by calling OutputPage::getHTML() here and collecting the
buffer contents, the link is nowhere to be found since the skin method
will never be called if we didn't call OutputPage::output() (which -
will call the skin method)
Also OutputPage::output() already can return the fully generated html
via its optional parameter which we can just use here.
This patch adds optional parameter to specify that the caller wants the
entirety of the generated HTML. The default remains false, which
is to return OutputPage::getHTML().
Bug: T268322
Change-Id: I9b580e4ed93d989028d394803dba1ea7a9117592
The name change happened some time ago, and I think its
about time to start using the name name!
(Done with a find and replace)
My personal motivation for doing this is that I have started
trying out vscode as an IDE for mediawiki development, and
right now it doesn't appear to handle php aliases very well
or at all.
Change-Id: I412235d91ae26e4c1c6a62e0dbb7e7cf3c5ed4a6
This is copied from Wikibase. A follow up change adds a test
for Special:BlankPage to demonstrate how it works.
Change-Id: I3c34fd17ceb0049b160ec4f821474de457533983
