This ensures that assertions work in a uniform way,
and provides meaningful messages in cause of failure.
Change-Id: Ic01715b9a55444d3df6b5d4097e78cb8ac082b3e
Most of the code in WatchlistManager does not depend
on integration logic, with the exception of
- ::clearTitleUserNotifications adding a DeferredUpdate
- ::addWatch and ::removeWatch using
User::newFatalPermissionDeniedStatus, which uses
MediaWikiServices
Move the majority of the rest to the unit tests, except
for an integration test of the overall basic functionality
that we leave to make sure that the integration with the
actual services works properly.
Also take this opportunity to document why the integration
tests left behind need to be integration test, and fix
the name of some tests to addWach/removeWatch instead of
the old doWatch/doUnwatch.
Explicitely add 'watchlist' to the tables used by the
integration test.
Change-Id: I899ef1618c59c179ed2591149b93969fd935276d
- take PageIdentity in addition to LinkTarget where appropriate and
deprecate taking LinkTarget
- take Authority in addition to UserIdentity where appropriate and
deprecate taking UserIdentity
Change-Id: I410a4c26b25e086e1e6abb293789d718de4aa20a
