Commit graph

60574 commits

Author SHA1 Message Date
jenkins-bot
9d4029a25c Merge "Remove obvious function-level profiling" 2015-01-07 19:27:45 +00:00
Kunal Mehta
07707b85aa Cookie: Fix @throws comment
Change-Id: I3f63a58b74ab4dd46010c8a61da98c1cae419195
2015-01-07 19:17:43 +00:00
Chad Horohoe
aa21e125a3 Remove obvious function-level profiling
Xhprof generates this data now. Custom profiling of various
sub-function units are kept.

Calls to profiler represented about 3% of page execution
time on Special:BlankPage (1.5% in/out); after this change
it's down to about 0.98% of page execution time.

Change-Id: Id9a1dc9d8f80bbd52e42226b724a1e1213d07af7
2015-01-07 11:14:24 -08:00
Evan McIntire
e6c87b54a7 Marked replaceMultiple() as deprecated
MagicWord::replaceMultiple() is completely unused in both core and
all extensions on gerrit, so it is being marked as deprecated.

Change-Id: I6289a36351a2cbc47a0cad237cc985e5c3136773
2015-01-07 19:07:11 +00:00
gladoscc
f652b4b7a9 Add type hinting for WikiPage::onArticleEdit, etc
Type hinting will catch false & null as specified in the todo.

Change-Id: I64fade3a7aa5e15323dc63a13d84d969d0b942b3
2015-01-07 18:55:28 +00:00
jenkins-bot
5fde727a92 Merge "jquery-ui: Remove dark color from links inside dialogs" 2015-01-07 18:41:21 +00:00
Bartosz Dziewoński
5e772e39dd jquery-ui: Remove dark color from links inside dialogs
Bug: T85857
Change-Id: I29aafd41ce142b05c1bd9aafb096f38273ca747e
2015-01-07 19:31:05 +01:00
Kunal Mehta
7b127e9de2 CleanUpTest: Consolidate individual "@todo Document" comments into one
This avoids PHPUnit marking nearly every test as risky.

Change-Id: I7cb5fc3eca2e9496a61d223dcae7576e7ddb4cad
2015-01-07 10:22:48 -08:00
jenkins-bot
a28038d44f Merge "Update QUnit from v1.14.0 to v1.16.0" 2015-01-07 15:29:22 +00:00
Adrian Heine
edf91cda43 Update QUnit from v1.14.0 to v1.16.0
- Release notes
  https://github.com/jquery/qunit/blob/1.16.0/History.md

- Source of imported files
  https://code.jquery.com/qunit/qunit-1.16.0.js
  https://code.jquery.com/qunit/qunit-1.16.0.css

- Unit tests still pass.
  Tested on [[Special:JavaScriptTest/qunit]] with $wgEnableJavaScriptTest = true

Bug: T85994
Change-Id: Ic2d5e91d4f1e16a87618b18c3a83d31aaa0ab91c
2015-01-07 15:23:10 +00:00
jenkins-bot
cbf8852e19 Merge "Remove the 'top' definition from .mw-ui-icon-element:before" 2015-01-07 14:20:57 +00:00
Prateek Saxena
54f2cbd042 Remove the 'top' definition from .mw-ui-icon-element:before
This was making the icon stick to the top of the button it was
inside. We couldn't find an example of the issue that the earlier
patch was trying to fix (on #wikimedia-mobile).

Bug: T85778
Change-Id: Ifea204ee9b86b01f61f3c48372619dadce64da9b
Reverts: Iadd741f02155a9b5ddeb6cd8ff64fa13ae5506d7
2015-01-07 14:14:36 +00:00
jenkins-bot
3e97c56409 Merge "Escape unescaped messages in Special:Preferences" 2015-01-07 08:57:04 +00:00
Kunal Mehta
9134bcfbb8 Cleanup ParsoidVirtualRESTService
* Remove unused global
* Throw \Exception instead of \MWException since this is in includes/libs/

Change-Id: I2e51d7e25a755b79d14d1814951449f6ce14c68e
2015-01-06 18:11:25 -08:00
jenkins-bot
b5cf0db562 Merge "Make a VirtualRESTService class for Parsoid" 2015-01-07 01:29:44 +00:00
Alex Monk
24409664f1 Make a VirtualRESTService class for Parsoid
So that code to deal with Parsoid can be shared across different extensions.

Relies on I1d57ff24

Bug: T1218
Change-Id: Id658d925b722b885fd425c27f7c4fd2cd02ad0b4
2015-01-07 01:19:45 +00:00
gladoscc
e0f77ade75 Escape unescaped messages in Special:Preferences
Bug: T85864
Change-Id: Ie516549bce72a0052570ab38bde4c03e2bc1b69b
2015-01-07 12:12:25 +11:00
Aaron Schulz
fb009e4f34 Trigger onResponses on non-replacement request too in VirtualRESTServiceClient
Change-Id: I1e550812f3c021c2e2f4246345df2f9dd47d15b8
2015-01-06 21:54:20 +00:00
Translation updater bot
5669a04529 Localisation updates from https://translatewiki.net.
Change-Id: I8a6dcdacfbe59bd9b34c314c957ce05a15c0e7a5
2015-01-06 22:06:32 +01:00
Chad
03e2a132d2 Merge "Revert "Keep backend param to search API as long as there's a backend"" 2015-01-06 18:50:28 +00:00
Chad
a04e11786c Revert "Keep backend param to search API as long as there's a backend"
Actually on second thought, having the parameter disappear is 
a better option than keeping it around with only one possible 
value.

This reverts commit 7a79b017a0.

Change-Id: Ia67fa1425e0aa1ee95e0a1733f89d29f94f1eeee
2015-01-06 18:50:14 +00:00
jenkins-bot
919e08074f Merge "Remove double escaping of group member name on Special:ListUsers" 2015-01-06 17:45:29 +00:00
jenkins-bot
19d0011d9c Merge "grunt: Add Karma task for automated QUnit testing in browsers" 2015-01-06 16:36:12 +00:00
umherirrender
0ef09f3d2d Remove double escaping of group member name on Special:ListUsers
Similar to T31340 the group name gets double escaped

Bug: T85864
Change-Id: I9202fc12c2d72baf1f61cb69624b37411b0edacc
2015-01-06 16:29:41 +00:00
jenkins-bot
0138ee519c Merge "Always use the canonical extension name to link the license file" 2015-01-06 15:54:31 +00:00
umherirrender
00624415be Use also $wgAutoloadClasses in tests for module names
Extensions using $wgAutoloadClasses where this test will fail

Follow-Up: If1125cd5fa4ed836fe15fc79480d78ebd899be4e
Change-Id: Ic2024605d7d59890c527cc0580a49da73f8516c8
2015-01-06 13:21:17 +00:00
jenkins-bot
b4550b162d Merge "API: Avoid unstubbing User for language pref when not needed" 2015-01-05 23:05:00 +00:00
jenkins-bot
9581677601 Merge "Proper namespace handling for WikiImporter" 2015-01-05 22:40:15 +00:00
Translation updater bot
d277a5a87a Localisation updates from https://translatewiki.net.
Change-Id: I360f162ccf794d3709c0d64d617d6ffbdf85b23f
2015-01-05 22:47:33 +01:00
jenkins-bot
1094ac2526 Merge "Add applicable protection types to the prop=info API" 2015-01-05 21:15:25 +00:00
Ricordisamoa
32083235eb Add applicable protection types to the prop=info API
Disabled by default, enabled with inprop=protections,
returned as 'restrictiontypes', also for non-existing titles.

Change-Id: I98604b60626b84bd8cb601a4149b80db1b6787b7
2015-01-05 22:03:45 +01:00
jenkins-bot
69613a71ca Merge "Remove silly reference ampersands from database functions in maint" 2015-01-05 20:55:22 +00:00
Timo Tijhof
f86b759ac1 exception: Implement error-json log
Follows-up 399ba2f.

Bug: T75619
Bug: T45086
Change-Id: Ia7ba355d5925a6268ffa321ffc13cc6906b487f8
2015-01-05 20:17:00 +00:00
jenkins-bot
e3054687a9 Merge "Add batch lookup for user groups and titles on Special:ActiveUsers" 2015-01-05 19:46:21 +00:00
jenkins-bot
98eadfcedb Merge "Use content language for edit summary on upload overwrite" 2015-01-05 19:41:36 +00:00
Chad Horohoe
24bc5fbec2 Remove silly reference ampersands from database functions in maint
This is 2015 and we use PHP5 I think.

Change-Id: I012de0df540fc91577585de939bb929c68664222
2015-01-05 11:32:44 -08:00
Timo Tijhof
945c1efe37 grunt: Add Karma task for automated QUnit testing in browsers
To use, ensure npm modules are up to date by running 'npm install'
in tests/frontend. Then run 'grunt qunit' to run it in Chrome.

To run it in both Firefox and Chrome (locally), run

 grunt karma:more

Moved fixture from hardcoded HTML to the testrunner so that our
tests don't depend on arbitrary HTML and thus also pass in browser
contexts where the page only loads QUnit + test suites (e.g. Karma).

Change-Id: I4e96da137340a28789b38940e75d4b6b8bc5d76a
2015-01-05 18:00:13 +00:00
Timo Tijhof
ba50b32556 SpecialJavaScriptTest: Add export feature
Add an 'export' subpage to SpecialJavaScriptTest which allows
one to request a self-sufficient JavaScript payload that will
bootstrap a ResourceLoader client and load the test suites.

This is needed for using Karma (which only loads JavaScript,
no full html pages). As such elements from the Skin and OutputPage
will not exist. While all QUnit tests in MediaWiki core and
most extensions I've seen already use #qunit-fixture, this is
now required. This to prevent leakage of elements from one
test to another, but it also prevents tests from depending
on elements provided by the server.

While the Karma setup is still in the pipeline (might land before
this commit loses WIP status), for now this can be tested via
the 'Special:JavaScriptTest/qunit/plain' subpage.

Refactor:
* Use HTTP status code 404 in the response for "noframework".
* Simplify HTML footprint by using <div id="qunit"> instead of
  hardcoding the full structure. This feature was added to QUnit
  since v1.3.0 (Feb 2012), we're using v1.14.0 (Jan 2014).
  QUnit's header is automatically derived from document.title.
* Remove redundant addModules() for 'test.mediawiki.qunit.testrunner'.
  This is already added by default.
* Move allowClickjacking() call so that it applies to other modes
  as well. The exported javascript needs to have wgBreakFrame set
  to false so that test runners can frame it.
* Change mediawiki.special.javaScriptTest to not depend on QUnit.
  It caused QUnit to load on error pages. And in theory the page
  is suited for other frameworks and shouldn't load QUnit this way.

Bug: T74063
Change-Id: I3d4d0df43bb426d9579eb0349b8b5477281a7cfc
2015-01-05 17:59:33 +00:00
Brad Jorsch
87070fc674 API: Avoid unstubbing User for language pref when not needed
It's fairly common that the API doesn't need to load the user
preferences, except to implement the unfortunate default uselang=user.

So let's move the handling of uselang=user to
RequestContext::getLanguage(), and have the API just assume that its
parent context will eventually fall back to that for uselang=user.

Bug: T85635
Change-Id: I947348d87b31808d331055dac6feb0cc2e1dd15d
2015-01-05 11:59:48 -05:00
Bryan Davis
d9360b5fcc Revise wording for installed libraries release note
Change-Id: I7afafa1b5b954e4555b10c8fd2a225f0f4754115
2015-01-05 09:08:58 -07:00
Kunal Mehta
17ccfbb7b3 Don't display composer installed extensions/skins on Special:Version
Extensions and skins should already be adding their credits through
$wgExtensionCredits, meaning that they would be duplicated in the
"Installed libraries" section.

Anything that has a type that begins with "mediawiki-" will now
be skipped.

Release notes were added for this commit and 528297f8db.

Change-Id: Ie873b16c1a8a696c7de833ae69b263161d9e15a8
2015-01-05 15:58:43 +00:00
jenkins-bot
29ca277c38 Merge "mw.ui: checkbox: Remove margin from checkbox input to fix the pseudo element overlap" 2015-01-05 15:53:21 +00:00
Bartosz Dziewoński
caa4b54a96 Merge "mw.ui: radio: Add state transition to radio buttons" 2015-01-05 15:48:53 +00:00
jenkins-bot
0ef4c260a7 Merge "Adjust images in packed gallery on window resize" 2015-01-05 15:44:15 +00:00
m4tx
3768d9a620 Adjust images in packed gallery on window resize
Original element sizes are stored in data(), and on window resize,
they are restored, so elements can be justified as on just loaded
page.

Bug: T55664
Change-Id: I286e0a4c8230c11619ca30f8f3b66778de835a33
2015-01-05 15:59:18 +01:00
jenkins-bot
0c8327466b Merge "mw.ui: button: Update usage instructions for neutral and quiet buttons" 2015-01-05 14:42:18 +00:00
jenkins-bot
804fa29382 Merge "Make jquery.suggestions obey maxRows setting" 2015-01-05 14:29:08 +00:00
jenkins-bot
ca6b71dd22 Merge "Expand error message when parser tests found no hook" 2015-01-05 13:28:39 +00:00
umherirrender
69d903dc20 Expand error message when parser tests found no hook
The existing message is hard to understand and does not mention, that
this is a problem in the parser test itself and not with phpunit.

Before:
1) Warning
The data provider specified for ParserTest_<file>::testParserTest is
invalid.
Problem running hook

After:
1) Warning
The data provider specified for ParserTest_<file>::testParser
Problem running requested parser hook from the test file

Change-Id: I0b4225cc9ab95e8dd048515315c789113dacf39e
2015-01-05 13:21:43 +00:00
James D. Forrester
f478a3602b Update OOjs UI to v0.6.1
Release notes:
 https://git.wikimedia.org/blob/oojs%2Fui.git/v0.6.1/History.md

Change-Id: Iafe5770c74b671dc04a92b9dfab6f121e7fe718d
2015-01-05 13:06:02 +00:00