Commit graph

129 commits

Author SHA1 Message Date
Happy-melon
1a80d46370 Rename Special:Resetpass to Special:ChangePassword. "pass" is vague and unintuitive, "reset" is only half of the page's function, and I'd quite like "Special:ResetPassword" for a much cleaner implementation of the 'enter-something-to-be-sent-a-reset-email' interface for bug 28244, bug 13015, etc. Diff looks much worse than it is because I had to update 95 language files... 2011-04-17 20:29:24 +00:00
Sam Reed
a6f56411a2 Remove some unused variables/globals
Fix another unreachable statement
2011-04-16 11:28:35 +00:00
Brion Vibber
ff0524b3bc Initial stab at breaking math/texvc out to Math extension.
* (bug 14202) $wgUseTeX has been superseded by the Math extension. To re-enable
  math conversion after upgrading, obtain the Math extension from SVN or from
  http://www.mediawiki.org/wiki/Extension:Math and add to LocalSettings.php:
  require_once "$IP/extensions/Math/Math.php";

This is an initial stab, and a few things remain to be cleaned up:
* messages need to be moved from core to extension
* MW_MATH_* constants should be moved to the extension from core
* old back-compat math names interfaces using those constants should be removed from message files
* classic edit toolbar's math button should be added from the extension (or else dropped) -- currently there's not a clean hook, but could do it by JS
* couple of things like the 'armourMath' function on Language & LanguageConverter may want to be redone just as an unconditional, if that's simpler.

Setting $wgUseTeX alone will no longer have any affect. The var's still there for the moment as a few bits still need to be fully moved out from core.
2011-04-09 00:39:40 +00:00
Mark A. Hershberger
92895589e1 revert r85177 since a lot of people don't set their $wgLocaltimezone 2011-04-04 18:47:28 +00:00
Mark A. Hershberger
225d09438f minor w/s cleanup 2011-04-04 18:45:03 +00:00
Sam Reed
8c0c864714 Type hints to substring used in integer addition 2011-04-04 11:48:38 +00:00
Mark A. Hershberger
c930f93725 Fix Bug#24308 where, on some platforms the date_create() function fails when the timezone isn't specified. 2011-04-02 04:49:29 +00:00
Happy-melon
e6e9b7fc9c (bug 27403) saved user preferences which are subsequently disabled with $wgHiddenPrefs are not used in output, but are retained in the database in case the preference is subsequently re-enabled. 2011-03-18 13:03:26 +00:00
Alexandre Emsenhuber
c96c0d9553 * (bug 22606) Follow-up r63059: don't send the "someone registred an account" message when setting email address (i.e. old one empty) in user preferences 2011-01-29 09:32:02 +00:00
Antoine Musso
811ff45c33 Remove debugging issue in user preferences
'tototo' message key does not exist that made the message dropped.
Could have used null as a value but it looks nicer to just set
the value.

Per CR on r80281
2011-01-14 20:43:30 +00:00
Antoine Musso
83848f26d9 bug 10158 : do not mention allowing others to contact you if $wgEnableUserEmail=false
This required to tweak HTMLForm to support an array of message keys
for help message. I could reuse help-message but since this helper
also supports array, I created an additional helper for array of
messages.

To test use variations of $wgEnableUserEmail and $wgEmailConfirmToEdit.

Path adapted from jopiswezggzmw at mailinator dot com
2011-01-14 16:53:36 +00:00
Daniel Friesen
39ab3cfc9f Implement Message::isBlank and Message::isDisabled.
And while we're at it... update a random assortment of code using wfEmptyMsg to use the new wfMessage class and our exists/isBlank/isDisabled methods.
2011-01-14 10:51:05 +00:00
Antoine Musso
3e52b0bac3 js email validation improvment (onBlur)
commit log more or less follow the diff order:
* adds an id to the UserPreferences form (#mw-prefs-form)
* Add an handler on the form submission to validate the email. This also
  update the label and, when email is invalid, get focus on the field.
* use onBlur javascript event instead of onKeyUp (per r75670 CR)
* Label update is now a function ... (wfUpdateMailValidityLabel)
* ... let us update the label on form submission
* Clear the label message when email is empty (null)
* Made the js regexp to stop capturing
* Fix js email validation function to return a boolean
  (it still return 'null' when given an empty email address)
2011-01-09 18:36:05 +00:00
Happy-melon
f301f15827 Clean up the running mess that is r64866, r65040, and then r67277. Implement and document consistent behaviour for all types of fields: if the 'name' parameter is specified, use it exactly as is, otherwise use "wp{$fieldname}". For hidden fields added with addHiddenField(), continue to use either $attrib['name'] or $name, both unaltered. 2010-12-15 21:14:36 +00:00
Happy-melon
77b9234766 Follow-up r78246: clean several integer preferences before saving. It's not dangerous to not do this, here or elsewhere, because it is done implicitly whenever the value is treated as a number; but it keeps the database tidier. 2010-12-12 15:38:54 +00:00
Alexandre Emsenhuber
4d19be865b * Converted UserMailer stuff to return a Status object instead of true-or-WikiError
* Made WikiError::isError() compatible with Status objects
* Added Status::getMessage() for backward compatibility

Extensions using WikiError::isError() to detect a failure of UserMailer::send() and realted methods should still work like before
2010-12-04 13:27:05 +00:00
Alexandre Emsenhuber
9e25ce6e0d Allow the submit callback function to return a Status object (will use this later for other forms) 2010-12-03 11:29:55 +00:00
Sam Reed
532baa51d9 Revert r77491 2010-12-01 13:36:53 +00:00
Sam Reed
b29504e54a Switch + to . for string concat 2010-11-30 18:29:08 +00:00
OverlordQ
f2df835d56 Revert r69337 (Removal of minordefault preference) 2010-11-01 18:58:24 +00:00
Sam Reed
efd8358882 More deprecated method calls 2010-10-31 16:33:48 +00:00
Sam Reed
6b3b915353 Big attack on unused variables... 2010-10-14 20:53:04 +00:00
Brian Wolff
b88d5a8f12 follow-up r74150 - empty() == bad. 2010-10-02 21:35:00 +00:00
Brian Wolff
0d5cd20121 Fix undefined variable notice if $wgHiddenPrefs[] = 'fancysig'.
Use !empty($blah) since that is what the rest of the code is doing. This does
not change the behaviour in any way, only gets rid of the warning. Issue
discovered by jorenl on irc.
2010-10-02 20:36:23 +00:00
Platonides
537826a674 Remove $wgContLanguageCode usage in core.
sed -i 's/$wgContLanguageCode/$wgLanguageCode/g'
These are now the same, always. Per and since r15827.

$wgLanguageCode wins due to being the one set by LocalSettings.

$wgContLanguageCode definition at includes/Setup.php kept for now.
2010-09-07 22:37:55 +00:00
Sam Reed
274c3f2934 Partial revert of r72240 2010-09-02 23:43:14 +00:00
Sam Reed
18346aa7e2 Remove unused global
Simplify some logic
2010-09-02 23:12:47 +00:00
Sam Reed
cc218ccc8f Remove some more unused variables 2010-08-13 11:43:01 +00:00
Platonides
c343f8dedd Use Disabled for the value 0 of stub threshold since there seems to be some confusion on how to disable it. 2010-08-03 22:13:16 +00:00
Platonides
2a17897484 $wgLang is already marked as global at the top. 2010-07-25 17:48:48 +00:00
Sam Reed
04f68827d0 Removal of unused globals
Removal of one setting of a variable to '', then not using further
2010-07-24 19:11:52 +00:00
Jeroen De Dauw
d650e70e7e Removed redundant array_reverse I found 3 months back 2010-07-19 04:23:39 +00:00
Platonides
a307c1353a Recover EditUser extension and put it up to date with the new preferences. 2010-07-15 18:30:49 +00:00
Aryeh Gregor
1b1d821d16 Remove 'minordefault' preference completely
See bug 24313.  The preference encourages people to mark changes minor
by mistake, but it's better to have minor changes not marked minor than
non-minor changes marked minor.  enwiki users at [[Help talk:Minor
edit]] seemed to think it was a good idea.  Plus, I'm always in favor of
removing user preferences where possible.

The only likely fallout of note is some bot operators who didn't notice
this suddenly find their bot not marking anything minor.  I doubt it
will cause major problems, though.
2010-07-14 18:50:32 +00:00
Danny B
6341ae34b6 * Fixing (sub)section names - they can't have the same name, because they are used as id's in HTML. 2010-07-04 11:39:32 +00:00
Alexandre Emsenhuber
9c8a11764d Fixed some doxygen warnings 2010-07-01 20:45:21 +00:00
Roan Kattouw
0d6b87dc23 Followup to r68177: per CR, move SimpleSearch preference to core. 2010-06-18 17:36:54 +00:00
Raimond Spekking
8c257d756b * Show validity period of the login cookie in Special:UserLogin and Special:Preferences
* Ask for permanent login in Special:Preferences only if $wgCookieExpiration > 0
2010-06-14 18:28:39 +00:00
Aryeh Gregor
74a21f3bd1 Remove most named character references from output
Recommit of r66254 to trunk.  This was just

find extensions phase3 -iname '*.php' \! -iname '*.i18n.php' \! -iname 'Messages*.php' \! -iname '*_Messages.php' -exec sed -i 's/ /\ /g;s/—/―/g;s/•/•/g;s/á/á/g;s/´/´/g;s/à/à/g;s/α/α/g;s/ä/ä/g;s/ç/ç/g;s/©/©/g;s/↓/↓/g;s/°/°/g;s/é/é/g;s/ê/ê/g;s/ë/ë/g;s/è/è/g;s/€/€/g;s/↔//g;s/…/…/g;s/í/í/g;s/ì/ì/g;s/←/←/g;s/“/“/g;s/·/·/g;s/−/−/g;s/–/–/g;s/ó/ó/g;s/ô/ô/g;s/œ/œ/g;s/ò/ò/g;s/õ/õ/g;s/ö/ö/g;s/£/£/g;s/′/′/g;s/″/″/g;s/»/»/g;s/→/→/g;s/”/”/g;s/Σ/Σ/g;s/×/×/g;s/ú/ú/g;s/↑/↑/g;s/ü/ü/g;s/¥/¥/g' {} +

followed by reading over every single line of the resulting diff and
fixing a whole bunch of false positives.  The reason for this change is
given in <http://lists.wikimedia.org/pipermail/wikitech-l/2010-April/047617.html>.
I cleared it with Tim and Brion on IRC before committing.  It might
cause a few problems, but I tried to be careful; please report any
issues.

I skipped all messages files.  I plan to make a follow-up commit that
alters wfMsgExt() with 'escapenoentities' to sanitize all the entities.
That way, the only messages that will be problems will be ones that
output raw HTML, and we want to get rid of those anyway.

This should get rid of all named entities everywhere except messages.  I
skipped a few things like &nbsp that I noticed in manual inspection,
because they weren't well-formed XML anyway.

Also, to everyone who uses non-breaking spaces when they could use a
normal space, or nothing at all, or CSS padding: I still hate you.  Die.
2010-05-30 17:33:59 +00:00
Siebrand Mazeland
50d2d9ecbf (bug 23313) Move watchlisthidepatrolled above token in watchlist preferences to enhance preference grouping. 2010-04-25 23:11:12 +00:00
Raimond Spekking
0f4fb8ecce * Add accesskey 's' and tooltip to 'Save' button at Special:Preferences 2010-04-24 20:07:13 +00:00
Andrew Garrett
3c86340129 Eliminate $wgLivePreview toggle for the uselivepreview preference 2010-04-21 14:19:04 +00:00
Siebrand Mazeland
74ce7ace28 Update indentation/formatting and add braces where missing in if() and foreach() 2010-04-15 18:36:12 +00:00
Siebrand Mazeland
6e856741bc Remove the 'editwidth' preference and related code.
I was not able to find any scenario that changed editor behavior anymore in monobook, modern, vector, classic or chick skin.
2010-04-15 18:11:24 +00:00
Ilmari Karonen
181acca654 fix fatal error in Special:Preferences if $wgDefaultUserOptions['date'] is not valid for the user's interface language 2010-04-10 23:46:58 +00:00
Happy-melon
958adc77aa Fix encoding broken in r63707 2010-03-13 20:49:34 +00:00
Happy-melon
a6e0553747 Add $wgAllowUserCssPrefs option to disable CSS-based preferences. These are injected by a 'stylesheet' /w/index.php?title=-&action=raw&gen=css, which is ~20 times slower to get out to the browser than a normal stylesheet. If you don't care about your users too much, getting rid of these options can dramatically improve page load times.
Also, update monobook/main.css to actually offer the redlink colour that's been seen on wikipedia since forever.  It's only when you turn off this per-user styling stuff that you realise that it's been overriding a different colour since September 2004 :D
2010-03-13 20:46:22 +00:00
Alexandre Emsenhuber
fa55964d72 * (bug 22747) "Reveal my e-mail address in notification e-mails" preference is now only displayed when relevant 2010-03-06 20:49:19 +00:00
Ilmari Karonen
39b2ba062d followup to r63300: add links to /common.css & /common.js to preferences 2010-03-06 20:42:35 +00:00
Aryeh Gregor
2e29d785da Spell variables correctly 2010-02-28 19:34:23 +00:00