Clean up some technical debt; use MutableRevisionRecord instead of
manually constructing a Revision from an array, remove last uses of
RevisionStoreDbTestBase::revisionToRow and remove the method.
Each file can be reviewed separately (except that the removal of
revisionToRow depends on replacing its usage)
Bug: T246284
Change-Id: I0bdc069b21a5c41ef8f9e972c5b17ff189d4a741
Entire method is already deprecated, but since its only soft deprecated
it can still be called in deployed code and needs to be updated to use
RevisionRecord::getTimestamp
Bug: T254966
Change-Id: Ib8683f5e71d86597ae284252b9d2d03e197fff3b
Use assertRevisionRecordsEqual, not assertRevisionRecordMatchesRevision
also revisionRecordToRow, not revisionToRow
RevisionStoreDbTestBase::assertRevisionRecordMatchesRevision can thus
be removed
Bug: T254952
Change-Id: If5d7d4e01947d9f8a2ed51c950e750e82380930c
WikiPage::doRollback modifies $details to include Revision objects,
and while the method has been marked as internal and will have breaking
changes made in 1.36 to remove the use of Revision objects entirely,
for now they should not be used, but rather their RevisionRecord objects
retrieved instead.
Bug: T251853
Change-Id: Ie907af06774a3980d506c9f089b0122f36cda7bf
BaseTemplate should not handle anything but rendering.
In order to allow replacing it with another renderer,
such as Mustache or Vue, its hooks should be moved to
the Skin class instead.
BaseTemplateAfterPortlet is soft deprecated to allow
filtering, preventing the hook from running twice.
Both BaseTemplate::getAfterPortlet and ::renderAfterPortlet
have been deprecated as well, with both now calling
Skin::getAfterPortlet after running the
BaseTemplateAfterPortlet hook.
Bug: T253797
Change-Id: I438daa79d3d97e2518e6258c3213a805bd1f30e8
Some changes to UserContributionsHandlerTest.php were lost and were failing.
To fix, unused mock for ContributionsLookup::getParentRevisionSizes() was
removed. As well as supplying a new, anonymous user in
UserContributionsHandlerTest::testThatAnonymousUserReturns401()
Bug: T254909
Change-Id: I8aeb8a266369725014900487fa4ccbd8a83fb843
This is part of a chain of patches to complete the REST User Contributions
endpoint. This change returns a list of the 2 (hard-coded for now) most
recent revisions for a given user.
Package.json was also updated for new api-testing module (v 1.1.0)
Bug: T252202
Change-Id: I42a5dfc0e1ff7600848e89ac2c4b002e8a3612df
This is the first in a chain of patches that iteratively create
the me/contributions endpoint that returns a list
of contributions by the currently logged in user.
This patch contains stubs for major classes needed
as well as implementation and test just for returning
a 401 Unauthorized for anonymous users.
Bug:T252202
Change-Id: Ib75711bb015f476e9d486cb3008eb7b06b148d00
