Commit graph

75558 commits

Author SHA1 Message Date
jenkins-bot
bd96b3092d Merge "Add password validation to Special:ChangeCredentials" 2017-03-17 08:35:07 +00:00
jenkins-bot
887d24dc36 Merge "Update account creation form validation" 2017-03-17 08:32:34 +00:00
jenkins-bot
a2c1e402b3 Merge "resourceloader: Use SVG url when ResourceLoaderImageModule can't embed" 2017-03-17 06:33:31 +00:00
jenkins-bot
e8f339a9f5 Merge "RCFilters UI: Separate name from paramName in filters" 2017-03-17 00:54:52 +00:00
Moriel Schottlender
6d0abc04de RCFilters UI: Separate name from paramName in filters
Represent filters, internally, with a unique name comprised
of their group and param name, and leave a reference to the
parameter (or value) they represent so the state can be
rebuilt.

Change-Id: I08b69a09463afa1cf08e1cdbf7aaec8dfc16fd2e
2017-03-16 16:16:32 -07:00
jenkins-bot
49748181dd Merge "Add support for PHP7 random_bytes in favor of mcrypt_create_iv" 2017-03-16 22:28:41 +00:00
WMDE-Fisch
f4329ddbc8 resourceloader: Use SVG url when ResourceLoaderImageModule can't embed
When the SVG is too big to be embeded it is now included via URL.
Previously it would produce an empty/broken 'url()' value.

Bug: T160532
Change-Id: I158781f9430cfa35737397ac7537a471634c4480
2017-03-16 22:11:11 +00:00
Moriel Schottlender
09c69c329f RCfilters UI: Change mute display for included filters
Bug: T156861
Bug: T149452
Change-Id: I64d84f0d84ff5e79da34f4897670102625c667cc
2017-03-16 15:04:19 -07:00
jenkins-bot
d7e0948462 Merge "RCFilters UI: Rework conflicts to be objects in filter or group context" 2017-03-16 21:41:38 +00:00
Translation updater bot
4b2b4647b3 Localisation updates from https://translatewiki.net.
Change-Id: Ic6f9b78a996f4f9971ec99d48f1bca9e9ae69ebb
2017-03-16 22:30:12 +01:00
Moriel Schottlender
e27da9d8a5 RCFilters UI: Rework conflicts to be objects in filter or group context
Allow conflicts to be defined in either the filter or the group context
and represent a whole object rather than an array of filter names.

Bug: T160453
Bug: T152754
Bug: T156427
Change-Id: I2423eb2618aa64bf30395b1a1912589e0c71f283
2017-03-16 21:29:26 +00:00
jenkins-bot
af6af5446a Merge "Show better error for anons on Special:EmailUser" 2017-03-16 19:11:24 +00:00
jenkins-bot
bd20febb02 Merge "RCFilters UI: Update fieldset as in load" 2017-03-16 18:58:19 +00:00
jenkins-bot
3bc3a94c61 Merge "RCFilters UI: Adjust filter list header elements' alignment" 2017-03-16 18:58:11 +00:00
jenkins-bot
9787acd28a Merge "RCFilters UI: Style adjustments for the FilterCapsuleMultiselectWidget" 2017-03-16 18:58:04 +00:00
Moriel Schottlender
637b3e1b76 RCFilters UI: Adjust filter list header elements' alignment
Bug: T160601
Change-Id: I89d3f9c59ef49e3c3dfdda1af8676855d3b9ac7b
2017-03-16 11:34:33 -07:00
Moriel Schottlender
5df21a7f72 RCFilters UI: Update fieldset as in load
Duplicate the javascript used on load on the fieldset
to reproduce the collapse and namespace checkboxes/select
behavior.

Bug: T157594
Change-Id: I12946be6ed6cd7ef60e87fa3576fda42f7005fb6
2017-03-16 18:33:13 +00:00
Moriel Schottlender
5a186bf7e3 RCFilters UI: Style adjustments for the FilterCapsuleMultiselectWidget
Bug: T159966
Change-Id: I6864e22d7c628297d8cdf435b48e48fbab1a3f55
2017-03-16 11:29:07 -07:00
jenkins-bot
5772a16583 Merge "RCFilters: Prevent duplicate filter names" 2017-03-16 16:56:19 +00:00
Brad Jorsch
d7e06fe0aa Add password validation to Special:ChangeCredentials
Change-Id: I70a99f4e742a2ba9ade0348001924fc5a50428d4
2017-03-16 15:42:24 +00:00
Brad Jorsch
4d59edf138 Update account creation form validation
Use the cancreateerror returned from list=users&usprop=cancreate for
username validation.

Use the new action=validatepassword to validate entered passwords.

This also injects the resulting errors in the style of HTMLForm's field
validation rather than at the top of the form.

Change-Id: Ie8c1270eb605367556fe36b0b2080eb3f957dc54
2017-03-16 15:42:06 +00:00
Eddie Greiner-Petter
274bddfb57 Show better error for anons on Special:EmailUser
When a anon user visits Special:EmailUser, the PermissionError message
is shown (as only members of the group "user" (all logged in users) are
allowed to do this). There is a better error message, which tells "You
must be logged in and have a valid email adress in your preferences."
available, but was only shown to users who are logged in but did not
have a valid mail adress in their settings, because the check for the
permission "emailuser" happened before the check for the valid mail
(which returns false for anon users). Exchanging the order of those
makes the right error message appear.

Bug: T160309
Change-Id: I26175df1f7577937d9781950058ca458984ce2cb
2017-03-16 13:22:51 +00:00
jenkins-bot
1e4fdfb825 Merge "Revert "[search] Remove more dead code"" 2017-03-16 11:09:44 +00:00
jenkins-bot
005a128c0f Merge "Revert "Default to CACHE_ACCEL if user skips advanced settings"" 2017-03-16 08:04:41 +00:00
Matthew Flaschen
2f6f69e834 RCFilters: Prevent duplicate filter names
Explicitly block two filters in the same group from having the same
name.

Before, it would be left to registerFilter, which would just cause
the second one to win.

Also, avoid a getFilter warning when the filter does not exist.
Do the same for getFilterGroup on ChangesListSpecialPage

Finally, a minor related doc fix.

Change-Id: I6b3880a5c7cc381c169bbd969cd4814559b49c91
2017-03-16 07:19:40 +00:00
Aleksey Bekh-Ivanov (WMDE)
350b138a7d Revert "Default to CACHE_ACCEL if user skips advanced settings"
This reverts commit 1fec847c6b.

Bug: T160519
Change-Id: I3bbfb5c5b61b8587ddc4af4fa134de6c86f46d98
2017-03-16 06:51:13 +00:00
jenkins-bot
b6870a55a8 Merge "RCFilters: Don't allow underscore in filter or group names" 2017-03-16 06:03:20 +00:00
jenkins-bot
b47a3006ab Merge "RCFilters: Test abstract class func directly, not in subclass tests" 2017-03-16 06:00:19 +00:00
Matthew Flaschen
d233035cb4 RCFilters: Don't allow underscore in filter or group names
This is reserved for the client-side which joins 'someGroup'
and 'somefilter' to make 'someGroup__somefilter' as an internal
ID.

Change-Id: I1b6ca9f337dd48e10705c46ef5027c3156254e01
2017-03-16 03:44:25 +00:00
Matthew Flaschen
6b2f14e15d RCFilters: Test abstract class func directly, not in subclass tests
Change-Id: I8f526975bbf0a5392b69d239bc9db9771c99cdd9
2017-03-15 23:43:26 -04:00
jenkins-bot
f37977fa15 Merge "Mark WikiRevision methods as public" 2017-03-16 00:15:19 +00:00
jenkins-bot
1471c816d2 Merge "jquery.ui: Add previously undocumented changes in PATCHES" 2017-03-16 00:05:54 +00:00
Timo Tijhof
a866197cf7 jquery.ui: Add previously undocumented changes in PATCHES
Change-Id: I8d9561916820212842f87fa2306ff7474b268173
2017-03-15 16:52:31 -07:00
jenkins-bot
9e076d6b1a Merge "Change 'history-show-deleted' message to 'Revision deleted only' for clarity" 2017-03-15 22:34:16 +00:00
Translation updater bot
a43c2d13fc Localisation updates from https://translatewiki.net.
Change-Id: Ie2f9d001e9396e7a28d4c83deeae9acef01b76c7
2017-03-15 21:55:50 +01:00
jenkins-bot
0b6930c621 Merge "Revert "Improve sorting on SpecialWanted*-Pages"" 2017-03-15 20:07:49 +00:00
20after4
27bcac72e2 Revert "Improve sorting on SpecialWanted*-Pages"
This reverts commit 5b15728478. The change causes db query errors:
DBQueryError: 1054 Unknown column qc_ra.rd_namespace in order clause

Change-Id: I068beeae70037c959d42419791911c54ca9908a1
2017-03-15 19:41:55 +00:00
jenkins-bot
f7668403e0 Merge "Make infused and non-infused DateInputWidget consistent" 2017-03-15 19:26:10 +00:00
jenkins-bot
cb2e21ca43 Merge "Skin: Only load jquery.makeCollapsible if needed" 2017-03-15 17:58:03 +00:00
jenkins-bot
bff08bb439 Merge "Skin: Preload jquery.tablesorter based on rough heuristics" 2017-03-15 17:57:59 +00:00
Brian Wolff
70cd7dd712 Make selectRowCount() (hopefully) work in MSSQL.
Make table and column aliases be quoted identifiers. This
is needed for MSSQL (rowcount is a reserved word), and is
generally just a good idea.

I have tested this on MySql and SQLite. I don't have
MSSQL installed to test on.

Bug: T158766
Change-Id: Ic63f63d208ba6ad15e77eb634e94855ee2728d05
2017-03-15 17:27:02 +00:00
addshore
11ed7a4255 Mark WikiRevision methods as public
Change-Id: If252103d4850d9c9f0607a225b7d345736658cc7
2017-03-15 14:53:19 +00:00
jenkins-bot
945aeb76da Merge "RCFilters UI: Use data-feature-in-structured-ui in the frontend" 2017-03-15 11:24:45 +00:00
jenkins-bot
5803f458a7 Merge "RCFilters UI: Adjust popup positioning again" 2017-03-15 11:23:54 +00:00
jenkins-bot
6d3217b2c6 Merge "mw.loader: Add tests for mw.loader StringSet fallback" 2017-03-15 08:22:01 +00:00
jenkins-bot
a9ec60d513 Merge "rv accidental inclusion of debug code in TemplateParser" 2017-03-15 07:19:13 +00:00
jenkins-bot
630c35a367 Merge "Default to CACHE_ACCEL if user skips advanced settings" 2017-03-15 07:01:44 +00:00
Brian Wolff
1fec847c6b Default to CACHE_ACCEL if user skips advanced settings
In the event user skips advanced settings in the installer, and
CACHE_ACCEL is available, we should default to it. This is already
the default in the event the user goes to advanced settings
since b3dc2fedc5

Bug: T160495
Change-Id: Icaa2ca4e8eb63254142e837d2a47b6023a8ea0a2
2017-03-15 06:39:45 +00:00
Brian Wolff
69f3f4a923 rv accidental inclusion of debug code in TemplateParser
Follow up 73e08353fb

Change-Id: I59bcff4334be61977a617a4a8726ae90165530e7
2017-03-15 04:53:39 +00:00
jenkins-bot
5b753f715f Merge "Avoid breaking wikis that were modifying $wgDummyLanguageCodes" 2017-03-15 02:59:07 +00:00