Commit graph

103978 commits

Author SHA1 Message Date
jenkins-bot
c60ccf4e6d Merge "preferences: Move complex creation of infos for usergroups into closure" 2021-05-27 19:52:04 +00:00
jenkins-bot
a365e698f4 Merge "Remove Vector specific CSS selector for red-links in personal menu" 2021-05-27 19:41:42 +00:00
Jan Drewniak
b7ea7712db Remove Vector specific CSS selector for red-links in personal menu
Removes a CSS selector that is only used by Vector and makes red-links
in the personal menu a slightly different color than other red-links
in Vector (which are styled by rules in legacy.less).

Bug: T282884
Change-Id: Ie04182da57c968b34401a3811ce715424eaa181d
2021-05-27 21:04:59 +02:00
jenkins-bot
2d0c0b68cf Merge "Migrate searchindex to abstract schema" 2021-05-27 18:08:11 +00:00
jenkins-bot
3fca2518cd Merge "Fix array order for array_replace_recursive merge strategy" 2021-05-27 18:03:38 +00:00
jenkins-bot
06457facaa Merge "Clean up NewFilesPager: remove deprecated and unused services" 2021-05-27 17:23:27 +00:00
jenkins-bot
392b9e4926 Merge "Remove usages and hard deprecate User::changeable(By)Group" 2021-05-27 17:23:19 +00:00
jenkins-bot
93fd347463 Merge "Move User::changeable(By)Groups methods to UserGroupManager" 2021-05-27 17:17:34 +00:00
jenkins-bot
8c695196e2 Merge "Make CollapsibleFieldsetLayout more reusable" 2021-05-27 17:16:20 +00:00
jenkins-bot
3ea20f7018 Merge "Merge content-media and content-thumbnails" 2021-05-27 16:37:59 +00:00
jenkins-bot
5481d31e03 Merge "Create SessionProviderTestTrait to facilitate testing of an SessionProvider" 2021-05-27 14:30:38 +00:00
jenkins-bot
00636c85b3 Merge "Replace usage of custom File properties" 2021-05-27 14:30:32 +00:00
wikitrent
04c94272d6 Make CollapsibleFieldsetLayout more reusable
Refactor CollapsibleFieldsetLayout to work when not wrapped in
mw-htmlform-ooui-wrapper.

Bug: T278935
Change-Id: I89c17671de1c1c8b5897a75ad292c576a1e1bbb1
2021-05-27 09:12:13 -05:00
jenkins-bot
236018d5e3 Merge "Replace RecentChange::getPerformer with RecentChange::getPerformerIdentity" 2021-05-27 14:02:54 +00:00
jenkins-bot
18a613181b Merge "ActorNormalization::acquireActorId - require IDatabase" 2021-05-27 13:59:33 +00:00
Ppchelko
5596e5784a Remove usages and hard deprecate User::changeable(By)Group
This commit was reverted before cause it has changed the initialization order
and broke FlaggedRevs. Now FlaggedRevs issue was addressed, so we can apply
it back.

Bug: T254838
Change-Id: Id29024caf06fcd0d7d4e039aea8142e8131d47a7
2021-05-27 13:54:29 +00:00
jenkins-bot
68ba5b2778 Merge "RollbackPage: remove unneeded conversion to full User object" 2021-05-27 13:53:23 +00:00
jenkins-bot
e1fe27cb09 Merge "WatchlistManager: remove unneeded conversion to full User object" 2021-05-27 13:53:16 +00:00
Petr Pchelko
4e75536609 Clean up NewFilesPager: remove deprecated and unused services
Change-Id: I682b15769f31da7e7a1a6c08b45c1a2305556f2f
2021-05-27 13:47:22 +00:00
Amir Sarabadani
acd5076099 Migrate searchindex to abstract schema
For MySQL/Sqlite:
 - Nothing

For Postgres:
 - Introduce the table. It's not used but it'll be used in the future (T220450)

Bug: T164898
Bug: T230428
Bug: T220450
Change-Id: I9f33132676344f8cd813f7a438b3a6a078fd281c
2021-05-27 15:01:24 +02:00
Translation updater bot
16bbfcf288 Localisation updates from https://translatewiki.net.
Change-Id: I31a36f1d211c7227853e15a4fd8b88362c19d236
2021-05-27 14:02:42 +02:00
Translation updater bot
e3ac3fbf4a Localisation updates from https://translatewiki.net.
Change-Id: Iacd7c17b3cfa154ac03fc9b9740f8600f54c42a0
2021-05-27 13:15:56 +02:00
jenkins-bot
ecfa1d3b2c Merge "Dabatase: Assert that join conditions are arrays" 2021-05-27 10:44:55 +00:00
Gergő Tisza
fb22342dfa Dabatase: Assert that join conditions are arrays
Join conditions are in the form of [ <table> => [ 'JOIN', <cond> ] ].
If they are given incorrectly as strings, e.g. in the form
[ <table> => 'JOIN', <cond> ], there won't be any error (courtesy
of PHP handling list($a,$b)='x' by setting $a and $b to null) and
the resulting SQL will probably even be valid, just completely
different from what's intended. Be more strict about verifying
the format.

Change-Id: Id09aff6193829972cdca3262dc8bb878512c6cc3
2021-05-27 11:44:04 +02:00
Tim Starling
f5d86ec75e Replace usage of custom File properties
Some MediaHandler subclasses were setting custom properties on the File
object in order to cache file-associated state. So:

* Add File::getHandlerState() and File::setHandlerState().
* Put them in an interface, which will be used in a subsequent commit in
  MediaHandler::getSizeAndMetadata().
* Use them in DjvuHandler.
* Provide a trivial implementation of the interface, for use in testing
  and in the subsequent commit.

Change-Id: Ic365384ff13f7898c1203da38c4405abf03d7563
2021-05-27 18:48:06 +10:00
Roman Stolar
dbe594a3ce Replace RecentChange::getPerformer with RecentChange::getPerformerIdentity
Preparing replace in core (DifferenceEngine.php, Article.php, ChangesListSpecialPage.php)

Bug: T276412
Change-Id: I4fd9cbd9404879d082179b68a9993e7203e43a8d
2021-05-27 11:45:17 +03:00
DannyS712
cb0f1000d7 RollbackPage: remove unneeded conversion to full User object
The RollbackComplete hook only needs a UserIdentity

Change-Id: If8034bc69aae49475840758e36e0b3696bc0c8fd
2021-05-27 05:29:48 +00:00
DannyS712
7a8a86476b WatchlistManager: remove unneeded conversion to full User object
The UserClearNewTalkNotification hook only needs a UserIdentity

Change-Id: Ibeab18321d099556bd0cdecc77b78bc2b84c03f7
2021-05-27 05:24:47 +00:00
jenkins-bot
4bc83aa46c Merge "rdbms: cleanup ILBFactory comments about tracked load balancers" 2021-05-27 02:22:22 +00:00
jenkins-bot
a2ef517228 Merge "SpecialCreateAccount: don't reinvent the wheel for restrictions" 2021-05-27 02:05:25 +00:00
jdlrobson
d2ed0d1683 Merge content-media and content-thumbnails
The value of content-media now depends on configuration.
These modules can be merged, as the expectation is both should
apply when the UseNewMediaStructure configuration flag is enabled.

For backwards compatibility map any content-thumbnail requests to
content-media

Bug: T278560
Change-Id: I10ba53b1ee217eae9e05182e989d56f5dc107722
2021-05-27 00:26:54 +00:00
jenkins-bot
b693065c32 Merge "Skin: Factor out functions" 2021-05-27 00:22:51 +00:00
jenkins-bot
1bfac37649 Merge "resourceloader: Avoid primary connection in SqlModuleDependencyStore (2)" 2021-05-26 23:04:13 +00:00
jenkins-bot
87096ff130 Merge "Remove deprecated SpecialPage::getRestrictedPages" 2021-05-26 22:52:27 +00:00
bwang
dee771bf8b Skin: Factor out functions
Allows for the creation of create account and login urls in SkinVector

Change-Id: Ia841f92c626ca32a9ad437b3d1cff78309c83ed8
2021-05-26 17:49:13 -05:00
Amir Sarabadani
45ce30301f resourceloader: Avoid primary connection in SqlModuleDependencyStore (2)
Follows-up 663e4ce6bb.

SqlModuleDependencyStore::remove() gets called unconditionally by
RL::saveModuleDependenciesInternal() and lots of time with empty value,
this opens a master connection in GET requests where it's not needed.
Let's remove that for now.

Change-Id: I9cc658d5282b3cfa8664406497f24dedcb688369
2021-05-26 22:41:16 +00:00
DannyS712
efed250126 SpecialCreateAccount: don't reinvent the wheel for restrictions
Add restriction support to LoginSignupSpecialPage::__construct,
and set mRestriction to 'createaccount', removes the need to
inject a PermissionManager

Change-Id: Ifd7d6e687a3c78d300cc612526458afb6934a4c0
2021-05-26 22:19:21 +00:00
jenkins-bot
0807bb3c72 Merge "Make postgres IRC channel point to libera.chat" 2021-05-26 22:19:02 +00:00
jenkins-bot
0db18b839a Merge "Migrate DefaultPreferencesFactory to authority" 2021-05-26 22:02:56 +00:00
jenkins-bot
8c422cc452 Merge "resourceloader: Avoid opening a connection to master when not needed" 2021-05-26 22:01:35 +00:00
Amir Sarabadani
d37ad656c2 Make postgres IRC channel point to libera.chat
They have migrated to libera.chat:
https://www.postgresql.org/community/irc/

Bug: T283273
Change-Id: I5f14e9079cdac628fa81e6d237f9a5906bf46b6f
2021-05-26 23:35:42 +02:00
Petr Pchelko
e86cfe1592 Remove deprecated SpecialPage::getRestrictedPages
Change-Id: Id3181a46e17043f6f21200e34727a7ff627e7f16
2021-05-26 13:44:58 -07:00
jenkins-bot
536bdde845 Merge "InfoAction: Cast wgNamespaceProtection to array" 2021-05-26 20:03:14 +00:00
Amir Sarabadani
663e4ce6bb resourceloader: Avoid opening a connection to master when not needed
SqlModuleDependencyStore::storeMulti() gets called unconditionally by
RL::saveModuleDependenciesInternal() and lots of time with empty value,
this opens a master connection in GET requests where it's not needed.
Let's remove that for now.

More info in I462055ce9caa

Change-Id: I6f618d396d64c687ba6cc68cfa99bf3f4327e798
2021-05-26 21:17:30 +02:00
Matěj Suchánek
6ec6501f5d InfoAction: Cast wgNamespaceProtection to array
It is allowed to have both a string and an array of strings per namespace.

Bug: T283751
Change-Id: Ia55b99c74e85c19511bdc2206e1b7d9ad22133ba
2021-05-26 19:09:49 +00:00
jenkins-bot
267851be69 Merge "HookContainer: Fix normalization of callback for static handler" 2021-05-26 18:59:23 +00:00
jenkins-bot
575435174b Merge "Migrate UserNamePrefixSearch service to use Authority" 2021-05-26 18:35:42 +00:00
vladshapik
c0a16a41d7 Create SessionProviderTestTrait to facilitate testing of an SessionProvider
Create new SessionProviderTestTrait and
SessionProviderTestTrait::initProvider method. Replace uses of
SessionProvider::init with new method in tests.

Bug: T283709
Change-Id: I2770188faf3e4f374f9df885ff4deff7189063fc
2021-05-26 20:45:05 +03:00
DannyS712
948abe3cf0 Migrate WatchedItemQueryService to Authority
Instead of using a PermissionManager

Required some changes to the creation of
the mock users in WatchedItemQueryServiceUnitTest,
simplified those changes by combining the various
helper methods that returned user mocks.

Change-Id: Id8382a5884133013e3da0d3318a41f8c451c3039
2021-05-26 17:38:16 +00:00
jenkins-bot
be5631743e Merge "WikiImporter: inject services" 2021-05-26 16:45:59 +00:00