Commit graph

113753 commits

Author SHA1 Message Date
Jon Robson
5100288f6f Parse API should not include #mw-content-subtitle element
The newly created #mw-content-subtitle element should not be
included in parse API responses. That element is meant to identify
the subtitle area only.

Bug: T324876
Bug: T316830
Change-Id: Id8436324e2ae2fd9f488b65b3b7bfc19611870d1
2022-12-13 02:05:26 +00:00
jenkins-bot
bdbaa2d0fc Merge "rdbms: improve Database::queryMulti() error handling" 2022-12-13 00:47:33 +00:00
jenkins-bot
2dd102ffe1 Merge "Remove obsolete browser support checks for HTML5 History API" 2022-12-13 00:13:10 +00:00
Arlo Breault
5ac33424c2 Don't enable logging linter data in the /lint/ endpoint
We only want to log full page parses of the latest revision and that's
already covered by the wt2html endpoint and changeprop should ensure it
always happens.  In the future, we may want to restore this when
exploring ways to avoid the performance cost of doing the linting during
the canonical parse, but that's T325031.

Follow up to I1f69498ef759f7a82ad8ad9002d7212636e92ffe

Bug: T325031
Change-Id: Icefb46b416629c2714a7d4f282cd55cbca271323
2022-12-12 23:54:38 +00:00
James D. Forrester
efd2591125 ChangeTags: When showing a tag, also link to a filtered RecentChanges view
This isn't quite what was proposed in the original discussion (as the main
link for the tag still goes to the help page, with the secondary link to
RC, rather than the other way around), but this has the benefit of not
being a breaking change that needs dozens of messages to be immediately
altered in hundreds of languages across many repos (167 tags as of writing:

https://codesearch-beta.wmcloud.org/search/?q=%5C%22tag-&files=en%5C.json%24&excludeFiles=&repos=

Bug: T301063
Change-Id: I142f8f0667e8a4aac2f91b141a0d7311c3ef7c43
2022-12-12 18:42:33 -05:00
jenkins-bot
98d4979e94 Merge "Parsoid: Enable lint data and parser cache together" 2022-12-12 22:33:55 +00:00
jenkins-bot
81ee9e8ca8 Merge "Revert "REST: collect metrics on endpoint access"" 2022-12-12 22:16:02 +00:00
daniel
5559d2d471 Parsoid: Enable lint data and parser cache together
The previous attempt at restoring call to the ParserLogLinterData hook
had the undesirable effect of bypassing parser cache. This change
optionally enables the call to the lind data hook without disabling
parser cache.

This patch us working under the assumption that we only need to log lint
data for canonical parses.

Follow-Up to I1f69498ef75

Change-ID: I39ab54ca6e9f9a6a58b59cdd6feea07638fc908f
2022-12-12 22:57:07 +01:00
Bartosz Dziewoński
62a37013b6 Remove obsolete browser support checks for HTML5 History API
It is available in all browsers we support.

Change-Id: I7447a9aef9475ce556f80ea78eb0cca26ac1bda6
2022-12-12 21:45:25 +00:00
jenkins-bot
c8921d180f Merge "mediawiki.feedback: Remove unused localisation messages" 2022-12-12 21:01:55 +00:00
jenkins-bot
79edb0494f Merge "mediawiki.feedback: Remove unused 'bugsListLink' config option" 2022-12-12 21:01:35 +00:00
jenkins-bot
bb27ff4cbf Merge "Log linter data while parsing full pages" 2022-12-12 20:58:14 +00:00
jenkins-bot
ee2baa6872 Merge "Special:Contributions: Let the tag filter be inverted" 2022-12-12 20:50:56 +00:00
Arlo Breault
8e7aa04917 Log linter data while parsing full pages
This regressed in Ic48db1b5fdff1dfd4f2d2643d64252e5fc721e79

Bug: T246403
Change-Id: I1f69498ef759f7a82ad8ad9002d7212636e92ffe
2022-12-12 15:36:02 -05:00
dvrandecic
fbc8f79233 Special:Contributions: Let the tag filter be inverted
This adds a check box to Special:Contributions to expose the feature
to 'invert' the existing tag filter and passes this inversion through
as an exclusion to the back end, so that a tag can be excluded from
the results.

Bug: T119072
Bug: T174349
Change-Id: I34c864f25dfc199f6b32feb3025cb53e4ea050ce
2022-12-12 20:34:35 +00:00
jenkins-bot
374d578707 Merge "ParsoidOutputAccess: generate dummy output for unsupported models." 2022-12-12 20:13:31 +00:00
jenkins-bot
947c3ddba0 Merge "ParsoidOutputAccess: only cache output for wikitext" 2022-12-12 20:09:30 +00:00
Daniel Kinzler
5c7cca8776 Revert "REST: collect metrics on endpoint access"
This reverts commit d32c260ed0.

Reason for revert: Timo has reservations, I'll submit an updated version later.

Change-Id: I71d4d61a879fda4dccfc105127446cfedde75a7b
2022-12-12 20:05:06 +00:00
daniel
75d6892134 ParsoidOutputAccess: generate dummy output for unsupported models.
While RESTbase insists on getting Parsoid renderings for any content
model, don't waste CPU cycles trying to render garbage. Just output
dummy content. Nobody should ever see it.

Bug: T324711
Change-Id: I407171a5f515b594603b287a7a9e49f54e837161
2022-12-12 19:57:31 +00:00
Aaron Schulz
aa3459fb12 rdbms: improve Database::queryMulti() error handling
Allow automatic retry if the first query fails due to the
connection having already been lost. Hide packet warnings
in doMultiStatementQuery(), which can occur due to dropped
connections.

Make queryMulti() actually mark the transaction or session
as corrupt when needed,

Improve executeQuery() handling of empty $sqls arrays.
Pass the full SQL statement array to beginIfImplied().

Add re-connection tests for queryMulti().

Related documentation changes:
* Clarify affectedRows()/insertId() documentation.
* Update queryMulti() documentation to mention exceptions.
* Add comments about avoiding direct BEGIN/COMMIT/ROLLBACK.
  These should be avoided in queryMulti() as well.

Bug: T322689
Change-Id: I51d213acccfacc48674dbcf08c177cd9872c6e15
2022-12-12 19:52:58 +00:00
Umherirrender
f2ccbd0e0c OutputPage: Remove unused dynamic property ParserOptions->isBogus
The usage was removed in a3a620a

Bug: T314099
Follow-Up: I526b1e8e310c1ad3d14402b67e6c967923f3609f
Change-Id: Iab866a18a948952d31727e3c3e36cd7957302443
2022-12-12 20:07:42 +01:00
Umherirrender
3f589f13e5 api: Remove use of undeclared property in action=comparepages
Check against the class returned by newRevisionFromArchiveRow
There is already such a check in the code
php8.2 deprecates dynamic properties

Bug: T314099
Change-Id: Ief9dbbb3d68146942f37bca758e3bfa82d5da020
2022-12-12 20:02:49 +01:00
jenkins-bot
b1c3291ed1 Merge "gitignore: add /images/phonos-render for Extension:Phonos" 2022-12-12 19:01:53 +00:00
Umherirrender
45e6a2b0f9 Use str_starts_with/str_ends_with/str_contains
Use the new function in conditions to avoid creating substrings or to
search the whole string

Change-Id: Ibad6b1b447a4f62cceb34359231f88ebb967a90b
2022-12-12 19:54:24 +01:00
Bartosz Dziewoński
a98d229ff7 mediawiki.feedback: Remove unused localisation messages
Corresponding to features that were removed or rewritten
in e75605bc0e.

Change-Id: I19b3bccee3d8b5063e58434ae3af56a33fc4aef5
2022-12-12 19:38:13 +01:00
Bartosz Dziewoński
b3d150671a mediawiki.feedback: Remove unused 'bugsListLink' config option
This feature was removed in e75605bc0e.

Change-Id: I0ea65bf97de04e179318dd3aa42702d510c69bd3
2022-12-12 19:35:48 +01:00
MusikAnimal
46314491c1 gitignore: add /images/phonos-render for Extension:Phonos
Change-Id: Ice6a986f31c3708926eeb663a98b575935f2ae30
2022-12-12 13:13:56 -05:00
James D. Forrester
e3a8d24474 RCFilters: Set 'vertical-align' on all cells once, for simplicity
Change-Id: I2f82cbb8f05e4c29933bd4104d4df173ae882dc6
2022-12-12 12:49:44 -05:00
jenkins-bot
eacc4440df Merge "uuid\GlobalIdGenerator: Check if getmyuid() exists" 2022-12-12 17:17:31 +00:00
jenkins-bot
df11856f4d Merge "Optimize mobile prefs modals" 2022-12-12 16:13:16 +00:00
jsn
ac3128360d Optimize mobile prefs modals
Bug: T324227
Change-Id: I9f399f5517602b15a34c9e1af5dca213c2678785
2022-12-12 09:43:53 -06:00
jenkins-bot
610003c23c Merge "Cleanup: Remove some tiny private methods in favor of inlining the code" 2022-12-12 15:34:44 +00:00
Gergő Tisza
1f3b2b3af9 Title.js: Rename Title.getName[Text]
These methods have very misleading names which easily leads to
confusion with getMain[Text] which is the right method 99% of the
time. Rename them to clearly indicate they are filename-related
(it would be nicer to make them a no-op or error on non-file titles
but it would cause a B/C break which is not worth the effort) and
deprecate the old methods.

Bug: T324741
Change-Id: Ibd42236eff9e73e392c0686767c388dbc7bb249c
2022-12-12 09:37:42 -05:00
jenkins-bot
63a2eba8dd Merge "Fix iw-widget/footer overlap" 2022-12-12 14:19:17 +00:00
jenkins-bot
efcf199705 Merge "RELEASE-NOTES-1.39: Fold into HISTORY, 1.39.0 is released" 2022-12-12 13:46:50 +00:00
jenkins-bot
b340554a4d Merge "ParsoidHandler: test wt2html with old revision" 2022-12-12 13:22:36 +00:00
jenkins-bot
08cf3b486a Merge "LanguageVariantConverter: Add fallback to core LanguageConverter" 2022-12-12 12:24:26 +00:00
daniel
ad461c0fc1 Simplify convertPageBundleVariant
Follow-up for I0499c853b4e for readability.

Change-Id: I3d4b2973e3f46c05cf6d1912fe3397021b5aeddd
2022-12-12 13:16:21 +01:00
jenkins-bot
284ebe02ee Merge "thumb.php: Replace deprecated MWHttpRequest::factory" 2022-12-12 11:01:44 +00:00
jenkins-bot
a0f1a72435 Merge "Rest: Migrate most of db queries to SelectQueryBuilder" 2022-12-12 10:43:07 +00:00
Amir Sarabadani
422ccd78fe Rest: Migrate most of db queries to SelectQueryBuilder
While doing the clean up:
 - Change to calling getConnection() as getConnectionRef() is deprecated
 - Remove and simplify joining revision with actor. The actor migration
   is done and those function calls have been deprecated.
 - Fix a bug that removed condition in doing the db query
 - Avoid putting where condition in the join condition and vice versa

Bug: T311866
Change-Id: I114d240d6dade257211fca94f0c54238b0946770
2022-12-12 11:11:17 +01:00
jenkins-bot
de6ee96aa7 Merge "LanguageConverter.php: Add missing code tly (Talysh language)" 2022-12-12 10:01:54 +00:00
jenkins-bot
c23779732c Merge "Use SelectQueryBuilder in BacklinkCache" 2022-12-12 09:42:16 +00:00
Amir Sarabadani
efe5830f4e search: Avoid setting height in search thumbnails
See Ib7a7a5bce3ce10e60 for more context

This standardizes the thumbnails on new vector.

Bug: T322621
Depends-On: I12643edfad16acb072757ec29ae3ba08fc11d65b
Change-Id: I3dc682d2dcea0a0615bc0b861ee0dded84304ae4
2022-12-12 08:58:39 +01:00
Translation updater bot
b0d16c9771 Localisation updates from https://translatewiki.net.
Change-Id: I7f7b7fe0a582ac42f97295f909661ee3db612f79
2022-12-12 08:05:23 +01:00
jenkins-bot
b8f0f51e42 Merge "Parser: Allow dynamic properties on PHP 8.2" 2022-12-12 04:35:28 +00:00
jenkins-bot
ba63a283ed Merge "docs: Improve docs around SpecialPage_initListHook" 2022-12-11 20:53:57 +00:00
Umherirrender
b3d065198e docs: Improve docs around SpecialPage_initListHook
Change-Id: I45410a4c7cf2feb99b24c06e9002ebbbfc66586f
2022-12-11 20:39:10 +00:00
DannyS712
9509d1f7ce Cleanup: Remove some tiny private methods in favor of inlining the code
HistoryPager: remove ::preventClickjacking
OutputPage: remove ::getOriginTrials
RevisionStore: remove ::getDBLoadBalancer

Change-Id: Id60d9861ffd86d9a82ee7f56da939274b1be82e0
2022-12-11 20:22:37 +00:00
jenkins-bot
78bfce6ec9 Merge "Replace comments about deprecated Linker::commentBlock/formatComment" 2022-12-11 20:12:25 +00:00