This may seem a bit weird but anything else related to actor is already
under user/ including ActorCache, ActorNormalization, ActorStore and
ActorStoreFactory.
Bug: T321882
Change-Id: I7072b374bba7a0cd9d905e399c822bf30bd5c0d8
This introduces an interface HtmlOutputHelper that is implemented
by both HtmlMessageOutputHelper or HtmlOutputRendererHelper based
on the page we're dealing with.
Bug: T323558
Change-Id: I1fb8dcc5cc05ce3f32f3c1862b88045f1c8e612b
To follow Message. This is approved as part of RFC T166010.
Also namespace it but doing it properly with PSR-4 would require
namespacing every class under language/ and that will take some time.
Bug: T321882
Change-Id: I195cf4c67bd51410556c2dd1e33cc9c1033d5d18
The history page renders an extensible list of tools for each
change list row. I've factored this code out so that it
can also be used on other pages that use the Pager class.
This generalizes the logic for the rollback link and makes sure
the control is standardized across pages. It also allows
the onHistoryTools hook run. I suggest we rename this to something
more generic in a follow up.
Right now usages of onHistoryTools are low but there should be
no issues with running it on more than the history page. One of
the benefits of this is the thanks link will now show on the
contributions page, watchlist and recent changes.
Bug: T51541
Change-Id: Ia03038e86c6a607c8b75eefedbf0285ca1a2f8c8
If HtmlOutputRendererHelper can't produce output because the page
doesn't exist, don't crash. Return a 404 instead.
Bug: T325205
Change-Id: I6a713025e2eb447ed61de8949c820bd9cda7594e
While we are at it, stop setting deprecated group recentchanges and stop
calling deprecated function getConnectionRef()
Bug: T311866
Change-Id: Ia917bebe300edb830010e9db126413b302be4d0b
This should now be the default target for people to develop upon.
Images were added in GitLab via this Merge Request which I can't make
this patch depend upon:
https://gitlab.wikimedia.org/repos/releng/dev-images/-/merge_requests/23
Bug: T319432
Change-Id: Iaa61c0f382244241c8fde10b8fa419f1f5730477
Remove 'insertSelectIsSafe' option, unused.
Remove 'topologicalPrimaryConnRef' option, no longer used as of two
months ago with I41a57247503 (8c9398f7f9).
Remove unneeded DatabaseSqlite::getTopologyBasedServerId
implementation which can inherit null instead of overriding with string
of "0". Only caller is SqlBagOStuff::makeTimestampedModificationToken
which can be used as MainStash DB, where its important that a given
server always has the same unique name within a set of db hosts that
may replicate to each other. By inheriting null as topology server ID,
it SqlBagOStuff will use IDatabase::getServerName instead. That in turn
uses the 'host' connection parameter, which defaults to null in
DatabaseFactory, and then falls back to the string "unknown" which is
as good as "0" for this purpose.
Bug: T299691
Change-Id: Iceb65c28cdd3c4a89b3c8b34c3f95d3285718ec0
On a wiki with very few tags, it's easy to select all tags. Because the
tags group is a string_options group, this results in a query string
with &tagfilter=all, which is incorrect and returns no results. (In the
unlikely event that a tag named 'all' exists, it will return confusing
results instead and cause other bugs.)
Fix this by adding a 'supportsAll' property to string_options groups,
which defaults to true and is only set to false for the tagfilter and
namespace groups. When supportsAll is false, 'all' is not generated or
interpreted as a magic value.
Bug: T325255
Change-Id: I892c9e2893de5b5463da76696db01e556d3e187f