* Sort $this->collated even if collateOnly is set. Also I don't think
arsort works that way.
* Fix a profiling error in every DB query, which was due to the two
scoped profiling sections being destroyed in the wrong order.
Change-Id: I6af05f37a5c0391acfa80d54ecbca7a08ad81250
After talking with the folks in #mediawiki-core, I decided that I can
put up with it, under protest, on the basis that it's arguably
consistent with PSR-2.
Change-Id: I5f0c0f8f0172674797970d306efe6439ce1c2b67
Ensure that there is a \b boundary before and after RFC, PMID, and ISBN
links. (Previously we enforced \b boundaries only before free external
links and after ISBN links.) Consistency is a good thing!
In addition:
* \b is not a PHP escape sequence, so you don't need to write \\b inside
a string.
* \b before the numeric part of an ISBN is pointless: by the structure
of the regexp there will always be a space on the left and a word
character (a digit) on the right.
Bug: 65278
Change-Id: Ic315b988091a5c7530a8285b9249804db72e55db
Try to anticipate edit submissions earlier by looking for pauses in keyboard
input, on the assumption that users often take a few moments to look over an
edit before submitting it to the server.
Change-Id: Ib2de3f15b93e5d32c66a03363e98606412d5d53b
The @requires just works for other tests, not for php functions.
This fixed a failure for the hhvm test server:
1) ApiFormatWddxTest::testValidSyntax
Failed asserting that null is of type "array".
Change-Id: Iadd8238ce62d4803cdf56508886ad016f8ac8f1d
From http://php.net/manual/en/function.posix-isatty.php
bool posix_isatty ( mixed $fd )
Determines if the file descriptor fd refers to a valid terminal type device.
fd
The file descriptor, which is expected to be either a file
resource or an integer. An integer will be assumed to be a file
descriptor that can be passed directly to the underlying system
call.
In almost all cases, you will want to provide a file resource.
Change-Id: Ief19ac1f09e0a955c8f5d5af28b87b8e8d427a2e
* newarticle
* rev-delundel
* rollbacklink
A bit of history:
* messages preloading
** added by Brion Vibber
commit 935bca8ee7
* usage of newarticle
** added by Erik Moeller
commit d61d3486f0
** removed by Alexandre Emsenhuber
commit 84be101a90
* usage of rev-delundel
** added by Aaron Schulz
commit 0ed239362c
** fixed by Raimond Spekking
commit 349ef821d6
** removed by Aaron Schulz
commit 90dcb3c1f2
* usage of rollbacklink
** present in Lee Daniel Crocker's 'initial revision'
commit d82c14fb4f
** removed from old version by Aryeh Gregor
commit 3a0c45e93c
** unused but still preloaded in Ilmari Karonen's new version
commit 2df501fa0d
Change-Id: Ib9fce5c1af4f0fd7dd3dcfefa4a6611d61123e02
By placing the notice "If 'broken' is a key in $options
then the file will appear..." added by Aaron Schulz with
commit 9d572d1844.
This solves a 'FIXME' added by Siebrand Mazeland with
commit b33c77a525.
Change-Id: I9d100588276faac5d5b2be979d8140389e5ed85a
The former is by far the most common.
Skipped:
* resources/lib/jquery.ui/jquery.ui.datepicker.js
* resources/src/mediawiki.special/mediawiki.special.upload.js
Change-Id: I73c93797e745128ba703e4865080c36784caa474
* It will also no longer call getReaderIndex( false, ... ) twice
* Removed various related ampersands
Change-Id: Ia79e2007dbf84e7437f9439aa6371333aa3e1b23
* getElementById, getElementsByTagName()[0] and jQuery#get(0) all
return an HTMLElement. Test that only once.
Avoid using random internal QUnit elements like #qunit-header.
These don't always exist (e.g. when running tests via Karma).
If anything, it should use #qunit-fixture. But might as well
create a simple DIV and test that.
* Use 'null' instead of getElementById('not-found'). We're
testing isDomElement, not getElementById.
* Add test for TextNode.
* Separate tests for isDomElement and isEmpty.
Change-Id: If9284fbbd066897561ae8e679f5f7ceab9255e18
* Make the internal MWTidy::*clean() functions always return an array of two
elements: the output buffer and the error buffer.
* Make MWTidy::externalTidy() always read both stdout and stderr. We can read
stderr after stdout because tidy.c produces output in the same order.
* Remove the $stderr parameter from the private MWTidy::*clean() methods, since
error output is always returned.
* Merge MWTidy::phpClean and MWTidy::hhvmClean, since the difference between
them is now small enough that splitting them up is not warranted.
* On HHVM, MWTidy::internalTidy() always returns an empty string for the error
buffer.
Change-Id: I178b42d6ebdd1a5b9bd5921eb093a6c5014ffa49
