Function Content::getNativeData() was deprecated. Replace with
calls to new function TextContent::getText() in most places.
Bug: T155582
Change-Id: I2bd508c72aac4faf474ba45ab1f92e2e8d2eb9be
* Move $value === false checks to isValid()
* Rename $isTombstone variable to avoid confusion with the new value
* Reorganize conditionals around set() calls in doGetWithSetCallback()
* Skip getInterimValue() check when there is no reason to assume anything
might even be there (e.g. the key is not tombstoned)
* Fold the tombstone case for $useMutex into the ternary
Change-Id: I257110097cffe7fe87c6a9896e875f09d5c936d9
Removed in 42956b99b5.
I think it's useful to know this rationale (even more so because
the arguments about caching seem no longer correct these days).
Also, add the line about loading progress not being known when
using this method.
(Slightly related to T216034)
Change-Id: I81fa90483c0c85fecc5cb620196521ce8bdd33a7
This largely follows-up 6b2f13b055.
* Make the comments and use of temporary variables easier to follow.
* Simplified some conditionals by remove redundant checks.
* Bypass the final set() call if $isTombstone is true. It will almost
always be rejected due to the tombstone still being there anyway, so
there is no point in the roundtrips. Also, the most likely case where
it would succeed is due to the callback taking a long time to run, in
which case data from the replication lag uncertainty period that the
tombstone represents would be getting saved to cache with the full
nominal TTL, which is wrong.
Change-Id: Ic28e15b24f39e128bd72ad4d905edb852bc907aa
Originally I wanted to fix the broken type hint for the `Database`
class. But I ended limiting the scope as much as possible and only
type hint at the interfaces that contain the methods the code actually
needs.
Change-Id: I450a55e80612f6e676f7c803dc904b4b653426d8
If a CommentStoreComment is constructed without a Message argument, then
the RawMessage it uses instead should specify the comment text as a
plain-text parameter, not as a regular parameter: we don’t want any
syntax in the text to be interpreted at the Message level.
Change-Id: If14debde2bceae695c8955604ee96bd5005d8b66
It's old and unmaintained. The only thing we care about is if it
was able to parse the script and if not, what its error is. Its
return value or broken inner workings are insignificant at this
point and only cause noise.
Bug: T77169
Change-Id: Ie357ccfcc6141f894b452eb3996e168c1526990f
This is already logged in LoadMonitor in getServerStates() in a less spammy way
(due to APC caching of server states).
Bug: T215611
Change-Id: Id70fdfa62eff9cb6446deea5e197f4c0af4928aa
I keep searching for the proper replacement for this deprecated
constant. It's much easier to find when the @deprecated comment
just mentions it.
Change-Id: I199b876ecfb6e146848b395bc7bfad80742f000d
This was discussed in I2b5c95d. The reason no IDE was able to find this
usage of the deprecated SpecialPage::getTitle method was the missing
type hinting.
TODO:
* A lot of properties this class uses are not declared.
* A lot of stuff in here must be private, but is public at the moment.
But this is for later patches.
Change-Id: I12fd6e517e5bd3507032ee3aafcb1de96733985b
New installation blocked when checking if the DB exists,
because when select DB, if it fails, it will throw an exception.
So I modify the checking logic to determine if there is an exception
thrown instead of detecting the return value.
Bug: T215566
Change-Id: I6817997434df7adc79fbc1b224b77c0daa8cc11d
The expand button on a <div> element has already a pseudo-class with the
expand text as content. For the collapse button this pseudo-class is
missing.
This change adds the missing pseudo-class for the collapse button to
prevent a missing button while loading.
The missing collapse button while loading is visible on
Special:RecentChanges. The expand button is always there.
Change-Id: I7fa80238d54ac43a96bf1d70bd42a0cccf90a73a
This reverts commit bf4f9d0313.
Reason for revert: causes issues with OAuth extension
The OAuth extension uses a hook to override certain tag messages, and
that hook uses RequestContext::getMain()->msg(), which tries to load
the current user. That's not allowed in load.php requests, so we get a
"Sessions are disabled for this entry point" error.
Change-Id: If58b7edfca116cd7a11f38556f74bed82609d96a
The special page RecentChanges can included in wiki content via
{{Special:RecentChanges}}
In this case the generated content is parsed by a wikitext parser. The
wikitext parser converts
<td>
<span>Foo</span>
</td>
to the HTML
<td><p><span>Foo</span></p></td>
But the wikitext
<td><span>Foo</span></td>
is converted to the HTML
<td><span>Foo</span></td>
The module 'jquery.makeCollapsible' supports custom collapsible toggle
buttons but only when they are a direct child of the <td> element. When
the module does not find a custom collapsible toggle button it adds the
default button [Expand].
Because of the additional <p> element when including the recent changes
the module 'jquery.makeCollapsible' adds a default collapsible toggle
button.
This change removes the spaces between <td> and <span> to prevent the
<p> elements when including the recent changes.
Bug: T215737
Change-Id: Ida46956fc7f9ab923c542751ac13411380c02ab0
