This commit does not yet delete the following files, which are still
used by MinervaNeue:
- resources/lib/codex-design-tokens/theme-codex-wikimedia-experimental.css
- resources/lib/codex-design-tokens/theme-codex-wikimedia-experimental.less
- resources/lib/codex-design-tokens/theme-codex-mode-dark.less
These files will be deleted in a follow-up change.
Bug: T346168
Bug: T360069
Bug: T360071
Bug: T360079
Bug: T360806
Bug: T361325
Bug: T362709
Bug: T362710
Bug: T362861
Bug: T363006
Bug: T363137
Depends-On: I350cb2dcf2de2e1944fffd38c8cafe9522706f0c
Depends-On: I539f4523b8d15a7815b303078529eb945c479be4
Depends-On: Icfcb5c7418061a5727580f0685054356ba4edb72
Change-Id: I1f54bf4f144eaec6ed317c04bd0c851c2f01b42c
The current behaviour was to return the current date, which is very
wrong; this is now null when the registration date is not known (users
created before December 2005).
Bug: T360857
Change-Id: I658a6e38abc42a93d9dbfe91f1e99e6387c17695
Why:
- Certain hooks and constraints that deny edits (SpamBlacklist,
AbuseFilter) generate manual log entries; these logs need to
reference an actor. The actor should be the same across multiple
failed attempts to save an edit.
- In order to hide the IP address associated with the request,
we can create a temporary account for every edit attempt, to
ensure that we associate the request with the log entry.
What:
- Create the temporary account at the beginning of
`EditPage::internalAttemptSave`. This is a change from the previous
temporary account creation paradigm, which created an account for a
successful edit attempt.
- Remove the pageUpdater->isChange check, as we don't have a pageUpdater
object at time of temp account creation.
- Temporary accounts are also created for no-op changes (pressing
"Publish" with unchanged wikitext editor contents)
- Note that temporary accounts are *not* created when permission related
errors are present in the edit attempt (e.g. a user attempts to edit
from a blocked IP address)
Bug: T359405
Change-Id: Ib6765f828681e70d798363338910a54c7de4ed67
Production is read new almost everywhere, mediawiki core should reflect
that as well.
Bug: T299947
Change-Id: I8f05c4d7026394205bfc54b68dc725392852ae2a
It's just a worse version of showErrorPage().
Only 1 use in MediaWiki core, no uses in WMF-deployed extensions,
very few uses elsewhere.
Change-Id: I091e789891f60ed97dd84a25c2b2e0456a1af01e
This method was deprecated in 1.42 and now can be dropped from
MW core.
In addition, some cosmetic changes in this patch:
* Type-hint `isSegmented()` to return bool.
Bug: T344521
Change-Id: Idace008e9a961953041bd21b499bfec3f8226142
No remaining uses in WMF-deployed extensions. (Although there is a
similarly named but separate function in CiteThisPage.)
Bug: T268041
Change-Id: Iec68845c631758fe85d32a939b28b6d8b1243858
This patch uses the recommended MW practice for injecting
settings into MW services. Instead of passing in the full
config object, pass in service options which MW service wiring
will use to lookup settings/options from config sources.
So in this patch, the various options have been identified
and put into `CONSTRUCTOR_OPTIONS` constant and inject via
service wiring.
Test plan
=========
Ensure that the special page: `Special:Search` still works
with this patch checkout on your local test wiki.
When you visit `Special:Search` on your local wiki, you should
see a search form view. Type in something like: "Main Page" and
then hit search. If everything works well, then local test passes.
NOTE
====
This patch also resolves a TODO which mentions the removal of
the `getConfig()` method from the SearchEngineConfig class.
Change-Id: Ib5dfc10f3f210c6c35247f4f30f9549dd60e0af7
Nowhere it has ever been activated for many years.
Nobody has been missing it.
Nobody wants it.
Bug: T361032
Depends-On: I2761d634b2c351d755c664778ee0a4796d67c37b
Depends-On: I419cba60e43e10a0a3003f911bd125573b3b7cd7
Change-Id: I067866abc9cc6acdcf05b6048416cfa6caad66d6
Note that "post" parameters remain accessible through
getValidatedParams(), while "body" parameters have to be
accessed though getValidatedBody().
This adds a numebr of tests that ensure that this remains to be the case, while deprecation warnings are triggered when appropriate.
Bug: T358560
Change-Id: Ia0eedb383e69b48a0baa0895a8c9d2229f670367
An array of MessageSpecifier objects is easier to deal with than the
"legacy error array" format, which is an array of whatever wfMessage()
accepts, which can be a bunch of different things.
Deprecate some existing getters.
Change-Id: Ibc4ce11594cf36ce7b2495d2636ee080d3443b04
