Commit graph

21755 commits

Author SHA1 Message Date
Aaron Schulz
e375c09596 (bug 16589) CoreParserFunctions error causes 500 2008-12-10 23:27:25 +00:00
Brion Vibber
95211ac850 Revert r44271 "(bug 12998) Weaken DISPLAYTITLE restictions (patch by 'rememberthedot@gmail.com')"
Behavior seems a bit hard to predict, as far as what's going to go in the header and what in the browser window etc. Pulling it back for further testing and discussion.
2008-12-10 23:21:28 +00:00
Andrew Garrett
01f9908a0f Configure extension: With DB handler, defer wfConfigureSetup() to a new hook, SetupAfterCache, which, as the name implies, is executed in Setup.php, after caches are initialised.
This avoids some weird issues with Configure and maintenance scripts.
2008-12-10 23:15:50 +00:00
Brion Vibber
26486f91ee Revert r44257 "Use boolean searching with '?' char"
Let's avoid making up our own syntax that nobody will know or think to try...
Lucene, Google, Yahoo!, and Windows Live search all understand "red OR lion" but see nothing special in "?red ?lion". If we're going to add it, let's make the OR thing work. :)
2008-12-10 23:06:44 +00:00
Brion Vibber
4e01dba6cc Revert r44254 "Cleanup to wfGetNull(): * Add override in case /dev/null isn't accessible (bug 11009)"
Doesn't seem like a proper fix here... At best, this'll be dumping random crap to some random file unless the user has a local copy of the /dev/null device file, which seems.... wrong. :)
For anything generating command lines, it probably won't make any difference (assuming exec() is enabled at all!) since open_basedir won't be searching through the command line (I think).
Assuming the core use case actually happens (open_basedir is set, but proc_open() is available to run tidy), a more correct fix is probably to go ahead and read in stderr and toss the results, or maybe better pass it through to PHP's stderr FD instead of opening /dev/null ourselves. Tidy has a -q option which should suppress random "hi i'm tidy version XYZ" if it's currently present.
2008-12-10 22:58:24 +00:00
Brion Vibber
3b571e768c Attempting to import a title that came out as an interwiki would sort of half-work somewhere then explode when trying to save the null revision with the import info:
Fatal error:  Call to a member function insertOn() on a non-object in /Library/WebServer/Documents/trunk/includes/specials/SpecialImport.php on line 305

Now such titles are skipped. You can probably force import of the page by forcing the target namespace...

Better long-term solution might include title renormalization, adapation of remote namespace names (eg Wikipedia -> Project), etc.
2008-12-10 22:41:13 +00:00
Roan Kattouw
ada841ab2d * API: (bug 16613) action=protect doesn't say when &cascade is set but cascading protection wasn't allowed
* Changed Article::updateRestrictions()'s $cascade parameter to a reference which is set to false if cascading protection isn't allowed
* Used this in ApiProtect
* Expand help message for &cascade a bit
2008-12-10 22:39:41 +00:00
Brion Vibber
2e263e8a32 Follow-up to r44245, r44250 (comment field on Special:Import)
Label now clickable for comment field on the transwiki form as well as the upload form; gave them both distinctive IDs.
2008-12-10 22:31:32 +00:00
Brion Vibber
eeba48d490 Follow-up to r44216/r44217 "Followup to r44204. Hardcoding image because it should (in theory) work always and forever. If you have a wiki acting as repo and you've overridden the canonical name Image: it's your own fault."
It was noted that the existing code could fail for unusual article path settings including a suffix if only the 'articleUrl' was available. Pretty corner case, and probably breaks a lot of other things, but who knows. :)
Went ahead and refactored this a bit to handle the case and feel a little cleaner to me...
Dropped the private getDescBaseUrl() method since this seems a little easier to handle directly in getDescriptionUrl() now.
2008-12-10 22:07:04 +00:00
Brion Vibber
525a9299cd Fix regression in Special:Ipblocklist caused by r43047 -- options arrays in show/hide links broken by being merged in the wrong order when moved from wfArrayMerge() to "+" operator. 2008-12-10 20:01:38 +00:00
Brion Vibber
cff7bfe3e8 Revert r44119 "Remove extract() comment"
extract() is pretty much the devil and shouldn't ever be used for safe, legible code because it makes it much more difficult to analyse the code -- you have to run around trying to track down the source of local variables and there's generally a lot of pain.
Removing the FIXME comment isn't a substitute for fixing it. ;)
2008-12-10 19:41:20 +00:00
Brion Vibber
9853e055ed add debug lines for UDP output so it can be more easily tested offline 2008-12-10 18:49:16 +00:00
Ilmari Karonen
feb45a7d93 revert r44412 and part of r44406: keep the improved new page URLs, but use the old getInternalURL()/preg_replace() hack to generate them 2008-12-10 18:41:28 +00:00
Ilmari Karonen
c73ca3c446 Seems r44406 would've broken the RC feed on secure.wikimedia org: fix by introducing a new config variable $wgRC2UDPScriptUrl (defaulting to $wgServer . $wgScript if not set).
NOTE: Wikimedia's secure.php needs to be updated to use the new variable.  It might be possible to retire the fixupSquidUrl() hack once this is done, though I'm not sure if anything else relies on it.
2008-12-10 17:03:57 +00:00
Ilmari Karonen
dbf477d5cc (bug 4253, bug 16586) Don't repeat titles of new pages in URLs in the RC->IRC feed, use the shorter and more useful revision ID instead.
Also simplify URL construction: old code used to call Title::getInternalURL() to build the URLs and then undo most of the work with preg_replace().
(TODO: Maybe consider introducing new global $wgIRCLineURLPrefix to optionally override the $wgInternalServer.$wgScript prefix?)
2008-12-10 15:56:02 +00:00
Aaron Schulz
208502dde8 Init $parserCache only as needed 2008-12-10 15:30:46 +00:00
Siebrand Mazeland
87fe0240a6 Localisation updates for core messages from Betawiki (2008-12-10 15:10 CET) 2008-12-10 14:19:51 +00:00
Roan Kattouw
7c6e96a734 API: (bug 16581) Fix regression from r44015 ("Various minor cleanup") which changed Article::replaceSection() to treat $section=null as $section=0 rather than $section='' as it did before, causing a nasty API edit bug. When changing a function's behavior, please update the callers, and don't forget the API. 2008-12-10 14:12:54 +00:00
Alexandre Emsenhuber
e7d8aeb7ed Fix for r44383: profiling error on unexisting class 2008-12-10 11:42:35 +00:00
David McCabe
64d53b6569 Revert r44386; depends on wfInvoke, also reverted. 2008-12-10 06:40:05 +00:00
David McCabe
cbafadf8d6 Refactored UserMailer.php. Please let me know if this breaks anything. 2008-12-10 06:02:14 +00:00
Aaron Schulz
37e0410672 * Don't set ETag if $wgUseETag = false
* Avoid casting page ID as int twice
2008-12-10 05:33:57 +00:00
Aaron Schulz
dce4ab07e8 Reduce profile overhead here 2008-12-10 05:12:54 +00:00
Aaron Schulz
d3e278c4f0 Minor RawPage tweaks 2008-12-10 04:54:46 +00:00
Aaron Schulz
db9f5258e6 Remove noisy profiling 2008-12-10 04:40:18 +00:00
Aaron Schulz
ad34eaa3d4 Code style tweaks 2008-12-10 04:06:14 +00:00
Aaron Schulz
d67b431f5a Set $wgProfileToDatabase = false 2008-12-10 03:59:43 +00:00
Ilmari Karonen
172ba2f08a (bug 14365) skip invalid titles in RepoGroup::findFiles() 2008-12-09 23:20:44 +00:00
Aaron Schulz
b3d0a9767e Whitespace/style consistency 2008-12-09 23:00:28 +00:00
Aaron Schulz
852e962656 Revert r44367; ends up with an extra fetch :/ 2008-12-09 22:28:34 +00:00
Aaron Schulz
5acfd2e095 Delay restriction fetching query 2008-12-09 22:24:21 +00:00
Aaron Schulz
c417448eec Cleanup updateRestrictions() some 2008-12-09 22:12:29 +00:00
Aaron Schulz
6c30ef8f0d Cleanup Title::getTouched() 2008-12-09 22:03:41 +00:00
Aaron Schulz
d5c22de568 Allow curid for filecache 2008-12-09 21:40:06 +00:00
Alexandre Emsenhuber
7b3b006f94 fix doxygen warnings 2008-12-09 19:54:30 +00:00
Rotem Liss
01d1c77556 Localization update. 2008-12-09 16:04:48 +00:00
Raimond Spekking
1150cc5331 Per Brions suggestions http://www.mediawiki.org/wiki/Special:Code/MediaWiki/44245#c829
* Append the reason with a colon rather than wrapping in parens
* Rearrange the file-upload portion of the Special:Import form a bit
* Using one message for the comment field since it'll be identical in both parts of the form
More tweaks:
* Add labels for the transwiki import portion too
* Make the forms proper for RTL wikis
2008-12-09 15:21:07 +00:00
Andrew Garrett
c2ac8f8dfb DB layer compatibility with MySQL 5+ - allow both >Exec_master_log_pos and ->Exec_Master_Log_Pos in SHOW SLAVE STATUS. 2008-12-09 15:00:17 +00:00
Aaron Schulz
ca8eaca30f Tweak profile calls 2008-12-09 11:51:00 +00:00
Aaron Schulz
b2c5dce7d7 Speed up filecache a tad 2008-12-09 11:41:31 +00:00
Siebrand Mazeland
cc663a0406 Localisation updates for core messages from Betawiki (2008-12-09 08:38 CET) 2008-12-09 07:42:23 +00:00
Aaron Schulz
d4213e6c55 * Performance tweaks
* Whitespace
2008-12-09 03:25:02 +00:00
Aaron Schulz
a5b4105921 Tweak check order to be slightly better 2008-12-09 02:55:49 +00:00
Trevor Parscal
6cd1e485ba Fixed empty list of footer links when no footer messages are set. 2008-12-09 01:21:54 +00:00
Brion Vibber
611b224f31 * (bug 14268) SVG image sizes now extracted with proper XML parser
Uses a filter with XmlTypeCheck. Yay!
Now works with UTF-16 sample file uploaded on the bug. Should work with large comments etc as well.
2008-12-09 00:26:09 +00:00
Aryeh Gregor
50c1e9a500 Fix MySQL-centrism in comment 2008-12-08 23:10:24 +00:00
Aaron Schulz
57073ee3b1 Make pageCond() use PK is ID is already cached 2008-12-08 22:30:58 +00:00
Alexandre Emsenhuber
b6f827b739 * fix doxygen warnings
* fix whitespaces
2008-12-08 17:29:24 +00:00
Alexandre Emsenhuber
4b160a4d84 Check if wfDebug() is defined before calling it since AutoLoader.php is loaded before GlobalFunctions.php and may result in fatal error 2008-12-08 15:35:06 +00:00
Aaron Schulz
88d407ed9e Tweak r44296: use autoloader if it is set there 2008-12-08 11:48:08 +00:00