Commit graph

92130 commits

Author SHA1 Message Date
Thiemo Kreuz
e4272518f7 tests: Replace PHPUnit's loose assertEquals(false) with assertFalse()
assertEquals( false, … ) still succeeds when the actual value is 0, null,
an empty string, even an empty array. All these should be reported as a
failure, I would argue.

Note this patch previously also touched assertSame( false ). I reverted
these. The only benefit would have been consistency within this codebase,
but there is no strict reason to prefer one over the other. assertFalse()
and assertSame( false ) are functionally identical.

Change-Id: Ic5f1c7d504e7249002d3184520012e03313137b4
2019-10-04 00:30:36 +00:00
jenkins-bot
58d368db58 Merge "resourceloader: Improve getDefinitionSummary() docs" 2019-10-03 23:55:45 +00:00
jenkins-bot
a6b1de93b7 Merge "LESS imports should not be ambigious" 2019-10-03 23:02:01 +00:00
jenkins-bot
39c1aab1c5 Merge "Revert "Unbreak Pbkdf2PasswordTest"" 2019-10-03 22:13:57 +00:00
jenkins-bot
ec440ce1bf Merge "Make max-age configurable for logged-out users" 2019-10-03 22:13:50 +00:00
Gilles Dubuc
ea9cb5ceaa Make max-age configurable for logged-out users
For small wikis. When a CDN is present, the value is
overwritten by the CDN.

Bug: T231184
Change-Id: I45a53571d0f5f6316eb97b396c18c0b224586526
2019-10-03 21:59:10 +00:00
Kunal Mehta
56e256758a Revert "Unbreak Pbkdf2PasswordTest"
This was fixed in PHPUnit 6.5.14, thanks to @epdenouden for fixing it and
seeing it get backported. We now explicitly require ^6.5.14 in composer.json
for PHPUnit.

This reverts commit 9c5174669e.

Change-Id: I15e5a99657a74bf94af636d5a44ea74df0a324f8
2019-10-03 14:58:47 -07:00
James D. Forrester
189db9bdb0 HHVM removal: Drop hhvm.server.max_post_size ini fallback
Change-Id: I8db78bf81d1aeb3028978088102eee39340ed2fe
2019-10-03 21:46:24 +00:00
jenkins-bot
6849b5a2a8 Merge "tests: Require PHPUnit 6, drop PHPUnit 4 as an option" 2019-10-03 21:41:19 +00:00
Timo Tijhof
578703a146 resourceloader: Improve getDefinitionSummary() docs
It was mentioning what ResourceLoader needs to do with the method
internally (such as "call it from getVersionHash"), but that is
irrelevant to the developer implementing the method in sub classes.

Also update the rest and make it hopefully a bit easier to follow.

Change-Id: Idc73e344bb4ffc3f83e2efcd358ca34f98bc5443
2019-10-03 22:38:00 +01:00
jenkins-bot
8e80dd9d45 Merge "Document that block target and type properties can be null" 2019-10-03 21:35:06 +00:00
jenkins-bot
d47751769b Merge "Document 'blockpartial' in ApiBlockInfoTrait::getBlockDetails" 2019-10-03 20:19:39 +00:00
jenkins-bot
ffa4bdd616 Merge "Add .warningbox to .mw-warning-with-logexcerpt container to standardize" 2019-10-03 19:00:19 +00:00
jenkins-bot
49fdec9c51 Merge "Use splat operator in signature, not func_get_args" 2019-10-03 18:56:50 +00:00
jenkins-bot
ed3179e272 Merge "HHVM removal: Simplify wfGetRusage()" 2019-10-03 18:28:09 +00:00
jenkins-bot
d04aee874a Merge "HHVM removal: Drop HHVM support for MovePage execution of TimeMoveComplete" 2019-10-03 18:28:02 +00:00
jenkins-bot
76ec6082b4 Merge "HHVM removal: Deprecate and simplify wfIsHHVM()" 2019-10-03 18:27:56 +00:00
Volker E
6fd6651c17 Add .warningbox to .mw-warning-with-logexcerpt container to standardize
Standardizing system warning message by using general `.warningbox` class.

Bug: T234509
Change-Id: If814916af9b9a095cb038d64d859339e0f290c72
2019-10-03 11:19:45 -07:00
jenkins-bot
5863256b86 Merge "mediawiki.Title: Remove unused signature from newFromUserInput" 2019-10-03 18:11:05 +00:00
James D. Forrester
60a064feaa HHVM removal: Drop HHVM support for MovePage execution of TimeMoveComplete
Change-Id: I5b1a41d8267ca322d641b66cff9ca418eba585ea
2019-10-03 18:10:15 +00:00
James D. Forrester
27fa60be37 HHVM removal: Simplify wfGetRusage()
Change-Id: I4e7e1285951518f59423c55e5c48d995a1941a5b
2019-10-03 11:08:58 -07:00
James D. Forrester
c00e7cd793 HHVM removal: Deprecate and simplify wfIsHHVM()
Change-Id: I81b15d3ae66f070a8a1286627973a339cc08e86b
2019-10-03 11:08:57 -07:00
Thalia
3722d0426d Document 'blockpartial' in ApiBlockInfoTrait::getBlockDetails
Change-Id: I734606446ef2edf90f4051f90d1889dc8158d0f2
2019-10-03 18:45:58 +01:00
Timo Tijhof
ebda397c54 selenium: Improve README docs
Simplify the README to only mention the bare minimum about
how to use WDIO itself. The rest is deferred to the various wiki
pages, which are more up to date.

Also removes selenium.sh file, which is no longer used as of 1955a8aa56,
I forgot to re-remove it during one of the rebases.
It is now supported to pass arguments to 'npm run selenium' as well.
Previously, arguments were only supported for 'npm run selenium-test',
which required manual starting of a chromedriver.

Bug: T214708
Change-Id: I5951af9146ac5fdce8d6506d703620049d6efe74
2019-10-03 17:17:28 +00:00
jenkins-bot
da4d9b575f Merge "Build: Update eslint-config-wikimedia and fix errors" 2019-10-03 16:10:08 +00:00
James D. Forrester
6a1c6cd86f tests: Require PHPUnit 6, drop PHPUnit 4 as an option
Bug: T192167
Change-Id: I060e589c3469806ab483197c9d9375eeaed7e532
2019-10-03 08:58:03 -07:00
jenkins-bot
3020c00e4f Merge "HHVM removal: Kill HHVM_VERSION checks in PHPUnit tests" 2019-10-03 15:51:01 +00:00
Daimona Eaytoy
c12b32c9a3 HHVM removal: Kill HHVM_VERSION checks in PHPUnit tests
Change-Id: I1d18b2d6956d326e5f9e50cd01ce2bb683a5b653
2019-10-03 15:35:21 +00:00
Ed Sanders
00b2315132 Build: Update eslint-config-wikimedia and fix errors
Change-Id: I9459dcee08ea7f5b54c41a2cfde965b011099f57
2019-10-03 08:33:21 -07:00
jenkins-bot
d425dacf16 Merge "shell: Resolve a TODO asking for error_clear_last()" 2019-10-03 12:23:00 +00:00
jenkins-bot
8f0a72a84f Merge "Setup.php: remove HHVM support" 2019-10-03 12:22:53 +00:00
jenkins-bot
37168caf3b Merge "UploadBase: remove HHVM support" 2019-10-03 12:19:17 +00:00
jenkins-bot
fed9413b92 Merge "installer: Remove explicit HHVM support" 2019-10-03 12:19:11 +00:00
jenkins-bot
d42685b30a Merge "Special:Version: remove HHVM special casing" 2019-10-03 12:19:04 +00:00
Translation updater bot
ed10997bc2 Localisation updates from https://translatewiki.net.
Change-Id: Icfa1e7fd5121fb1809337c0487de631b47d84567
2019-10-03 08:55:09 +02:00
Max Semenik
e5192f32bb shell: Resolve a TODO asking for error_clear_last()
Bug: T103671
Change-Id: I15c95962b198a0b46631c4d9a1b8fb55f37ae949
2019-10-02 21:38:09 -07:00
Max Semenik
a647c37843 Setup.php: remove HHVM support
Change-Id: I2fd43887ae996a0e0752032c6f3e8a25a6dd6d20
2019-10-02 21:03:51 -07:00
Max Semenik
2c39c152fc UploadBase: remove HHVM support
Change-Id: I3518b043f08de6b385072d6b1f4f686d7570a648
2019-10-02 21:03:49 -07:00
Max Semenik
1a4a3a0eb9 installer: Remove explicit HHVM support
Change-Id: I14c5a7b54512c7b84fd343b6cfbbbf5fe2cc898b
2019-10-02 20:55:29 -07:00
jenkins-bot
e9927cf78a Merge "HHVM removal: Drop HHVM version data in ApiQuerySiteInfo" 2019-10-03 03:02:37 +00:00
Max Semenik
306641821a Special:Version: remove HHVM special casing
Change-Id: Id3d57d8de3c028e6239e328fb7f216e0eb1608e1
2019-10-02 20:01:00 -07:00
jenkins-bot
168e6b3a13 Merge "Update wikidiff2 stubs" 2019-10-03 02:13:50 +00:00
jenkins-bot
bab4355bc1 Merge "rdbms: optimize insert(), replace(), and upsert() for sqlite when possible" 2019-10-03 02:08:40 +00:00
Aaron Schulz
4bd1b4b455 rdbms: optimize insert(), replace(), and upsert() for sqlite when possible
Change-Id: Ic884a4ce42a99333f5176f7b681f8a8bba15d2a1
2019-10-03 01:45:24 +00:00
jenkins-bot
a917875a1a Merge "HHVM removal: Drop HHVM code path for Exception not Throwable in API code" 2019-10-03 01:43:49 +00:00
Tim Starling
a679a5a581 Update wikidiff2 stubs
Change-Id: Iab5e2bc98d5a7d263f14c9feed934cff207fb2e8
2019-10-03 11:38:19 +10:00
jenkins-bot
4f01907c80 Merge "HHVM removal: Drop HHVM code for maintenance/" 2019-10-03 01:22:30 +00:00
James D. Forrester
b995fdcbb0 HHVM removal: Drop HHVM version data in ApiQuerySiteInfo
Change-Id: I985a1140c1f16acc8ba400f078e2d148dba3e8e8
2019-10-02 17:06:56 -07:00
James D. Forrester
d3473aca47 HHVM removal: Drop HHVM code path for Exception not Throwable in API code
Change-Id: I8c7e9bc35e4f415fa04199049313253a576846cf
2019-10-02 17:06:56 -07:00
James D. Forrester
52ed3261d9 HHVM removal: Drop HHVM code for maintenance/
Change-Id: Id713c523caacdf829d107f6d7473fe22ed9c75d6
2019-10-02 17:06:56 -07:00