$wgStyleSheetPath has been a deprecated alias for $wgStylePath since 1.3 (2004).
Time to get rid of it.
Change-Id: I78a6394003b9aefab7aa8559b8e2b22bc50154fc
Some callers (notably HistoryPager) would also provide null
prior to 79577c79. This caused page history to disappear.
Cover all these special inputs with a regression test.
Bug: T303033
Change-Id: I29e885107fc4a5b090226d8161ce823157268bf0
This is a direct follow up for what was done in I87c76fd.
Notable:
* I removed multiple "this is an invalid title" titles. These are
effectively debug messages, but why should the user see them? Either
throw an exception, or render a link that is clearly broken – as I
suggest here.
* "checkTitle" is a helper method with a strong side effect that is
not obvious from the name, in my opinion. I could not find relevant
usages and removed it.
https://codesearch.wmcloud.org/search/?q=:checkTitle%5C(&files=%5C.php%24
I propose to remove the method without deprecation because it is very
obviously meant to be a private helper method. The way it's designed
(especially in this rather specific class) it doesn't make sense to
call it from anywhere else.
Depends-On: Ic7f168fa89f0788ca679eac067b40e735f3dcc46
Change-Id: Ic776a6cdc6be30feb92b7224ef13994c14db726c
Various wikis have slightly different values for this message.
In some of those wikis there is no core definition.
It therefore seems useful to import these so a larger number of
projects benefit.
Generated via:
https://gist.github.com/jdlrobson/48168a905d814368cb75212f1b0d7bca
Bug: T301203
Change-Id: I9497777c642e53f7b3fd6cfab2ce6a1ef5bbc9d6
The tag wouldn't be treated as active, wouldn't be displayed
in changes lists and it wouldn't be possible to filter it,
although it was possible to create it.
The changes in ::modifyDisplayQuery are needed, because
ContribsPager may provide false.
Add a regression test for ::formatSummaryRow.
Bug: T296642
Change-Id: Iddb1e978387a0009425f6fad1821d9d15c0f5f23
The default for $wgExternalLinkTarget is false,
which can be set or returned on ParserOptions
Found by phan strict checks
Change-Id: Ibcf6c40eaf1ffb628fc1b92a0d0ecd79d9421100
The title object of the user page is needed to get the local url.
Just reuse the existing title instead of converting it to a string and
back.
Change-Id: I87c76fd82be340e3f8cdbb3b52a531b3b579f6a0
Url query parameter sometimes contains integer,
which are not allowed on string[], just use array instead.
Found by phan strict checks
Change-Id: I7eabe69ee7a78ffee05413a022caec940672ae9f
Some function already document "False on failure", but does not document
it on the used type
Found by phan strict checks
Change-Id: I12eb8bbc99179833ee3e42c1a7d1dc1443682ca6
This matches what the RecentChange::getEngine method provides,
which is deprecated and replaced by this. However, in order to
update tests (such as those in EventBus) to the new method, that
method first has to support mocking of this kind.
Bug: T250628
Change-Id: I126f7c8b117b5d2e66a41ebb314523083e764547
In order to safely transition Setup.php to load config-schema.yaml
rather than DefaultSettings.php, we need to be able to test the new
setup mechanism selectively, on only a few hosts.
This patch makes Setup.php use config-schema.yaml if the
MW_USE_CONFIG_SCHEMA variable is set.
The condition could be patched in production to be based on the host
name or a request parameter for further experimentation in the live
environment.
Bug: T300129
Change-Id: Idc12b8e6ee2a3cc41cf5ab8d1eb755e6fab0213d
This is split from I1d267ae, as well as a follow-up to Ie70d849.
Custom code like this exists because some messages do something
like {{#if: … | … | - }} to get dynamically disabled. This is not
something isDisabled() supports. That acts on the unparsed message
before any {{…}} was expaned.
The few cases in this patch are not affected because they use plain(),
which does not do any {{…}} expansion anyway.
Change-Id: I70541cf28c6fff14422e202f774b86086c2a850c
Xml::element needs a string to produce the tag,
explicit cast the integer and convert the possible false to zero.
Found by phan strict checks
Change-Id: I349d9ab2f999a569a90402d5197fba56e5451fc2
* Change the autonym to "ikirundi". It appears in Ethnologue,
in the Kirundi Wikpiedia, and in the
Kirundi-English Dictionary by Elizabeth E. Cox.
* Add MessagesRn.php with namespaces.
The information was confirmed by User:Gilbert Ndihokubwayo.
Bug: T302972
Change-Id: I4e97ad206fca19a46219539166fdb909381dbce4
This would have saved me around an hour if I knew it earlier. Let's make
it not happen for others.
Change-Id: I2e146424fc01677383a15d98071d8cbc2d832d9b
If no tags are specified, null shouldn't be passed as it may
cause problems down the stack
Bug: T302918
Change-Id: I46033d5ddda055c275dbda71d5c38c4a7a858c9d
