Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
63467 commits 1 branch 0 tags 744 MiB
Commit graph

30 commits

Author SHA1 Message Date
Ori Livneh
427bdb6dbd jobqueue: use more sensible metric key names 
* Since JobQueue metrics are qualified with 'jobqueue.', don't add a 'job-'
  prefix to each metric.
* Separate the key from the job type with a dot rather than a dash.
* To avoid having a Graphite node that is both a "directory" and a metric, use
  '.all' as a suffix for aggregates.

Change-Id: I2ac604d3c042dbfb0b3a27759800f435ec22041e
 2015-06-14 22:38:02 -07:00
Kunal Mehta
f138447de1 jobqueue: Record stats on how long it takes before a job is run 
Bug: T101054
Change-Id: I5dc13d79a5ec2e8cb6679e3ff2535b5cb031ca30
 2015-06-03 12:54:27 -07:00
jenkins-bot
c3f5ee0973 Merge "Let deduplicateRootJob() accept JobSpecification for consistency" 2015-06-03 17:38:35 +00:00
Aaron Schulz
22734b3c0f Let deduplicateRootJob() accept JobSpecification for consistency 
Change-Id: I872c2af40028e918fe6d9a8cd32ac97c70bffdae
 2015-05-23 12:49:44 -07:00
Aaron Schulz
6c3b99de08 Cleaned up JobQueueRedis exceptions 
Change-Id: Ic6908a759a66ef578593d50c622aca6cb92fb01f
 2015-05-23 12:22:18 -07:00
Aaron Schulz
e5ff2d681f Send job ACKs to statsd 
Change-Id: Idf6dcd6baf39484ac6fcf14465e13ae12405dd3a
 2015-05-11 16:55:42 -07:00
Aaron Schulz
87d1cbc074 Reduce chunk size in doBatchPush for redis 
Change-Id: I2c66b6b69535ce2089c1fab2df962f4ebca9f62f
 2015-05-06 18:24:34 -07:00
Aaron Schulz
9d759043d2 Removed useless doGetPeriodicTasks() override 
Change-Id: I70b33ad746c5f31bba5b83e249f8c22faf316cf4
 2015-05-06 17:49:40 -07:00
Ori.livneh
787f2dfc36 Revert "Added per-wiki queue stats information" 
Creates too many metrics.
This reverts commit 340220080e.

Task: T95913
Change-Id: Ifa478996febcdd6b3687c4cb64b215495514a899
 2015-04-20 19:31:03 +00:00
Aaron Schulz
6c9e517a70 Made showJobs.php show claimed jobs too 
Change-Id: Ifc5eeff10fdcdbbe4ade7b32e5388fee4eb94bcf
 2015-04-17 12:35:39 -07:00
Aaron Schulz
f7f49dfb00 Made job factory() callers use Title::makeTitle 
* The titles are not from user input and this simplifies the code

Change-Id: I067049cca5661b387076f0c28bc0b71d22162a0f
 2015-04-13 21:31:29 +00:00
Aaron Schulz
9720c6c410 Made showJobs.php include abandoned jobs in --list 
Change-Id: I7ae8dd2470d5e15fd66c6c06f3feb6d70527daa3
 2015-03-26 12:17:10 -07:00
Aaron Schulz
b480ec3353 Made JobQueueFederated no longer need "checkDelay" for delaying 
This reverts commit b9fd0f311c.

Change-Id: Ibff28591c268689d593cb56a58e0b33c22292eba
 2015-03-11 11:15:40 -07:00
Legoktm
b9fd0f311c Revert "Made JobQueueFederated no longer need "checkDelay" for delaying" 
Breaks Cirrus and Wikibase

This reverts commit c8f96384aa.

Change-Id: I15278d52806bf30d6ea6c6b9eb8586160f65c42b
 2015-03-11 17:10:18 +00:00
Aaron Schulz
c8f96384aa Made JobQueueFederated no longer need "checkDelay" for delaying 
* Cleaned up the weird logic for checking if delays are supported

Change-Id: I3a1a78bb48b4950b76f445bf8c27b5868d3dc89c
 2015-03-10 15:13:18 -07:00
Aaron Schulz
f826b15bd2 Only support "daemonized" mode for redis job queues to avoid code duplication 
Change-Id: I83bf61734fc48feea8a2f93adfe70f7d3a066b9e
 2015-02-10 12:18:13 -08:00
Gabriel Wicke
e883b95e70 Trival: Comment speling 
Change-Id: I17f50b5f26f5e8c1c9687c040c64699720ea6167
 2015-02-09 23:20:29 +00:00
Aaron Schulz
ee20da4346 Always supported delayed jobs in JobQueueRedis for simplicity 
* Previously, each job type had to be configured to allow delayed jobs

Change-Id: I5f3cf04deca76d6684aa6b14eea97a8673a7f5af
 2014-10-21 00:39:08 +00:00
Aaron Schulz
a6814c9df3 Removed extra "tries" increment in the redis job queue 
* This could result in jobs getting one less extra tries than they should

Change-Id: Ia2e82ca0965f6ce9e1354820eb03f40f047a949c
 2014-10-20 21:00:31 +00:00
Aaron Schulz
015ad5d403 Avoid calling recyclePruneAndUndelayJobs() in daemonized mode 
* This could cause problems if claimTTL is 0 in MW config but not
  in the runner JSON config.

Change-Id: I86418fd4426b58be1c17c97e026d14239f5e36de
 2014-10-20 20:37:32 +00:00
Aaron Schulz
9d75a0c51b Avoid needing config to be in sync between MW and the jobrunner 
* This unifies the retry and no-retry code paths so that its easier to use
  the separate job runner service.
* All jobs will use the ack procedure. If no retries are enabled they will
  just get deleted. As a side-effect, abandoned jobs can be seen for a few
  days in the no-retry case, which used to not happen. This could actually
  be useful to know about anyway.

Change-Id: I185092e3696fb336b9edcf19280dcd9a561161d9
 2014-10-17 23:03:53 +00:00
umherirrender
44d14fc684 Doc: Reformat @params declaration 
I have not found documentation about the @params command, so this seems
not valid.
I have moved the text to the corresponding @param

Change-Id: I443866d602b60570278289e6e24a77d37314cede
 2014-07-24 13:12:18 +02:00
Aaron Schulz
e11da363d0 Added "daemonized" flag to JobQueueRedis 
Change-Id: I6df1004a7872809bfd28ad1477b9504e76f75a92
 2014-07-16 22:24:50 +00:00
Nik Everett
95bfc8b956 Work around hhvm bug in redis job queue 
The hhvm redis client returns false instead of null.  This caused
JobQueueRedis to get stuck in an infinite loop.  This works around the
difference by catching null as a signal for no more jobs.

It can be reverted when https://github.com/facebook/hhvm/pull/3127/ is
in all versions of hhvm we expect to run MediaWiki.

Bug: 67622
Change-Id: I9bbad42f36a80635097b8e0140b48b6492b2f0f5
 2014-07-07 18:12:12 -04:00
Aaron Schulz
be6d82201e Added job-undelay stat calls to the Redis queue class 
Change-Id: I28f979ff6b95e09af832f8daaa6bd7bb15c2cb6b
 2014-07-06 18:21:00 +00:00
Thiemo Mättig
e292bc972d Finish removing boolean return values from JobQueue code 
This is a follow-up for patch
Ia706ac0122a7dd7f418e2dc2d3bd36e9a0252c25.

Change-Id: I19fe58a939706d3f7594d937e0bcad6d97c52a50
 2014-04-28 22:21:58 +02:00
Aaron Schulz
bab822755f Removed maximumPeriodicTaskSeconds hack; now unused 
Change-Id: Ib4308990c21b0118f00fde72412868993c5ce056
 2014-04-25 14:58:45 -07:00
umherirrender
dcf6955e5c Fixed some @params documentation (includes/*) 
Swapped some "$var type" to "type $var" or added missing types
before the $var. Changed some other types to match the more common
spelling. Makes beginning of some text in captial.

Change-Id: Ifbb1da2a6278b0bde2a6f6ce2e7bd383ee3fb28a
 2014-04-20 23:33:05 +02:00
Aaron Schulz
340220080e Added per-wiki queue stats information 
Change-Id: I25f42408c9a7a368aa99f4ceb04214f188a74be6
 2014-04-03 21:42:10 +00:00
Aaron Schulz
9ffd4f085d Renamed /job to /jobqueue 
Change-Id: I4c8a2b42140630838867c77a70d45ba14b5d95e2
 2014-03-14 13:42:04 -07:00
Renamed from includes/job/JobQueueRedis.php (Browse further)