And deprecated aliases for the the no namespaced classes.
ReplicatedBagOStuff that already is deprecated isn't moved.
Bug: T353458
Change-Id: Ie01962517e5b53e59b9721e9996d4f1ea95abb51
Why:
- User::loadFromId must avoid doing a replica read when the newly
autocreated user record isn't replicated yet; that would turn $user
into an anonymous user object, and eventually log the user out.
The old code tried to avoid this by using the same recency flag
for which UserIdentityLookup::getUserIdentityByName() returned a
non-anonymous user identity, but that's not actually a guarantee
that the user is in the database, because getUserIdentityByName()
has an internal in-process cache.
- For a specific example of this, Icf6be65a91437aa32684769c2858 broke
temp account autocreation because inserting the log entry triggered
ActorNormalization::acquireActorId() which set the in-process cache.
With this patch applied, temp account autocreation will work again
on wikis with database replication setup.
What:
- Use READ_LATEST flag when loading a user in an account
autocreation context
- See also I5456f88ebb78d2fcac685efd4a1f7a9f60d2bc0e for a proposed
follow-up to this patch
Bug: T369372
Change-Id: I04932d84aa0b0b5939706f3905f0fe7700d81327
To test this simply open the wiki editor in some page, apply some
edit and try to go somewhere else.
Change-Id: Iee3c194daddf280784e9a697eedffae61b833f04
Uses ES6 arrow functions and const/let assignments.
It favors JavaScript's map over jQuery's one as the former
doesn't tweak this which isn't used by ES6 arrow functions anyway.
Change-Id: I133f11479c10de2a5743f626fa6c1eeb1404a778
This hook enables extensions such as CentralAuth to preserve and
use query parameters needed for an authentication flow. Since there
is a provider that handles logins in a different wiki (central login
wiki), and movement to a different URL, this hook preserves query
parameters that can be used between these requests.
Bug: T363483
Bug: T362713
Change-Id: I86e629b07e6e4a0f1d1a4c78a6c77d41b4d68e18
Also add a 'use strict' just in case.
This is used for live edit preview which can be enabled editing section of the preferences.
Change-Id: I6a5ac020d84d333605af88a4efb5d19fd79e7b98
These methods: getSegmentationSize() and getSegmentedValueMaxSize()
in both the BagOStuff.php and MediumSpecificBagOStuff classes seem
unused for a while now. Codesearch shows that we have no callers of
both the parent and child class overrides.
Since these are public interfaces, they'll have to go through the
deprecation process.
Introduced in b09b3980f9 (I0667a02612526d8ddfd91d5) and later
in 2021, usage was all removed in 942f708b61 (I5c4bd74379bc45).
Change-Id: Ie529841e673abc7b68f870539dbb23a34a292c89
This shouldn't be needed as iterating over an empty array is no-op anyway.
Also 'use strict' and ES6 let/const.
Change-Id: I5f1073dbcfcc42d8e10fec191b35d7aca293d104
Use ES6 arrows and const/let assignment.
Also remove uses of 'this' as incompatiblity with ES6 arrows
which leads to easier to reason about the code also.
Change-Id: I5acea39281ccc183deeddefa74d1754cfaaefbc7
I believe these methods are what should be used in
maintenance scripts, not anything that literally starts with
$this->parameters->…
Change-Id: I5a2d19475834386e03146985ed9e5a5cd4ae1c52
