wiki.techinc.nl/tests/phpunit/includes/resourceloader
Timo Tijhof 0be2e83ef4 resourceloader: Restore feedback for SkinModule invalid argument
This was added in 381499a675 in response to the issue that when a skin
adopts a feature that was new in MW 1.36, it caused an exception when
that version of the skin is then installed on MW 1.35. That's expected,
and generally helpful because the default support policy requires
like-for-like (MW 1.35 with REL1_35, this applies to all skins and
extensions, except for a few like Translate and SemanticMediaWiki).

However, while supporting LTS within master is unusual, there are
indeed the Translate/SemanticMediaWiki projects, and this problem has
already been solved years ago there by using a conditional with
$wgVersion. The proposed approach on T271441 actually also involves
such a conditional, but late at runtime instead of in the module
definition. Anyway, the way it was fixed in Timeless already solves
the problem by not passing down the invalid feature in the first
place, thus making the 381499a675 patch obsolete. I'm not aware of
any skin in Gerrit having such a compat policy, but if they exist,
they can fix it the same way, by defining the module in code with
a condition, just as Translate/SemanticMediaWiki do.

Bug: T271441
Change-Id: If97b3d04ac1e3355ee4f229db11e524d24ebd27a
2021-05-14 20:30:15 +00:00
..
templates resourceloader: Add support for delivering templates 2014-10-29 19:31:16 +00:00
DerivativeResourceLoaderContextTest.php Merge "resourceloader: Add internal handling for debug=2" 2021-02-16 19:54:10 +00:00
MessageBlobStoreTest.php Replace PHPUnit ->returnValue() with ->willReturn() shortcut 2021-04-22 10:37:45 +02:00
ResourceLoaderClientHtmlTest.php Merge "resourceloader: Add internal handling for debug=2" 2021-02-16 19:54:10 +00:00
ResourceLoaderContextTest.php resourceloader: Add internal handling for debug=2 2021-01-29 01:09:35 +00:00
ResourceLoaderFileModuleTest.php resourceloader: Allow modules to mark themselves as ES6-only 2021-03-04 14:53:36 -05:00
ResourceLoaderImageModuleTest.php Add missing @param and @return to documentation in tests 2021-01-22 19:57:25 +01:00
ResourceLoaderLessVarFileModuleTest.php resourceloader: Fail gracefully if a LESS message is not found 2021-01-07 15:41:02 -08:00
ResourceLoaderModuleTest.php phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
ResourceLoaderOOUIImageModuleTest.php Remove usages of Skin::getAllowedSkins. 2020-08-05 02:48:29 +01:00
ResourceLoaderSkinModuleTest.php resourceloader: Restore feedback for SkinModule invalid argument 2021-05-14 20:30:15 +00:00
ResourceLoaderStartUpModuleTest.php phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
ResourceLoaderTest.php phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
ResourceLoaderWikiModuleTest.php resourceloader: Remove Title from public interfaces 2021-05-13 10:06:30 +02:00