Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/includes/api
History
Tim Starling 0c0676c34e Stop mangling $_GET and provide WebRequest::getQueryValuesOnly() 
I doubt there was ever a good reason for mangling $_GET to add the
title, this was just b/c for the sake of b/c. It was formerly used in
core but that was so long ago that I doubt there was any usage in
extensions at the time. Now there is one usage of $_GET['title'] in an
unmaintained extension, but it was only added in 2017.

Also I added WebRequest::getQueryValuesOnly() which is an interface to
the unmodified $_GET. The motivation is allowing OAuth to work with the
REST API, since OAuth needs an unmangled view of $_GET for signature
generation. The Action API gets around the problem with a special hack
in interpolateTitle(), disabling it for the Action API only.

A review of callers of getQueryValues() suggests that many would
benefit from using getQueryValuesOnly() instead. But I only changed it for
callers in api.php and thumb.php since the effect of the change there is
certainly beneficial, whereas callers under index.php may possibly be using
the path parameters to construct self-links.

Rest\RequestFromGlobals uses $_GET directly, which means that this
change causes it to not return PathRouter matches as GET parameters
anymore.

Change-Id: Ic469577fae17c0b1ac69466df7bc9f03e61c74e3
2019-09-05 15:00:28 +10:00
..
i18n Localisation updates from https://translatewiki.net. 2019-09-02 09:19:57 +02:00
ApiAMCreateAccount.php
ApiAuthManagerHelper.php Unsuppress more phan issues (part 5) 2019-09-01 09:48:31 +00:00
ApiBase.php Stop mangling $_GET and provide WebRequest::getQueryValuesOnly() 2019-09-05 15:00:28 +10:00
ApiBlock.php Unsuppress more phan issues (part 5) 2019-09-01 09:48:31 +00:00
ApiBlockInfoTrait.php Fix AbstractBlock param types in documentation 2019-05-14 13:42:50 +01:00
ApiChangeAuthenticationData.php
ApiCheckToken.php
ApiClearHasMsg.php
ApiClientLogin.php
ApiComparePages.php Deprecate and replace usages of User:isAllowed{All,Any} 2019-08-21 18:36:16 -07:00
ApiContinuationManager.php Fix/suppress misc phan errors (#4) 2019-04-05 22:28:31 +00:00
ApiCSPReport.php API: Fix 'user_id' field of ApiCSPReport 2019-07-19 22:58:39 +01:00
ApiDelete.php Fix function/class case 2019-03-29 16:20:50 -07:00
ApiDisabled.php
ApiEditPage.php Unsuppress more phan issues (part 5) 2019-09-01 09:48:31 +00:00
ApiEmailUser.php
ApiErrorFormatter.php Split ApiErrorFormatter.php to have one class in one file 2019-04-21 22:20:22 +00:00
ApiErrorFormatter_BackCompat.php Split ApiErrorFormatter.php to have one class in one file 2019-04-21 22:20:22 +00:00
ApiExpandTemplates.php Remove all $wgParser use from core 2019-04-17 15:16:50 +03:00
ApiFeedContributions.php ApiFeedContributions: Drop 'newbies' feature 2019-08-28 14:22:05 +00:00
ApiFeedRecentChanges.php Remove unused constructor parameter and unused member variables 2019-04-14 01:43:19 +00:00
ApiFeedWatchlist.php Remove all $wgParser use from core 2019-04-17 15:16:50 +03:00
ApiFileRevert.php
ApiFormatBase.php Remove usage of deprecated SkinFactory::getDefaultInstance() 2019-06-02 21:08:07 -04:00
ApiFormatFeedWrapper.php Refactor edit stashing into a PageEditStash service 2019-04-17 12:53:03 -07:00
ApiFormatJson.php
ApiFormatNone.php
ApiFormatPhp.php Various fixes to make phan-taint-check happier 2019-03-04 03:24:44 +00:00
ApiFormatRaw.php Simplify by using ?: operator 2019-04-15 15:05:00 +02:00
ApiFormatXml.php
ApiFormatXmlRsd.php Fix a couple of Generic.Files.OneObjectStructurePerFile.MultipleFound in api 2019-04-13 23:32:53 +00:00
ApiHelp.php API: Warn about POST without Content-Type 2019-08-19 13:00:37 -04:00
ApiHelpParamValueMessage.php
ApiImageRotate.php TempFSFileFactory service 2019-08-21 16:26:05 +03:00
ApiImport.php Replace User::isAllowed with PermissionManager. 2019-08-20 14:43:51 -07:00
ApiImportReporter.php Unsuppress more phan issues (part 3) 2019-08-31 16:38:55 +00:00
ApiLinkAccount.php
ApiLogin.php Remove unnecessary semi-colons 2019-06-12 14:35:59 +01:00
ApiLogout.php ApiLogout: Follow up Icb674095 2019-04-25 10:00:24 -04:00
ApiMain.php Unsuppress phan issues part 6 2019-09-01 09:48:45 +00:00
ApiManageTags.php Replace User::isAllowed with PermissionManager. 2019-08-20 14:43:51 -07:00
ApiMergeHistory.php
ApiMessage.php
ApiMessageTrait.php Globally unsuppress phan issues with low count 2019-08-30 09:40:47 +00:00
ApiModuleManager.php
ApiMove.php Avoid multiply calls to MediaWikiServices::getInstance() in one function 2019-09-01 20:49:19 +02:00
ApiOpenSearch.php Unsuppress phan issues part 6 2019-09-01 09:48:45 +00:00
ApiOpenSearchFormatJson.php Fix a couple of Generic.Files.OneObjectStructurePerFile.MultipleFound in api 2019-04-13 23:32:53 +00:00
ApiOptions.php
ApiPageSet.php Unsuppress more phan issues (part 5) 2019-09-01 09:48:31 +00:00
ApiParamInfo.php Use (int) rather than intval() 2019-02-25 00:38:33 +00:00
ApiParse.php Avoid usage of deprecated Revision::* constants, use RevisionRecord 2019-07-21 15:03:03 +01:00
ApiPatrol.php Use (int) rather than intval() 2019-02-25 00:38:33 +00:00
ApiProtect.php
ApiPurge.php
ApiQuery.php Add schema version param for API export. 2019-06-27 21:57:05 +00:00
ApiQueryAllCategories.php Use (int) rather than intval() 2019-02-25 00:38:33 +00:00
ApiQueryAllDeletedRevisions.php Use local variabe $services instead of MediaWikiServices::getInstance() 2019-08-26 16:12:05 +02:00
ApiQueryAllImages.php Remove deprecated User groups/permission static calls. 2019-08-21 19:42:01 -07:00
ApiQueryAllLinks.php i18n: Rename 11 messages for case-compliance 2019-05-18 16:39:49 +02:00
ApiQueryAllMessages.php
ApiQueryAllPages.php i18n: Rename 11 messages for case-compliance 2019-05-18 16:39:49 +02:00
ApiQueryAllRevisions.php Deprecate and replace usages of User:isAllowed{All,Any} 2019-08-21 18:36:16 -07:00
ApiQueryAllUsers.php Move User::getAllRights to PermissionManager. 2019-08-29 15:38:26 +02:00
ApiQueryAuthManagerInfo.php
ApiQueryBacklinks.php Unsuppress phan issues part 6 2019-09-01 09:48:45 +00:00
ApiQueryBacklinksprop.php API: Apply miser-mode namespace check for generator=redirects 2019-06-07 20:36:18 +00:00
ApiQueryBase.php Deprecate and replace usages of User:isAllowed{All,Any} 2019-08-21 18:36:16 -07:00
ApiQueryBlocks.php Replace User::isAllowed with PermissionManager. 2019-08-20 14:43:51 -07:00
ApiQueryCategories.php ApiQueryCategories: Supply limit for DB query 2019-09-02 11:39:45 +00:00
ApiQueryCategoryInfo.php Use (int) rather than intval() 2019-02-25 00:38:33 +00:00
ApiQueryCategoryMembers.php Use (int) rather than intval() 2019-02-25 00:38:33 +00:00
ApiQueryContributors.php Move User::getAllRights to PermissionManager. 2019-08-29 15:38:26 +02:00
ApiQueryDeletedRevisions.php Deprecate and replace usages of User:isAllowed{All,Any} 2019-08-21 18:36:16 -07:00
ApiQueryDeletedrevs.php Unsuppress more phan issues (part 5) 2019-09-01 09:48:31 +00:00
ApiQueryDisabled.php
ApiQueryDuplicateFiles.php
ApiQueryExternalLinks.php
ApiQueryExtLinksUsage.php Use (int) rather than intval() 2019-02-25 00:38:33 +00:00
ApiQueryFilearchive.php Deprecate and replace usages of User:isAllowed{All,Any} 2019-08-21 18:36:16 -07:00
ApiQueryFileRepoInfo.php
ApiQueryGeneratorBase.php
ApiQueryImageInfo.php BadFileLookup::isBadFile() expects null, not false 2019-08-27 17:50:36 +00:00
ApiQueryImages.php Use (int) rather than intval() 2019-02-25 00:38:33 +00:00
ApiQueryInfo.php Unsuppress phan issues part 6 2019-09-01 09:48:45 +00:00
ApiQueryIWBacklinks.php Use (int) rather than intval() 2019-02-25 00:38:33 +00:00
ApiQueryIWLinks.php Use (int) rather than intval() 2019-02-25 00:38:33 +00:00
ApiQueryLangBacklinks.php Merge "Return the page_id in list=langbacklinks as an int" 2019-02-25 02:45:42 +00:00
ApiQueryLangLinks.php Use (int) rather than intval() 2019-02-25 00:38:33 +00:00
ApiQueryLanguageinfo.php Fix meta=languageinfo usage example 2019-06-25 10:45:14 +02:00
ApiQueryLinks.php Use (int) rather than intval() 2019-02-25 00:38:33 +00:00
ApiQueryLogEvents.php Deprecate and replace usages of User:isAllowed{All,Any} 2019-08-21 18:36:16 -07:00
ApiQueryMyStashedFiles.php
ApiQueryPagePropNames.php
ApiQueryPageProps.php Use (int) rather than intval() 2019-02-25 00:38:33 +00:00
ApiQueryPagesWithProp.php
ApiQueryPrefixSearch.php Use (int) rather than intval() 2019-02-25 00:38:33 +00:00
ApiQueryProtectedTitles.php Fix variable in ApiQueryProtectedTitles 2019-05-23 18:57:23 +02:00
ApiQueryQueryPage.php Avoid error in querypage API when there's no value field 2019-08-02 16:05:01 +02:00
ApiQueryRandom.php
ApiQueryRecentChanges.php Deprecate and replace usages of User:isAllowed{All,Any} 2019-08-21 18:36:16 -07:00
ApiQueryRevisions.php Deprecate and replace usages of User:isAllowed{All,Any} 2019-08-21 18:36:16 -07:00
ApiQueryRevisionsBase.php Clean up spacing of doc comments 2019-08-05 22:29:50 +00:00
ApiQuerySearch.php Add ISearchResultSet 2019-07-22 18:27:39 +00:00
ApiQuerySiteinfo.php Mass conversion to NamespaceInfo 2019-05-07 22:44:56 +02:00
ApiQueryStashImageInfo.php
ApiQueryTags.php Use (int) rather than intval() 2019-02-25 00:38:33 +00:00
ApiQueryTokens.php
ApiQueryUserContribs.php Deprecate and replace usages of User:isAllowed{All,Any} 2019-08-21 18:36:16 -07:00
ApiQueryUserInfo.php Unsuppress phan issues part 6 2019-09-01 09:48:45 +00:00
ApiQueryUsers.php Unsuppress other phan issues (part 4) 2019-08-31 17:13:39 +00:00
ApiQueryWatchlist.php Collapse some nested if statements 2019-04-04 19:02:22 +00:00
ApiQueryWatchlistRaw.php Use (int) rather than intval() 2019-02-25 00:38:33 +00:00
ApiRawMessage.php
ApiRemoveAuthenticationData.php
ApiResetPassword.php
ApiResult.php Clean up spacing of doc comments 2019-08-05 22:29:50 +00:00
ApiRevisionDelete.php Deprecate User::isBlocked() 2019-04-25 11:47:44 -04:00
ApiRollback.php Use (int) rather than intval() 2019-02-25 00:38:33 +00:00
ApiRsd.php Fix a couple of Generic.Files.OneObjectStructurePerFile.MultipleFound in api 2019-04-13 23:32:53 +00:00
ApiSerializable.php
ApiSetNotificationTimestamp.php Don't require Title for getTimestampFromId 2019-05-05 14:35:53 +03:00
ApiSetPageLanguage.php
ApiStashEdit.php Remove redundant ignore_user_abort() call in ApiStashEdit 2019-08-29 22:18:57 -07:00
ApiTag.php Deprecate User::isBlocked() 2019-04-25 11:47:44 -04:00
ApiTokens.php
ApiUnblock.php Unsuppress more phan issues (part 5) 2019-09-01 09:48:31 +00:00
ApiUndelete.php Unsuppress more phan issues (part 5) 2019-09-01 09:48:31 +00:00
ApiUpload.php Unsuppress more phan issues (part 5) 2019-09-01 09:48:31 +00:00
ApiUsageException.php
ApiUserrights.php Unsuppress more phan issues (part 5) 2019-09-01 09:48:31 +00:00
ApiValidatePassword.php Unsuppress more phan issues (part 5) 2019-09-01 09:48:31 +00:00
ApiWatch.php
IApiMessage.php
SearchApi.php Unsuppress more phan issues (part 5) 2019-09-01 09:48:31 +00:00