c98e555ec6
- Adjust expected user name auto-generated from the first edit - Anonymous edit count updated (there's a new temporary count) - Temporary edit count updated (anonymous users are temporary) - Total number of unique editors (each anonymous edit is a different user) Bug: T365647 Change-Id: I5eb93d8eda607708ba7b03f5dfba4ed7e272ce5c
476 lines
19 KiB
JavaScript
476 lines
19 KiB
JavaScript
'use strict';
|
|
|
|
const { action, assert, REST, utils } = require( 'api-testing' );
|
|
const supertest = require( 'supertest' );
|
|
|
|
describe( 'Page History', () => {
|
|
const title = utils.title( 'PageHistory_' );
|
|
const titleToDelete = utils.title( 'PageHistoryDelete_' );
|
|
const client = new REST();
|
|
|
|
let mindy, bot, anon, alice, root;
|
|
let autoCreateTempUserEnabled = false;
|
|
|
|
const edits = {
|
|
all: [],
|
|
anon: [],
|
|
temp: [],
|
|
bot: [],
|
|
reverts: []
|
|
};
|
|
|
|
async function setupDeletedPage() {
|
|
const editOne = await bot.edit( titleToDelete, { text: 'Delete Me 1', summary: 'edit 1' } );
|
|
const editTwo = await mindy.edit( titleToDelete, { text: 'Counting 1', summary: 'edit 2' } );
|
|
return { editOne, editTwo };
|
|
}
|
|
|
|
async function assertGetStatus( url, status = 200 ) {
|
|
const response = await supertest.agent( url ).get( '' );
|
|
assert.equal( response.status, status, `Status of GET ${ url }` );
|
|
}
|
|
|
|
const addEditInfo = ( editInfo, editBuckets, anonUsername ) => {
|
|
const obj = {
|
|
id: editInfo.newrevid,
|
|
comment: editInfo.param_summary,
|
|
'user.name': anonUsername || editInfo.param_user,
|
|
minor: !!editInfo.param_minor
|
|
};
|
|
|
|
edits.all.unshift( obj );
|
|
editBuckets.forEach( ( editBucket ) => editBucket.unshift( obj ) );
|
|
};
|
|
|
|
before( async () => {
|
|
// Users
|
|
bot = await action.robby();
|
|
anon = action.getAnon();
|
|
alice = await action.alice();
|
|
mindy = await action.mindy();
|
|
root = await action.root();
|
|
await root.addGroups( mindy.username, [ 'suppress' ] );
|
|
|
|
const siteInfoQuery = await anon.action(
|
|
'query',
|
|
// fetch flag $wgAutoCreateTempUser['enabled'], and format to
|
|
// true/false for convenience
|
|
{ meta: 'siteinfo', siprop: 'autocreatetempuser', formatversion: 2 }
|
|
);
|
|
autoCreateTempUserEnabled = siteInfoQuery.query.autocreatetempuser.enabled;
|
|
|
|
// Create a page and make edits by various users and store edit information
|
|
addEditInfo( await alice.edit( title, { text: 'Counting 1', summary: 'creating page' } ), [] );
|
|
|
|
if ( autoCreateTempUserEnabled ) {
|
|
const resultAnonEdit = await anon.edit( title, { text: 'Counting 1 2', summary: 'anon edit 1' } );
|
|
const anonInfo = await anon.meta( 'userinfo', {} );
|
|
addEditInfo( resultAnonEdit, [ edits.temp ], anonInfo.name );
|
|
|
|
// Second edit for new anonymous user (new temp account)
|
|
anon = action.getAnon();
|
|
const resultAnonEdit2 = await anon.edit( title, { text: 'Counting 1 2 3', summary: 'anon edit 2' } );
|
|
const anonInfoEdit2 = await anon.meta( 'userinfo', {} );
|
|
addEditInfo( resultAnonEdit2, [ edits.temp ], anonInfoEdit2.name );
|
|
} else {
|
|
const anonInfo = await anon.meta( 'userinfo', {} );
|
|
anon.username = anonInfo.name;
|
|
addEditInfo( await anon.edit( title, { text: 'Counting 1 2', summary: 'anon edit 1' } ), [ edits.anon ] );
|
|
addEditInfo( await anon.edit( title, { text: 'Counting 1 2 3', summary: 'anon edit 2' } ), [ edits.anon ] );
|
|
}
|
|
addEditInfo( await bot.edit( title, { text: 'Counting 1 2 3 4', summary: 'bot edit 1' } ), [ edits.bot ] );
|
|
addEditInfo( await bot.edit( title, { text: 'Counting 1 2 3 4 5', summary: 'bot edit 2' } ), [ edits.bot ] );
|
|
|
|
// Rollback edits by bot
|
|
const summary = 'revert edits by bot';
|
|
const { rollback } = await mindy.action( 'rollback', {
|
|
title,
|
|
user: bot.username,
|
|
summary,
|
|
token: await mindy.token( 'rollback' )
|
|
}, 'POST' );
|
|
|
|
// record info for use by addEditInfo()
|
|
rollback.newrevid = rollback.revid;
|
|
rollback.param_summary = summary;
|
|
rollback.param_user = mindy.username;
|
|
// Rollbacks are minor by default
|
|
rollback.param_minor = true;
|
|
|
|
// Make sure we have something in cache in MW, so that we can verify later on it's updated
|
|
await client.get( `/page/${ title }/history/counts/edits` );
|
|
await utils.sleep();
|
|
|
|
addEditInfo( rollback, [ edits.reverts ] );
|
|
|
|
// The bot manually reverts the page to bot edit 1
|
|
addEditInfo(
|
|
await bot.edit( title, { text: 'Counting 1 2 3 4', summary: 'bot edit 3', minor: true } ),
|
|
[ edits.bot, edits.reverts ]
|
|
);
|
|
addEditInfo( await bot.edit( title, { text: 'Counting 1 2 3 4 555', summary: 'bot edit 4' } ), [ edits.bot ] );
|
|
|
|
// Undo last edit
|
|
addEditInfo( await mindy.edit( title, { undo: edits.all[ 0 ].id } ), [ edits.reverts ] );
|
|
|
|
} );
|
|
|
|
describe( 'Revision deletion and un-deletion', () => {
|
|
let deleteEdits;
|
|
it( 'Should get total number of edits and editors when edits are hidden and shown', async () => {
|
|
deleteEdits = await setupDeletedPage();
|
|
const { editOne } = deleteEdits;
|
|
|
|
// Populate cache
|
|
const { body, status, headers } = await client.get(
|
|
`/page/${ titleToDelete }/history/counts/edits`
|
|
);
|
|
assert.equal( status, 200 );
|
|
assert.match( headers[ 'content-type' ], /^application\/json/ );
|
|
assert.deepEqual( body, { count: 2, limit: false }, 'Initial edit count of 2 ' );
|
|
|
|
// Hack: If edits are not > 1 sec apart the latest timestamp will not not be detected.
|
|
// Handler uses logging table timestamps to determine last modified time,
|
|
// which are MW timestamps down to the sec, not ms.
|
|
await utils.sleep();
|
|
|
|
// Hide revision
|
|
await mindy.action( 'revisiondelete',
|
|
{
|
|
type: 'revision',
|
|
token: await mindy.token(),
|
|
target: titleToDelete,
|
|
hide: 'content|comment|user',
|
|
ids: editOne.newrevid
|
|
},
|
|
'POST'
|
|
);
|
|
|
|
const revHideEdits = await client.get( `/page/${ titleToDelete }/history/counts/edits` );
|
|
assert.equal( revHideEdits.status, 200 );
|
|
assert.match( revHideEdits.headers[ 'content-type' ], /^application\/json/ );
|
|
assert.deepEqual( revHideEdits.body, { count: 1, limit: false }, 'Edit count of 1 after hiding a revision' );
|
|
|
|
const revHideEditors = await client.get( `/page/${ titleToDelete }/history/counts/editors` );
|
|
assert.equal( revHideEditors.status, 200 );
|
|
assert.match( revHideEditors.headers[ 'content-type' ], /^application\/json/ );
|
|
assert.deepEqual( revHideEditors.body, { count: 1, limit: false }, 'Editor count of 1 after hiding a revision' );
|
|
|
|
await utils.sleep();
|
|
|
|
// Show revision
|
|
await mindy.action( 'revisiondelete',
|
|
{
|
|
type: 'revision',
|
|
token: await mindy.token(),
|
|
target: titleToDelete,
|
|
show: 'content|comment|user',
|
|
ids: editOne.newrevid
|
|
},
|
|
'POST'
|
|
);
|
|
|
|
const revShowEdits = await client.get( `/page/${ titleToDelete }/history/counts/edits` );
|
|
assert.equal( revShowEdits.status, 200 );
|
|
assert.match( revShowEdits.headers[ 'content-type' ], /^application\/json/ );
|
|
assert.deepEqual( revShowEdits.body, { count: 2, limit: false }, 'Edit count of 2 after un-hiding the hidden revision' );
|
|
|
|
const revShowEditors = await client.get( `/page/${ titleToDelete }/history/counts/editors` );
|
|
assert.equal( revShowEditors.status, 200 );
|
|
assert.match( revShowEditors.headers[ 'content-type' ], /^application\/json/ );
|
|
assert.deepEqual( revShowEditors.body, { count: 2, limit: false }, 'Editor count of 2 after un-hiding the hidden revision' );
|
|
} );
|
|
|
|
it( 'Should update last-modified header after revision deletion', async () => {
|
|
const { headers } = await client.get( `/page/${ titleToDelete }/history/counts/edits` );
|
|
const { editTwo } = deleteEdits;
|
|
assert.containsAllKeys( headers, [ 'last-modified' ] );
|
|
const lastTouchedTS = Date.parse( editTwo.newtimestamp );
|
|
const headerLastModTS = Date.parse( headers[ 'last-modified' ] );
|
|
assert.isAbove( headerLastModTS, lastTouchedTS );
|
|
} );
|
|
} );
|
|
|
|
describe( 'GET /page/{title}/history/counts/edits', () => {
|
|
it( 'Should get total number of edits', async () => {
|
|
// we do 2 requests to verify the second value coming from cache is the same
|
|
for ( let i = 0; i < 2; i++ ) {
|
|
const res = await client.get( `/page/${ title }/history/counts/edits` );
|
|
assert.equal( res.status, 200 );
|
|
assert.match( res.headers[ 'content-type' ], /^application\/json/ );
|
|
assert.deepEqual( res.body, { count: 9, limit: false } );
|
|
}
|
|
} );
|
|
|
|
it( 'Should return 400 for invalid parameter', async () => {
|
|
const res = await client.get( `/page/${ title }/history/counts/editts` );
|
|
assert.equal( res.status, 400 );
|
|
} );
|
|
|
|
it( 'Should return 404 for title that does not exist', async () => {
|
|
const title2 = utils.title( 'Random_' );
|
|
const res = await client.get( `/page/${ title2 }/history/counts/edits` );
|
|
|
|
assert.equal( res.status, 404 );
|
|
} );
|
|
|
|
it( 'Should get total number of edits between revisions, normal order', async () => {
|
|
const fromRev = edits.all[ 1 ].id;
|
|
const toRev = edits.all[ edits.all.length - 2 ].id;
|
|
const res = await client.get( `/page/${ title }/history/counts/edits?from=${ fromRev }&to=${ toRev }` );
|
|
|
|
assert.strictEqual( res.status, 200 );
|
|
assert.match( res.headers[ 'content-type' ], /^application\/json/ );
|
|
assert.deepEqual( res.body, { count: 5, limit: false } );
|
|
} );
|
|
|
|
it( 'Should get total number of edits between revisions, reverse order', async () => {
|
|
const fromRev = edits.all[ 1 ].id;
|
|
const toRev = edits.all[ edits.all.length - 2 ].id;
|
|
const res = await client.get( `/page/${ title }/history/counts/edits?from=${ toRev }&to=${ fromRev }` );
|
|
|
|
assert.strictEqual( res.status, 200 );
|
|
assert.match( res.headers[ 'content-type' ], /^application\/json/ );
|
|
assert.deepEqual( res.body, { count: 5, limit: false } );
|
|
} );
|
|
|
|
it( 'Should return 404 for deleted page', async () => {
|
|
await mindy.action( 'delete', { title: titleToDelete, token: await mindy.token() }, 'POST' );
|
|
const { status: editsStatus } = await client.get( `/page/${ titleToDelete }/history/counts/edits` );
|
|
assert.equal( editsStatus, 404 );
|
|
} );
|
|
} );
|
|
|
|
describe( 'GET /page/{title}/history/counts/anonymous', () => {
|
|
it( 'Should get total number of anonymous edits', async () => {
|
|
const res = await client.get( `/page/${ title }/history/counts/anonymous` );
|
|
|
|
assert.equal( res.status, 200 );
|
|
assert.match( res.headers[ 'content-type' ], /^application\/json/ );
|
|
const expectedCount = autoCreateTempUserEnabled ? 0 : 2;
|
|
assert.deepEqual( res.body, { count: expectedCount, limit: false } );
|
|
} );
|
|
} );
|
|
|
|
describe( 'GET /page/{title}/history/counts/temporary', () => {
|
|
it( 'Should get total number of edits by temporary users', async () => {
|
|
const res = await client.get( `/page/${ title }/history/counts/temporary` );
|
|
|
|
assert.equal( res.status, 200 );
|
|
assert.match( res.headers[ 'content-type' ], /^application\/json/ );
|
|
const expectedCount = autoCreateTempUserEnabled ? 2 : 0;
|
|
assert.deepEqual( res.body, { count: expectedCount, limit: false } );
|
|
} );
|
|
} );
|
|
|
|
describe( 'GET /page/{title}/history/counts/bot', () => {
|
|
it( 'Should get total number of edits by bots', async () => {
|
|
const res = await client.get( `/page/${ title }/history/counts/bot` );
|
|
|
|
assert.equal( res.status, 200 );
|
|
assert.match( res.headers[ 'content-type' ], /^application\/json/ );
|
|
assert.deepEqual( res.body, { count: 4, limit: false } );
|
|
} );
|
|
} );
|
|
|
|
describe( 'GET /page/{title}/history/counts/reverted', () => {
|
|
it( 'Should get total number of reverted edits', async () => {
|
|
const res = await client.get( `/page/${ title }/history/counts/reverted` );
|
|
|
|
assert.equal( res.status, 200 );
|
|
assert.match( res.headers[ 'content-type' ], /^application\/json/ );
|
|
assert.deepEqual( res.body, { count: 3, limit: false } );
|
|
} );
|
|
} );
|
|
|
|
describe( 'GET /page/{title}/history/counts/editors', () => {
|
|
it( 'Should return 404 for deleted page', async () => {
|
|
const { status: editorsStatus, header: editorsHeader } = await client.get( `/page/${ titleToDelete }/history/counts/editors` );
|
|
assert.equal( editorsStatus, 404 );
|
|
assert.match( editorsHeader[ 'content-type' ], /^application\/json/ );
|
|
} );
|
|
|
|
it( 'Should get total number of unique editors', async () => {
|
|
const res = await client.get( `/page/${ title }/history/counts/editors` );
|
|
|
|
assert.equal( res.status, 200 );
|
|
assert.match( res.headers[ 'content-type' ], /^application\/json/ );
|
|
const expectedCount = autoCreateTempUserEnabled ? 5 : 4;
|
|
assert.deepEqual( res.body, { count: expectedCount, limit: false } );
|
|
} );
|
|
|
|
it( 'Should get total number of unique editors between revisions, normal order', async () => {
|
|
const fromRev = edits.all[ 1 ].id;
|
|
const toRev = edits.all[ edits.all.length - 2 ].id;
|
|
const res = await client.get( `/page/${ title }/history/counts/editors?from=${ fromRev }&to=${ toRev }` );
|
|
|
|
assert.strictEqual( res.status, 200 );
|
|
assert.match( res.headers[ 'content-type' ], /^application\/json/ );
|
|
assert.deepEqual( res.body, { count: 3, limit: false } );
|
|
} );
|
|
|
|
it( 'Should get total number of unique editors between revisions, reverse order', async () => {
|
|
const fromRev = edits.all[ 1 ].id;
|
|
const toRev = edits.all[ edits.all.length - 2 ].id;
|
|
const res = await client.get( `/page/${ title }/history/counts/editors?from=${ toRev }&to=${ fromRev }` );
|
|
|
|
assert.strictEqual( res.status, 200 );
|
|
assert.match( res.headers[ 'content-type' ], /^application\/json/ );
|
|
assert.deepEqual( res.body, { count: 3, limit: false } );
|
|
} );
|
|
} );
|
|
|
|
describe( 'GET page/{title}/history?filter={tag}', () => {
|
|
it( 'Should get all revisions', async () => {
|
|
const res = await client.get( `/page/${ title }/history` );
|
|
|
|
assert.equal( res.status, 200 );
|
|
assert.match( res.headers[ 'content-type' ], /^application\/json/ );
|
|
assert.lengthOf( res.body.revisions, edits.all.length );
|
|
res.body.revisions
|
|
.forEach( ( rev, i ) => assert.deepNestedInclude( rev, edits.all[ i ] ) );
|
|
assert.include( res.body.latest, `page/${ title }/history` );
|
|
|
|
await assertGetStatus( res.body.latest );
|
|
} );
|
|
|
|
it( 'Should get revisions by anonymous users', async () => {
|
|
const res = await client.get( `/page/${ title }/history`, { filter: 'anonymous' } );
|
|
|
|
assert.equal( res.status, 200 );
|
|
assert.match( res.headers[ 'content-type' ], /^application\/json/ );
|
|
assert.lengthOf( res.body.revisions, edits.anon.length );
|
|
res.body.revisions
|
|
.forEach( ( rev, i ) => assert.deepNestedInclude( rev, edits.anon[ i ] ) );
|
|
assert.include( res.body.latest, `page/${ title }/history?filter=anonymous` );
|
|
|
|
await assertGetStatus( res.body.latest );
|
|
} );
|
|
|
|
it( 'Should get revisions by bots', async () => {
|
|
const res = await client.get( `/page/${ title }/history`, { filter: 'bot' } );
|
|
|
|
assert.equal( res.status, 200 );
|
|
assert.match( res.headers[ 'content-type' ], /^application\/json/ );
|
|
assert.lengthOf( res.body.revisions, edits.bot.length );
|
|
res.body.revisions
|
|
.forEach( ( rev, i ) => assert.deepNestedInclude( rev, edits.bot[ i ] ) );
|
|
assert.include( res.body.latest, `page/${ title }/history?filter=bot` );
|
|
} );
|
|
|
|
it( 'Should get reverted revisions', async () => {
|
|
const res = await client.get( `/page/${ title }/history`, { filter: 'reverted' } );
|
|
|
|
assert.equal( res.status, 200 );
|
|
assert.match( res.headers[ 'content-type' ], /^application\/json/ );
|
|
assert.lengthOf( res.body.revisions, edits.reverts.length );
|
|
res.body.revisions
|
|
.forEach( ( rev, i ) => assert.deepNestedInclude( rev, edits.reverts[ i ] ) );
|
|
assert.include( res.body.latest, `page/${ title }/history?filter=reverted` );
|
|
} );
|
|
|
|
it( 'Should return 400 for invalid filter parameter', async () => {
|
|
const res = await client.get( `/page/${ title }/history`, { filter: 'anon' } );
|
|
|
|
assert.equal( res.status, 400 );
|
|
} );
|
|
|
|
it( 'Should return 404 for title that does not exist', async () => {
|
|
const title2 = utils.title( 'Random_' );
|
|
const res = await client.get( `/page/${ title2 }/history`, { filter: 'bot' } );
|
|
|
|
assert.equal( res.status, 404 );
|
|
} );
|
|
|
|
it( 'Should update cache control headers', async () => {
|
|
const title2 = utils.title( 'Random_' );
|
|
const edit1 = await alice.edit( title2, { text: 'Old Content', summary: 'make page' } );
|
|
const res1a = await client.get( `/page/${ title2 }/history`, { filter: 'bot' } );
|
|
const res1b = await client.get( `/page/${ title2 }/history`, { filter: 'bot' } );
|
|
|
|
assert.equal( res1a.headers[ 'last-modified' ], res1b.headers[ 'last-modified' ] );
|
|
assert.equal( res1a.headers.etag, res1b.headers.etag );
|
|
|
|
const edit2 = await alice.edit( title2, { text: 'New Content', summary: 'poke page' } );
|
|
const res2 = await client.get( `/page/${ title2 }/history`, { filter: 'bot' } );
|
|
|
|
assert.equal( Date.parse( res1a.headers[ 'last-modified' ] ),
|
|
Date.parse( edit1.newtimestamp ) );
|
|
|
|
assert.equal( Date.parse( res2.headers[ 'last-modified' ] ),
|
|
Date.parse( edit2.newtimestamp ) );
|
|
|
|
assert.notEqual( res1a.headers.etag, res2.headers.etag );
|
|
} );
|
|
} );
|
|
|
|
describe( 'GET /page/{title}/history?{older_than|newer_than={id}}', () => {
|
|
it( 'Should get revisions newer than specified id for a page', async () => {
|
|
const { id } = edits.all[ 3 ];
|
|
const expected = edits.all.slice( 0, 3 );
|
|
const res = await client.get( `/page/${ title }/history`, { newer_than: id } );
|
|
|
|
assert.equal( res.status, 200 );
|
|
assert.match( res.headers[ 'content-type' ], /^application\/json/ );
|
|
assert.lengthOf( res.body.revisions, expected.length );
|
|
res.body.revisions
|
|
.forEach( ( rev, i ) => assert.deepNestedInclude( rev, expected[ i ] ) );
|
|
assert.include( res.body.latest, `page/${ title }/history` );
|
|
assert.include( res.body.older, `page/${ title }/history?older_than=${ expected[ expected.length - 1 ].id }` );
|
|
} );
|
|
|
|
it( 'Should get revisions older than specified id for a page', async () => {
|
|
const { id } = edits.all[ 3 ];
|
|
const expected = edits.all.slice( 4 );
|
|
const res = await client.get( `/page/${ title }/history`, { older_than: id } );
|
|
|
|
assert.equal( res.status, 200 );
|
|
assert.match( res.headers[ 'content-type' ], /^application\/json/ );
|
|
assert.lengthOf( res.body.revisions, expected.length );
|
|
res.body.revisions
|
|
.forEach( ( rev, i ) => assert.deepNestedInclude( rev, expected[ i ] ) );
|
|
assert.include( res.body.latest, `page/${ title }/history` );
|
|
assert.include( res.body.newer, `page/${ title }/history?newer_than=${ expected[ 0 ].id }` );
|
|
|
|
await assertGetStatus( res.body.newer );
|
|
} );
|
|
|
|
it( 'Should get revisions using both filter and newer_than|older_than parameters', async () => {
|
|
const { id } = edits.all[ 3 ];
|
|
const res = await client.get( `/page/${ title }/history`, { newer_than: id, filter: 'bot' } );
|
|
|
|
assert.equal( res.status, 200 );
|
|
assert.match( res.headers[ 'content-type' ], /^application\/json/ );
|
|
assert.lengthOf( res.body.revisions, 2 );
|
|
res.body.revisions
|
|
.forEach( ( rev, i ) => assert.deepNestedInclude( rev, edits.bot[ i ] ) );
|
|
assert.include( res.body.latest, `page/${ title }/history?filter=bot` );
|
|
assert.include( res.body.older, `page/${ title }/history?filter=bot&older_than=${ edits.bot[ 1 ].id }` );
|
|
|
|
await assertGetStatus( res.body.older );
|
|
} );
|
|
|
|
it( 'Should return 400 for revision id less than 0 ', async () => {
|
|
const res = await client.get( `/page/${ title }/history`, { newer_than: -1 } );
|
|
|
|
assert.equal( res.status, 400 );
|
|
} );
|
|
|
|
it( 'Should return 400 when using both newer_than and older_than', async () => {
|
|
const id1 = edits.all[ 8 ].id;
|
|
const id2 = edits.all[ 2 ].id;
|
|
const res = await client.get( `/page/${ title }/history`, { newer_than: id1, older_than: id2 } );
|
|
|
|
assert.equal( res.status, 400 );
|
|
} );
|
|
|
|
it( 'Should return 404 for a revision that does not exist for a specified page', async () => {
|
|
const anon2 = action.getAnon();
|
|
const title2 = utils.title( 'AnotherPage' );
|
|
const edit = await anon2.edit( title2, { text: 'Hello world' } );
|
|
const res = await client.get( `/page/${ title }/history`, { newer_than: edit.newrevid } );
|
|
|
|
assert.equal( res.status, 404 );
|
|
} );
|
|
} );
|
|
} );
|