Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/includes
History
Kevin Israel 19473fa625 Special:BookSources: Correct validation of ISBNs containing X 
PHP's "equal" (==) operator considers the integer 0 to be equal to
the string 'X', and when 'X' is converted to a number, it becomes 0.
Neither is desired here.

* Fail when an X is encountered while calculating the check digit.
  (X can only occur as the check digit of an ISBN-10.)
* Fixed the check digit comparisons by adding an explicit string cast.
* Used the "identical" operator to make it more obvious that no type
  juggling should take place during the comparisons.
* Added some test cases.
* Removed an outdated TODO.

Bug: 67021
Change-Id: I85f53c41f403a60340e9441757fe66b9764e623c
2014-10-01 19:14:39 +00:00
..
actions HistoryAction: Use correct classes for buttons 2014-09-29 13:45:09 -07:00
api Merge "User rights API: Abstract out some stuff about core's form into separate methods" 2014-10-01 13:33:10 +00:00
cache Fixed spacing 2014-09-29 20:46:19 +02:00
changes Fix undefined argument in OldChangesList 2014-09-09 16:05:53 +02:00
clientpool Cleanup some docs (includes/[a-d]) 2014-07-24 19:42:45 +02:00
composer
config Add MultiConfig for fallback logic 2014-09-17 15:55:04 -07:00
content Introduce ContentAlterParserOutput hook 2014-09-29 18:44:39 +00:00
context Avoid [GlobalTitleFail] spam 2014-09-26 19:58:02 +02:00
dao
db Fixed spacing 2014-09-29 20:46:19 +02:00
debug Fix malformed UTF-8 going to query profiler 2014-08-28 17:10:45 -07:00
deferred Add missing @return to function docs 2014-08-23 23:14:57 +02:00
diff i18n: Use native digits on 'difference-missing-revision' 2014-09-26 19:53:59 +00:00
exception Revert "Replace wfMsgReplaceArgs by RawMessage" 2014-09-29 17:41:56 +00:00
externalstore Clear the DBO_TRX flag for sanity in ExternalStore 2014-09-12 11:43:34 -07:00
filebackend Removed some b/c code from file backend 2014-09-12 00:54:24 -07:00
filerepo Fixed spacing 2014-09-29 20:46:19 +02:00
gallery Add missing </div> tag to packed-overlay galleries 2014-09-19 00:28:02 -03:00
htmlform Merge "Fix input regression affecting HTMLForms that use VForm" 2014-10-01 16:50:02 +00:00
installer Localisation updates from https://translatewiki.net. 2014-09-30 22:33:31 +02:00
interwiki Cleanup some docs (includes/[e-l]) 2014-07-24 19:43:03 +02:00
jobqueue Simplified getMaxLag() to use getLagTimes() 2014-09-26 00:21:27 +00:00
json Added missing JsonFormat::parse() RELEASE NOTES, fixed docs 2014-09-30 01:45:35 +00:00
libs CSSMin: Don't generate double rules for IE < 8 when embedding SVG files 2014-09-30 21:19:58 +00:00
logging Implement autocompletion for Performer field on Special:Log 2014-09-30 01:03:55 +00:00
mail Fixed spacing 2014-09-29 20:46:19 +02:00
media Do not read metadata from non-existing djvu image 2014-09-29 20:53:43 +02:00
normal Remove some PHP4 microtime() compat wrappers 2014-07-16 23:39:48 -04:00
objectcache Removed MultiWriteBagOStuff::replace 2014-09-12 11:13:06 -07:00
page Merge "Revert "Replace wfMsgReplaceArgs by RawMessage"" 2014-09-29 17:50:50 +00:00
pager Fixed spacing 2014-09-29 20:46:19 +02:00
parser Move addTrackingCategory from Parser to ParserOutput 2014-09-28 23:35:52 +00:00
password PasswordFactory::newFromPlaintext( null ) needs to work 2014-09-29 21:42:33 +00:00
poolcounter Correct variable names in @param to match method declarations 2014-08-13 21:48:28 +02:00
profiler Made the DB profiler use startAtomic() 2014-09-16 17:20:23 -07:00
rcfeed Use safe attribute accessor for RecentChange 2014-09-13 05:02:33 +00:00
resourceloader Fixed spacing 2014-09-29 20:46:19 +02:00
revisiondelete Split RevisionDeleteAbstracts.php to separate files 2014-08-20 19:08:33 +02:00
search Remove redundant $db->resultObject() calls 2014-09-19 20:35:55 +00:00
site Fixed spacing 2014-09-29 20:46:19 +02:00
skins Merge "Split SkinTemplate.php per-class" 2014-09-24 15:59:08 +00:00
specialpage Fix case of SpecialAllPages/SpecialAllMessages in SpecialPageFactory 2014-09-28 00:04:12 +00:00
specials Special:BookSources: Correct validation of ISBNs containing X 2014-10-01 19:14:39 +00:00
templates Allow logged-in users to view and use the login form again 2014-09-22 14:02:00 +00:00
title Don't include images/categories when behind a local interwiki prefix 2014-08-01 18:20:51 +10:00
upload Fix version comments in thumbnail prerendering code 2014-09-30 14:20:11 +02:00
utils Fixed UID comment 2014-08-27 16:19:11 -07:00
.htaccess
AjaxDispatcher.php AjaxDispatcher: Use Config instead of globals 2014-08-25 19:20:30 -07:00
AjaxResponse.php AjaxDispatcher: Use Config instead of globals 2014-08-25 19:20:30 -07:00
AuthPlugin.php
AutoLoader.php Set site logo in mediawiki.skinning.interface module instead of inline styles 2014-09-26 21:09:22 +00:00
Autopromote.php
Block.php Couple of type hints for Block 2014-09-25 15:11:39 +00:00
Category.php Add missing @param to function docs 2014-08-14 20:22:52 +02:00
CategoryFinder.php CategoryFinder: give parent category tree an accessor 2014-09-05 11:57:42 -07:00
CategoryViewer.php Fix for Ia9baaf0b: Make previously public variables public again 2014-08-29 23:01:53 +02:00
ChangeTags.php Special:Contributions: Use mediawiki.ui 2014-09-29 11:42:25 -07:00
Collation.php Cleanup some docs (includes/*.php) 2014-07-24 19:42:24 +02:00
Cookie.php Fixed spacing 2014-08-04 11:51:22 +02:00
DefaultSettings.php Fix version comments in thumbnail prerendering code 2014-09-30 14:20:11 +02:00
Defines.php Add JSONContent and handler from EventLogging 2014-08-08 23:31:26 +00:00
DeprecatedGlobal.php
EditPage.php Minor code cleanup and a doc type cleanup 2014-09-24 22:13:19 -04:00
Export.php Remove XmlDumpWriter::schemaVersion (deprecated 1.20) 2014-09-26 14:34:36 -07:00
Fallback.php Cleanup some docs (includes/*.php) 2014-07-24 19:42:24 +02:00
Feed.php Fix for Ia9baaf0b: Make previously public variables public again 2014-08-29 23:01:53 +02:00
FeedUtils.php Cleanup some docs (includes/*.php) 2014-07-24 19:42:24 +02:00
FileDeleteForm.php
ForkController.php Add missing @param to function docs 2014-08-14 20:22:52 +02:00
FormOptions.php Add missing @param to function docs 2014-08-14 20:22:52 +02:00
GitInfo.php Cleanup some docs (includes/*.php) 2014-07-24 19:42:24 +02:00
GlobalFunctions.php Revert "Replace wfMsgReplaceArgs by RawMessage" 2014-09-29 17:41:56 +00:00
HistoryBlob.php Fix for Ia9baaf0b: Make previously public variables public again 2014-08-29 23:01:53 +02:00
Hooks.php Cleanup some docs (includes/*.php) 2014-07-24 19:42:24 +02:00
Html.php Html: Don't accept paths relative to skins/common/images/ in infoBox() 2014-09-08 21:03:23 +02:00
HtmlFormatter.php Cleanup some docs (includes/*.php) 2014-07-24 19:42:24 +02:00
HttpFunctions.php CurlHttpRequest: Check library version, not CURLOPT_REDIR_PROTOCOLS 2014-09-08 18:22:50 -04:00
Import.php Fix for Ia9baaf0b: Make previously public variables public again 2014-08-29 23:01:53 +02:00
Licenses.php Cleanup some docs (includes/*.php) 2014-07-24 19:42:24 +02:00
limit.sh
Linker.php Make linker warning useful 2014-09-23 09:13:33 +02:00
LinkFilter.php
MagicWord.php Add missing @return to function docs 2014-08-23 23:14:57 +02:00
MediaWiki.php Avoid [GlobalTitleFail] spam 2014-09-26 19:58:02 +02:00
MediaWikiVersionFetcher.php
Message.php Introduce Message::plaintextParam 2014-09-30 12:51:29 -07:00
MessageBlobStore.php MessageBlobStore: Use Config instead of globals 2014-08-25 11:35:36 +00:00
mime.info Make image/vnd.microsoft.icon be an alias for image/x-icon mime type. 2014-09-13 13:23:55 -03:00
mime.types Make image/vnd.microsoft.icon be an alias for image/x-icon mime type. 2014-09-13 13:23:55 -03:00
MimeMagic.php MimeMagic: Use Config instead of globals 2014-09-06 11:50:05 +00:00
MovePage.php Fixed spacing 2014-09-29 20:46:19 +02:00
MWNamespace.php Rename MWNamespace, MWDebug and MWTidy files to match their class 2014-07-15 20:59:39 +00:00
MWTimestamp.php Remove unmatched @param 2014-08-16 22:50:02 +02:00
OutputHandler.php
OutputPage.php Fixed spacing 2014-09-29 20:46:19 +02:00
PathRouter.php
PHPVersionError.php Bump 1.25 2014-09-19 14:03:18 -07:00
Preferences.php Remove Preferences::trySetUserEmail (deprecated 1.20) 2014-09-26 14:38:01 -07:00
PrefixSearch.php Fixed spacing 2014-09-29 20:46:19 +02:00
ProtectionForm.php Merge "Don't break existing expiry time of "infinity" when modifying protection" 2014-09-18 02:27:56 +00:00
Revision.php Don't clobber revision size of 0 2014-09-29 10:46:18 -04:00
RevisionList.php
Sanitizer.php SECURITY: Enhance CSS filtering in SVG files 2014-09-24 21:06:54 +02:00
Setup.php Merge "Add API output skin" 2014-09-24 15:20:41 +00:00
SiteConfiguration.php When getting remote config, if the caller requested a single setting without an array, always do that 2014-09-06 22:44:07 +01:00
SiteStats.php Cleanup some docs (includes/*.php) 2014-07-24 19:42:24 +02:00
SquidPurgeClient.php Cleanup some docs (includes/*.php) 2014-07-24 19:42:24 +02:00
StatCounter.php StatCounter: Use Config instead of globals 2014-09-09 17:18:00 -07:00
Status.php Minor code cleanup and a doc type cleanup 2014-09-24 22:13:19 -04:00
StreamFile.php
StubObject.php Fix visibility in SkinFallback and StubObject 2014-08-12 01:06:49 +00:00
tidy.conf
TimestampException.php
Title.php Move non-user specific things from Title::isValidMoveOperation() to MovePage 2014-09-19 20:11:59 +00:00
TitleArray.php
TitleArrayFromResult.php
User.php PasswordFactory::newFromPlaintext( null ) needs to work 2014-09-29 21:42:33 +00:00
UserArray.php
UserArrayFromResult.php Cleanup some docs (includes/*.php) 2014-07-24 19:42:24 +02:00
UserRightsProxy.php Fix userrights-interwiki when the 'user' table is shared 2014-08-10 12:01:25 +00:00
WatchedItem.php Fixed spacing 2014-08-27 18:31:50 +02:00
WebRequest.php Implement FauxRequest::getRequestURL() - needed for MF tests 2014-09-25 14:41:51 -07:00
WebResponse.php Docs: compatability -> compatibility 2014-08-13 19:39:07 +02:00
WebStart.php Remove $wgTitle from WebStart forever 2014-09-22 14:52:36 -07:00
WikiMap.php
Xml.php Remove Xml::namespaceSelector() (deprecated since 1.19) 2014-08-19 23:34:21 -07:00
ZhConversion.php