Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/includes
History
Tacsipacsi 1f73b5d5e4 feeds: Fix str_replace() deprecation warnings on PHP 8 
Why:

Both AtomFeed::formatTime() and RSSFeed::formatTime() short-circuit with
null if the input is falsy. This caused deprecation warnings down the
line, as the return value was later fed into str_replace(), which raises
a deprecation warning on PHP 8 if it gets null.

It also caused unexpected output on all PHP versions: the Mustache
templates for both Atom and RSS conditionally emit the date elements
(<updated> in Atom, <pubDate> in RSS), but this conditional output is
skipped only if the variable is null, not when it’s an empty string –
which is exactly what the XML encoding returned on all PHP versions.

What:

Introduce a new method, xmlEncodeNullable(), which properly handles null
values, and returns them as-is, without trying to encode them. This:

- Avoids the deprecation warnings on PHP 8, since str_replace() is no
  longer called.
- Makes the conditional output work: the <updated>/<pubDate> elements
  are no longer output if no date is available.
  - This makes the RSS output spec-compliant, as no garbage is output
    anymore. The RSS <pubDate> is optional [1].
  - It doesn’t make the Atom output entirely spec-compliant, as Atom
    requires <updated> to be present [2], but the removal of garbage
    (it was a single letter Z) should still increase compatibility.

[1] https://www.rssboard.org/rss-specification#hrelementsOfLtitemgt
[2] https://validator.w3.org/feed/docs/atom.html#requiredEntryElements

Bug: T385332
Change-Id: Iafd89c0d61baecd7c68f62b2a0764cc78cf25069
(cherry picked from commit 60c57b0fd5303e9627b7684ebac4cd369c1fe7a6)
2025-02-18 21:44:56 +00:00
..
actions Use namespaced classes 2024-10-21 20:41:20 +02:00
api Localisation updates from https://translatewiki.net. 2025-02-18 06:32:08 +01:00
auth ButtonAuthenticationRequest: Add AllowDynamicProperties directive 2024-12-12 21:45:31 +00:00
block Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
cache Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
Category Remove meaningless @var documentation from constants 2024-10-09 09:33:12 +02:00
changetags Merge "Use explicit nullable type on parameter arguments" 2024-10-16 23:10:14 +00:00
collation Use namespaced classes 2024-10-21 20:41:20 +02:00
CommentFormatter Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
CommentStore Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
composer Remove MediaWikiVersionFetcher 2024-10-14 12:00:08 +00:00
config
content Merge "Use explicit nullable type on parameter arguments" 2024-10-16 23:10:14 +00:00
context Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
dao
db Merge "CloneDatabase: Remove debug logging" 2024-10-17 23:38:11 +00:00
debug Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
deferred Merge "rdbms: clear replica snapshots in (begin|commit|rollback)PrimaryChanges()" 2024-10-22 15:25:44 +00:00
diff Use namespaced classes 2024-10-21 20:41:20 +02:00
edit parser: Gracefully handle invalid ParsoidRenderID keys 2025-02-04 14:54:31 +00:00
editpage Merge "TemplatesOnThisPage: Do not show non-functional link for special pages" 2024-10-18 00:14:06 +00:00
exception MWExceptionHandler: Add error suppression to constant( 'E_STRICT' ) 2025-01-21 22:31:11 +00:00
export Use namespaced classes 2024-10-21 20:41:20 +02:00
ExternalLinks
externalstore Use namespaced classes 2024-10-21 20:41:20 +02:00
Feed feeds: Fix str_replace() deprecation warnings on PHP 8 2025-02-18 21:44:56 +00:00
filebackend filebackend: Check for old alias in FileBackendMultiWrite 2024-10-22 01:32:54 +02:00
filerepo Fix img_auth message logic 2024-11-14 01:05:30 +00:00
gallery Use namespaced classes 2024-10-21 20:41:20 +02:00
historyblob
Hook
HookContainer WhatLinksHere: Allow extensible filters 2024-10-21 14:27:53 +05:30
Html
htmlform htmlform: Allow MessageParam on HTMLForm::addButton for label-message 2024-10-26 23:12:51 +00:00
http Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
import Use namespaced classes 2024-10-21 20:41:20 +02:00
installer Localisation updates from https://translatewiki.net. 2025-02-18 06:32:08 +01:00
interwiki Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
jobqueue RefreshLinksJob: Don't retry job if "Revision x is not current" is returned 2024-11-19 16:08:11 +00:00
json Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
language language: Use fallback chain to create NumberFormatter 2025-02-17 21:24:24 +00:00
languages Add Central Kanuri (knc), deprecate Kanuri (kr) 2024-10-20 19:18:46 +00:00
libs Localisation updates from https://translatewiki.net. 2025-01-28 06:31:37 +01:00
linkeddata
linker Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
logging Use namespaced classes 2024-10-21 20:41:20 +02:00
mail Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
media FormatMetadata: Prevent running preg_match() on null 2025-01-28 12:05:59 +00:00
Message Make Message and MessageValue compatible 2024-10-19 15:00:07 +02:00
Navigation
objectcache Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
Output Skin: [BREAKING CHANGE] Remove support for rendering outside body element 2024-10-30 15:18:51 +00:00
OutputTransform Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
page Use namespaced classes 2024-10-21 20:41:20 +02:00
pager ContributionsPager: Fix getTemplateParams() parameter 2024-10-25 13:52:47 +00:00
ParamValidator/TypeDef
parser ParserOutput::getExternalLinks(): Deprecate use of the internal array reference 2024-10-22 16:33:27 -04:00
password Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
Permissions Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
poolcounter objectcache: Move RedisConnRef.php to /libs/objectcache/ 2024-11-07 08:40:54 +00:00
preferences MultiUsernameFilter: Don't try to split ids if they're not a string 2025-01-30 15:26:00 +00:00
profiler Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
recentchanges objectcache: Move RedisConnRef.php to /libs/objectcache/ 2024-11-07 08:40:54 +00:00
registration Remove meaningless @var documentation from constants 2024-10-09 09:33:12 +02:00
RenameUser
Request WebRequest: Add PHP return type hint for getRawVal 2024-10-10 14:01:26 +00:00
ResourceLoader resourceloader: Fix hash computation for virtual files with versionFilePath 2025-01-29 21:26:20 +00:00
Rest Localisation updates from https://translatewiki.net. 2025-02-18 06:32:08 +01:00
Revision Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
revisiondelete Use namespaced classes 2024-10-21 20:41:20 +02:00
revisionlist
search Use namespaced classes 2024-10-21 20:41:20 +02:00
session session: Do not set session.use_trans_sid 2025-01-06 22:12:05 +00:00
Settings Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
shell FileRepo: Add support for the new Shellbox large file feature 2024-10-29 02:50:07 +00:00
site
SiteStats
skins Merge "Hard deprecate soft deprecated skin methods" into REL1_43 2024-11-13 00:27:38 +00:00
sparql
specialpage specialpage: Improve handling of invalid lang codes on login/signup 2025-01-29 16:04:57 +00:00
specials Reject temporary account usernames on Special:PasswordReset 2024-11-18 14:35:28 +00:00
Status Make Message and MessageValue compatible 2024-10-19 15:00:07 +02:00
Storage Merge "Use explicit nullable type on parameter arguments" 2024-10-16 23:10:14 +00:00
StubObject
templates img_auth: Output lang and dir in HTTP and HTML on error message 2024-10-29 15:18:52 +00:00
tidy
title Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
upload Use namespaced classes 2024-10-21 20:41:20 +02:00
user CentralIdLookup: delete deprecated factoryNonLocal() method 2024-11-04 22:43:01 +00:00
utils Remove CryptHKDF and MWCryptHKDF 2024-11-10 22:49:37 -05:00
watchlist Merge "Use explicit nullable type on parameter arguments" 2024-10-16 23:10:14 +00:00
widget
WikiMap Merge "Fix typos in WikiMap doc comments" 2024-10-10 18:30:09 +00:00
xml Use explicit nullable type on parameter arguments 2024-10-16 20:58:33 +02:00
.htaccess
AutoLoader.php AutoLoader: Use require_once rather than require 2024-10-24 01:36:18 +00:00
BootstrapHelperFunctions.php
config-schema.php DnsBlacklistUrls: Remove sorbs.net 2025-01-06 22:57:01 +00:00
DefaultSettings.php
Defines.php Prep 1.43.0 2024-12-20 17:36:14 +03:00
DevelopmentSettings.php Tests: Split log files by parallel grouping 2024-10-10 12:47:00 +00:00
EntryPointEnvironment.php
GlobalFunctions.php Deprecate wfArrayDiff2() 2024-11-04 19:34:41 +00:00
MainConfigNames.php Remove CryptHKDF and MWCryptHKDF 2024-11-10 22:49:37 -05:00
MainConfigSchema.php DnsBlacklistUrls: Remove sorbs.net 2025-01-06 22:57:01 +00:00
MediaWiki.php
MediaWikiEntryPoint.php
MediaWikiServices.php Remove CryptHKDF and MWCryptHKDF 2024-11-10 22:49:37 -05:00
PHPVersionCheck.php Bump PHPVersionCheck & composer expected PHP versions to 8.1.0 2024-10-25 19:56:22 -04:00
ServiceWiring.php Remove CryptHKDF and MWCryptHKDF 2024-11-10 22:49:37 -05:00
Setup.php Use namespaced classes 2024-10-21 20:41:20 +02:00
SetupDynamicConfig.php
WebStart.php