AuthManager is coming, which will make it easier to add alternative methods of authentication. But in order to do that, we need to finally get around to ripping the password-related bits out of the User class. The password expiration handling isn't used anywhere in core or extensions in Gerrit beyond testing for expired passwords on login and resetting the expiry date on password change. Those bits have been inlined and the functions removed; AuthManager will allow each "authentication provider" to handle its own password expiration. The methods for fetching passwords, including the fact that mPassword and other fields are public, has also been removed. This is already broken in combination with basically any extension that messes with authentication, and the major use outside of that was in creating system users like MassMessage's "MediaWiki message delivery" user. Password setting methods are silently deprecated, since most of the replacements won't be available until AuthManager. But uses in unit testing can be replaced with TestUser::setPasswordForUser() immediately. User::randomPassword() and User::getPasswordFactory() don't really belong in User either. For the former a new PasswordFactory method has been created, while the latter should just be replaced by the two lines to create a PasswordFactory via its constructor. Bug: T47716 Change-Id: I2c736ad72d946fa9b859e6cd335fa58aececc0d5
158 lines
3.8 KiB
PHP
158 lines
3.8 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Wraps the user object, so we can also retain full access to properties
|
|
* like password if we log in via the API.
|
|
*/
|
|
class TestUser {
|
|
/**
|
|
* @deprecated Since 1.25. Use TestUser::getUser()->getName()
|
|
* @private
|
|
* @var string
|
|
*/
|
|
public $username;
|
|
|
|
/**
|
|
* @deprecated Since 1.25. Use TestUser::getPassword()
|
|
* @private
|
|
* @var string
|
|
*/
|
|
public $password;
|
|
|
|
/**
|
|
* @deprecated Since 1.25. Use TestUser::getUser()
|
|
* @private
|
|
* @var User
|
|
*/
|
|
public $user;
|
|
|
|
private function assertNotReal() {
|
|
global $wgDBprefix;
|
|
if ( $wgDBprefix !== MediaWikiTestCase::DB_PREFIX &&
|
|
$wgDBprefix !== MediaWikiTestCase::ORA_DB_PREFIX
|
|
) {
|
|
throw new MWException( "Can't create user on real database" );
|
|
}
|
|
}
|
|
|
|
public function __construct( $username, $realname = 'Real Name',
|
|
$email = 'sample@example.com', $groups = array()
|
|
) {
|
|
$this->assertNotReal();
|
|
|
|
$this->username = $username;
|
|
$this->password = 'TestUser';
|
|
|
|
$this->user = User::newFromName( $this->username );
|
|
$this->user->load();
|
|
|
|
// In an ideal world we'd have a new wiki (or mock data store) for every single test.
|
|
// But for now, we just need to create or update the user with the desired properties.
|
|
// we particularly need the new password, since we just generated it randomly.
|
|
// In core MediaWiki, there is no functionality to delete users, so this is the best we can do.
|
|
if ( !$this->user->isLoggedIn() ) {
|
|
// create the user
|
|
$this->user = User::createNew(
|
|
$this->username, array(
|
|
"email" => $email,
|
|
"real_name" => $realname
|
|
)
|
|
);
|
|
|
|
if ( !$this->user ) {
|
|
throw new MWException( "Error creating TestUser " . $username );
|
|
}
|
|
}
|
|
|
|
// Update the user to use the password and other details
|
|
$this->setPassword( $this->password );
|
|
$change = $this->setEmail( $email ) ||
|
|
$this->setRealName( $realname );
|
|
|
|
// Adjust groups by adding any missing ones and removing any extras
|
|
$currentGroups = $this->user->getGroups();
|
|
foreach ( array_diff( $groups, $currentGroups ) as $group ) {
|
|
$this->user->addGroup( $group );
|
|
}
|
|
foreach ( array_diff( $currentGroups, $groups ) as $group ) {
|
|
$this->user->removeGroup( $group );
|
|
}
|
|
if ( $change ) {
|
|
$this->user->saveSettings();
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @param string $realname
|
|
* @return bool
|
|
*/
|
|
private function setRealName( $realname ) {
|
|
if ( $this->user->getRealName() !== $realname ) {
|
|
$this->user->setRealName( $realname );
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* @param string $email
|
|
* @return bool
|
|
*/
|
|
private function setEmail( $email ) {
|
|
if ( $this->user->getEmail() !== $email ) {
|
|
$this->user->setEmail( $email );
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* @param string $password
|
|
*/
|
|
private function setPassword( $password ) {
|
|
self::setPasswordForUser( $this->user, $password );
|
|
}
|
|
|
|
/**
|
|
* Set the password on a testing user
|
|
*
|
|
* This assumes we're still using the generic AuthManager config from
|
|
* PHPUnitMaintClass::finalSetup(), and just sets the password in the
|
|
* database directly.
|
|
* @param User $user
|
|
* @param string $password
|
|
*/
|
|
public static function setPasswordForUser( User $user, $password ) {
|
|
if ( !$user->getId() ) {
|
|
throw new MWException( "Passed User has not been added to the database yet!" );
|
|
}
|
|
|
|
$passwordFactory = new PasswordFactory();
|
|
$passwordFactory->init( RequestContext::getMain()->getConfig() );
|
|
// A is unsalted MD5 (thus fast) ... we don't care about security here, this is test only
|
|
$passwordFactory->setDefaultType( 'A' );
|
|
$pwhash = $passwordFactory->newFromPlaintext( $password );
|
|
wfGetDB( DB_MASTER )->update(
|
|
'user',
|
|
array( 'user_password' => $pwhash->toString() ),
|
|
array( 'user_id' => $user->getId() ),
|
|
__METHOD__
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @return User
|
|
*/
|
|
public function getUser() {
|
|
return $this->user;
|
|
}
|
|
|
|
/**
|
|
* @return string
|
|
*/
|
|
public function getPassword() {
|
|
return $this->password;
|
|
}
|
|
}
|