Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/includes/block
History
Paladox 0b4c4402e8 Fix infinite recursion with wgAutopromote when using getBlock within checkCondition 
The problem was that when using $user->getBlock
within checkCondition (APCOND_BLOCKED) caused a infinite
recursion as calling getBlock eventually leads back to checkCondition.

The fix here is to stop using userHasRight as that is the cause of the recursion.

This also fixes testGetUserAutopromoteBlockedDoesNotRecurse test so it
shouldn't fail.

Bug: T270145
Change-Id: Ic751eba70730de286bbd55772bd7562459fb30b4
2020-12-17 19:57:10 +00:00
..
Hook Document hook names in hook interfaces. 2020-09-27 12:03:12 +02:00
Restriction PageRestrictions: Remove unreachable logic 2020-12-05 05:25:08 +01:00
AbstractBlock.php Remove deprecated AbstractBlock methods 2020-10-09 19:35:41 +00:00
BlockErrorFormatter.php Inject UserFactory into BlockErrorFormatter 2020-10-13 20:09:52 +00:00
BlockManager.php Fix infinite recursion with wgAutopromote when using getBlock within checkCondition 2020-12-17 19:57:10 +00:00
BlockPermissionChecker.php Improve class property documentation 2020-10-30 10:38:58 +01:00
BlockPermissionCheckerFactory.php Move SpecialBlock::canBlockEmail to BlockPermissionChecker 2020-09-19 17:00:47 +00:00
BlockRestrictionStore.php Use const for BlockRestrictionStore::$types 2020-11-21 00:57:04 +01:00
BlockUser.php Do not call SpecialBlock from BlockUser 2020-10-04 23:20:06 +02:00
BlockUserFactory.php Introduce backend class for blocking users 2020-09-22 14:14:01 +01:00
BlockUtils.php Move AbstractBlock::parseTarget to BlockUtils 2020-10-07 18:52:11 +00:00
CompositeBlock.php Move $isHardblock property up to AbstractBlock from DatabaseBlock 2020-10-07 13:23:12 +01:00
DatabaseBlock.php Merge "Update a lot of unspecific "array" types in PHPDocs" 2020-11-13 21:48:24 +00:00
DatabaseBlockStore.php Mark CONSTRUCTOR_OPTIONS as internal 2020-08-21 00:18:45 -04:00
SystemBlock.php Remove blocker dependency for System and Composite blocks 2019-10-31 07:45:07 -04:00
UnblockUser.php Document list of change tags as string[] 2020-11-20 14:12:54 +01:00
UnblockUserFactory.php Document list of change tags as string[] 2020-11-20 14:12:54 +01:00
UserBlockCommandFactory.php Document list of change tags as string[] 2020-11-20 14:12:54 +01:00