mirror of
https://github.com/BelfrySCAD/BOSL2.git
synced 2024-12-29 16:29:40 +00:00
bugfix
This commit is contained in:
parent
a8442c74fb
commit
9cf6a0b3a8
2 changed files with 7 additions and 4 deletions
|
@ -692,9 +692,12 @@ module screw(spec, head, drive, thread, drive_size,
|
||||||
// set counterbore to true and it will be sized to match the head height. The counterbore will extend 0.01 above the TOP of the hole mask to ensure no
|
// set counterbore to true and it will be sized to match the head height. The counterbore will extend 0.01 above the TOP of the hole mask to ensure no
|
||||||
// problems with differences. Note that the counterbore defaults to true for non-flathead screws. If you want the actual head shape to appear, set counterbore to zero.
|
// problems with differences. Note that the counterbore defaults to true for non-flathead screws. If you want the actual head shape to appear, set counterbore to zero.
|
||||||
// .
|
// .
|
||||||
|
// For 3d printing circular holes can be problematic. One solution is to use octagonal holes, setting $fn=8. Another option is to use a teardrop hole, which
|
||||||
|
// can be accomplished by setting `teardrop=true`. The point of the teardrop will point in the Y direction (BACK) so you will need to ensure that you orient it
|
||||||
|
// correctly in your final model.
|
||||||
|
// .
|
||||||
// Anchoring for screw_hole() is the same as anchoring for {{screw()}}, with all the same anchor types and named anchors. If you specify a counterbore it is treated as
|
// Anchoring for screw_hole() is the same as anchoring for {{screw()}}, with all the same anchor types and named anchors. If you specify a counterbore it is treated as
|
||||||
// the "head", or in the case of flat heads, it becomes part of the head. If you make a teardrop hole the point is ignored for purposes of anchoring.
|
// the "head", or in the case of flat heads, it becomes part of the head. If you make a teardrop hole the point is ignored for purposes of anchoring.
|
||||||
// The point of the teardrop is in the Y direction.
|
|
||||||
// Arguments:
|
// Arguments:
|
||||||
// spec = screw specification, e.g. "M5x1" or "#8-32". See [screw naming](#subsection-screw-naming). This can also be a screw specification structure of the form produced by {{screw_info()}}.
|
// spec = screw specification, e.g. "M5x1" or "#8-32". See [screw naming](#subsection-screw-naming). This can also be a screw specification structure of the form produced by {{screw_info()}}.
|
||||||
// head = head type. See [screw heads](#subsection-screw-heads) Default: none
|
// head = head type. See [screw heads](#subsection-screw-heads) Default: none
|
||||||
|
|
|
@ -1528,7 +1528,7 @@ module path_sweep(shape, path, method="incremental", normal, closed, twist=0, tw
|
||||||
|
|
||||||
if (profiles){
|
if (profiles){
|
||||||
assert(in_list(atype, _ANCHOR_TYPES), "Anchor type must be \"hull\" or \"intersect\"");
|
assert(in_list(atype, _ANCHOR_TYPES), "Anchor type must be \"hull\" or \"intersect\"");
|
||||||
tran = path_sweep(shape, path, method, normal, closed, twist, twist_by_length,
|
tran = path_sweep(shape, path, method, normal, closed, twist, twist_by_length, scale,
|
||||||
symmetry, last_normal, tangent, uniform, relaxed,transforms=true);
|
symmetry, last_normal, tangent, uniform, relaxed,transforms=true);
|
||||||
rshape = is_path(shape) ? [path3d(shape)]
|
rshape = is_path(shape) ? [path3d(shape)]
|
||||||
: [for(s=shape) path3d(s)];
|
: [for(s=shape) path3d(s)];
|
||||||
|
@ -1546,8 +1546,8 @@ module path_sweep(shape, path, method="incremental", normal, closed, twist=0, tw
|
||||||
function path_sweep(shape, path, method="incremental", normal, closed, twist=0, twist_by_length=true, scale=1,
|
function path_sweep(shape, path, method="incremental", normal, closed, twist=0, twist_by_length=true, scale=1,
|
||||||
symmetry=1, last_normal, tangent, uniform=true, relaxed=false, caps, style="min_edge", transforms=false,
|
symmetry=1, last_normal, tangent, uniform=true, relaxed=false, caps, style="min_edge", transforms=false,
|
||||||
anchor="origin",cp="centroid",spin=0, orient=UP, atype="hull") =
|
anchor="origin",cp="centroid",spin=0, orient=UP, atype="hull") =
|
||||||
is_1region(path) ? path_sweep(shape=shape,path=path[0], method=method, normal=normal, closed=default(closed,true), scale=scale,
|
is_1region(path) ? path_sweep(shape=shape,path=path[0], method=method, normal=normal, closed=default(closed,true),
|
||||||
twist=twist, twist_by_length=twist_by_length, symmetry=symmetry, last_normal=last_normal,
|
twist=twist, scale=scale, twist_by_length=twist_by_length, symmetry=symmetry, last_normal=last_normal,
|
||||||
tangent=tangent, uniform=uniform, relaxed=relaxed, caps=caps, style=style, transforms=transforms,
|
tangent=tangent, uniform=uniform, relaxed=relaxed, caps=caps, style=style, transforms=transforms,
|
||||||
anchor=anchor, cp=cp, spin=spin, orient=orient, atype=atype) :
|
anchor=anchor, cp=cp, spin=spin, orient=orient, atype=atype) :
|
||||||
let(closed=default(closed,false))
|
let(closed=default(closed,false))
|
||||||
|
|
Loading…
Reference in a new issue