x/busybox
1
0
Fork 0
mirror of https://git.busybox.net/busybox synced 2026-02-22 10:12:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
17982 commits 40 branches 158 tags 38 MiB
Commit graph

17982 commits

This branch
This branch
All branches
Author SHA1 Message Date
Valentin Lab
41f677ec5d crond: reap orphaned grandchildren to prevent zombie buildup 
If a cron job launches a background task, e.g. `sh -c "sleep 5 &"`,
the shell exits immediately and the `sleep` process is re-parented to
PID 1.  When BusyBox `crond` itself happens to be PID 1 (common in a
minimal container), those orphans become direct children of `crond`.
Because `crond` only calls waitpid() for the PIDs it explicitly tracks,
these processes remain forever in Z state and the container slowly
fills with zombies.

Add a small `while (waitpid(-1, NULL, WNOHANG) > 0)` sweep at the end
of check_completions() so any stray children are reaped.  When `crond`
is not PID 1 the loop returns -ECHILD immediately, so behaviour and
overhead on a normal system are unchanged.

Size impact: +12 bytes on x86-64 (gcc 13.3.0 -Os, static)

Signed-off-by: Valentin Lab <valentin.lab@kalysto.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-30 19:49:23 +02:00
Ladislav Michl
427f808732 date: return failure exit code on clock_settime error 
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-30 19:44:39 +02:00
Denys Vlasenko
65deb9f7dd sha3sum: add -aBITS tests 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-30 19:11:26 +02:00
Andy Knowles
dcbb69e0a5 sha384sum: new applet 
function                                             old     new   delta
sha512384_end                                          -     198    +198
packed_usage                                       35021   35134    +113
init384                                                -      80     +80
sha384_begin                                           -      19     +19
sha384_end                                             -      10     +10
applet_names                                        2823    2833     +10
md5_sha1_sum_main                                    501     507      +6
sha3_end                                              54      59      +5
applet_main                                         1628    1632      +4
show_usage_if_dash_dash_help                          79      72      -7
hash_file                                            358     344     -14
sha512_end                                           197      10    -187
------------------------------------------------------------------------------
(add/remove: 4/0 grow/shrink: 5/3 up/down: 445/-208)          Total: 237 bytes

Signed-off-by: Andy Knowles <aknowles@galleonec.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-30 18:39:46 +02:00
Denys Vlasenko
628a7b2f47 telnetd: improve --help 
function                                             old     new   delta
packed_usage                                       34996   35021     +25

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-27 14:24:23 +02:00
Denys Vlasenko
e022ff88d1 libbb: SHA-NI - document that unpckhpd also works, no code changes 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-22 16:43:22 +02:00
Denys Vlasenko
ed22c5bd4a libbb: SHA-NI code shrink 
function                                             old     new   delta
sha256_process_block64_shaNI                         673     657     -16

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-22 00:12:54 +02:00
Denys Vlasenko
d23ad55904 libbb: change define names in SHA-NI code to match kernel source more closely 
No code changes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-21 08:45:02 +02:00
Denys Vlasenko
77a49a61b2 libbb/yescrypt: de-unroll salsa20() 
function                                             old     new   delta
salsa20                                              760     296    -464

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-20 08:42:51 +02:00
Denys Vlasenko
c6b9e76373 libbb: crypt_make_pw_salt(): fix yescrypt's random salt last char 
function                                             old     new   delta
crypt_make_pw_salt                                   128     146     +18

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-19 18:42:32 +02:00
Denys Vlasenko
6979467a62 cryptpw: fix detection of crypt algo from salt (was broken if default isn't DES) 
The symptom is: "cryptpw ... implicit" testsuite tests were failing
if CONFIG_FEATURE_DEFAULT_PASSWD_ALGO is not "des".

function                                             old     new   delta
cryptpw_main                                         223     283     +60
pw_encrypt                                           974     975      +1
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/0 up/down: 61/0)               Total: 61 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-19 18:20:01 +02:00
Denys Vlasenko
51b45ce28a libbb/yescrypt: code shrink 
function                                             old     new   delta
blockmix_xor_save                                   1169     708    -461

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-19 17:20:35 +02:00
Denys Vlasenko
94591a1030 bootchartd: check the result of opendir("/proc") 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-19 02:26:20 +02:00
Denys Vlasenko
ee2ef17cc7 tftp: use bb_error_msg instead of info_msg for a debug message 
This is the only use of bb_info_msg in tftp.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-18 10:42:09 +02:00
Denys Vlasenko
27e1fc679e ntpd: replace two bb_info_msg's with bb_error_msg 
All other messages are printed via bb_error_msg in this applet.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-18 10:34:17 +02:00
Denys Vlasenko
504f44436f sulogin: set ^C to SIG_DFL before execing the shell 
function                                             old     new   delta
sulogin_main                                         331     340      +9

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-18 07:29:24 +02:00
Denys Vlasenko
d2ef2c75c5 password applets: update help text 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-18 07:28:32 +02:00
Denys Vlasenko
dde90f1d47 libbb.h: increase MAX_PW_SALT_LEN 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-17 17:34:14 +02:00
Denys Vlasenko
b823735b7e libbb/yescrypt: actually, largest allowed salt is 86 chars, support that 
function                                             old     new   delta
yescrypt_r                                           767     756     -11

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-17 17:01:40 +02:00
Denys Vlasenko
abe0b45cd7 libbb/yescrypt: code shrink 
function                                             old     new   delta
blockmix_xor                                        1177     702    -475

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-15 05:47:18 +02:00
Denys Vlasenko
e62bfbcaed libbb/yescrypt: code shrink 
function                                             old     new   delta
salsa20                                              684     650     -34
blockmix_salsa8                                      198     144     -54
blockmix                                             762     565    -197
blockmix_xor                                        1322    1028    -294
blockmix_xor_save                                   1499    1103    -396
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/5 up/down: 0/-975)           Total: -975 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-11 08:58:07 +02:00
Denys Vlasenko
95f169f3bb libbb/yescrypt: code shrink 
function                                             old     new   delta
static.yescrypt_kdf32_body                           847     823     -24
yescrypt_r                                           805     767     -38
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-62)             Total: -62 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-09 10:38:11 +02:00
Denys Vlasenko
11d4c08d75 libbb/bitops.c: add inlining comment 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-09 08:21:47 +02:00
Denys Vlasenko
c305c81c94 libbb: introduce and use block-XOR functions 
On x86_64, they can be done in 16-byte blocks

64-bit:
function                                             old     new   delta
xorbuf_3                                               -      84     +84
xorbuf64_3_aligned64                                   -      58     +58
smix1                                                687     712     +25
xwrite_encrypted                                     520     534     +14
xorbuf16_aligned_long                                  -      13     +13
tls_xread_record                                     733     742      +9
xorbuf                                                21      13      -8
xorbuf_aligned_AES_BLOCK_SIZE                         15       -     -15
blockmix                                             814     762     -52
blockmix_salsa8                                      317     198    -119
blockmix_xor_save                                   1620    1499    -121
blockmix_xor                                        1543    1322    -221
------------------------------------------------------------------------------
(add/remove: 4/1 grow/shrink: 3/5 up/down: 203/-536)         Total: -333 bytes

32-bit:
function                                             old     new   delta
xorbuf_3                                               -      76     +76
xorbuf64_3_aligned64                                   -      36     +36
xorbuf16_aligned_long                                  -      23     +23
xwrite_encrypted                                     499     507      +8
tls_xread_record                                     646     650      +4
xorbuf                                                22      11     -11
xorbuf_aligned_AES_BLOCK_SIZE                         23       -     -23
blockmix                                            1083     938    -145
blockmix_salsa8                                      415     210    -205
blockmix_salsa8_xor                                  601     163    -438
blockmix_xor                                        2103    1533    -570
blockmix_xor_save                                   2614    1859    -755
------------------------------------------------------------------------------
(add/remove: 4/1 grow/shrink: 2/6 up/down: 147/-2147)       Total: -2000 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-09 07:00:59 +02:00
Denys Vlasenko
e9c21c5c3a hush: fix SEGV on "echo << >" and such 
function                                             old     new   delta
.rodata                                           105787  105823     +36
fetch_heredocs                                       461     477     +16
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/0 up/down: 52/0)               Total: 52 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-08 10:36:12 +02:00
Denys Vlasenko
7b313c3465 libbb: code shrink in sha_crypt() 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-08 10:04:47 +02:00
Denys Vlasenko
0930708794 libbb/yescrypt: disable NROM code 
function                                             old     new   delta
smix1                                                  -     595    +595
smix2                                                  -     414    +414
static.yescrypt_kdf32_body                           899     847     -52
static.smix2                                         420       -    -420
static.smix1                                         604       -    -604
------------------------------------------------------------------------------
(add/remove: 2/2 grow/shrink: 0/1 up/down: 1009/-1076)        Total: -67 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-08 06:52:27 +02:00
Denys Vlasenko
d0f0874d57 libbb/yescrypt: disable code which accepts unusual yescrypt parameters 
Almost any reasonable yescrypt hashes in /etc/shadow should only ever use
"jXY" parameters which set N and r. Fancy multi-byte-encoded
wide integers are not needed for that.

function                                             old     new   delta
static.yescrypt_kdf32_body                             -     899    +899
static.PBKDF2_SHA256                                 213     219      +6
decode64_uint32                                      141       -    -141
yescrypt_r                                           990     805    -185
yescrypt_kdf32_body                                 1423       -   -1423
------------------------------------------------------------------------------
(add/remove: 1/2 grow/shrink: 1/1 up/down: 905/-1749)        Total: -844 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-08 05:34:41 +02:00
Denys Vlasenko
78bd8a44b7 libbb/yescrypt: explain and shrink decode64_uint32() 
function                                             old     new   delta
decode64_uint32                                      177     141     -36

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-08 03:47:48 +02:00
Denys Vlasenko
d18ac080e4 libbb/yescrypt: code shrink 
Setting EINVAL in errno is not necessary, just error return works.

function                                             old     new   delta
yescrypt_kdf32_body                                 1434    1423     -11
yescrypt_r                                          1029     990     -39
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-50)             Total: -50 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-08 00:16:56 +02:00
Denys Vlasenko
8466c3e78f libbb/yescrypt: madvise(MADV_HUGEPAGE) our usually very large allocation 
Nearly ~2 faster run when buffer is gigabytes in size

function                                             old     new   delta
yescrypt_kdf32_body                                 1386    1406     +20

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-07 23:07:58 +02:00
Denys Vlasenko
f8e9bd30d7 libbb/yescrypt: disable unrolling in two places 
Also, make many define macros safer

function                                             old     new   delta
blockmix                                            2300     814   -1486
blockmix_xor                                        4606    1543   -3063
blockmix_xor_save                                   4737    1620   -3117
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-7666)         Total: -7666 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-07 22:34:31 +02:00
Denys Vlasenko
e5d3a87633 libbb/yescrypt: 64-bit build fixes 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-07 21:52:39 +02:00
Denys Vlasenko
7798f651a4 add libbb/yescrypt/PARAMETERS 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-07 21:36:31 +02:00
Denys Vlasenko
67b98c7b1b libbb/yescrypt: no need to find salt-terminating "$" twice 
function                                             old     new   delta
yescrypt_r                                          1048    1029     -19

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-07 18:28:56 +02:00
Denys Vlasenko
e3484095f9 libbb/yescrypt: code shrink 
function                                             old     new   delta
yescrypt_r                                          1063    1048     -15

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-07 18:03:10 +02:00
Denys Vlasenko
5e9b95ff40 cryptpw: -m sha512crypt must also be accepted 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-07 17:42:35 +02:00
Denys Vlasenko
479d8db99f libbb/yescrypt: fix salts ending in dots (corresponding to binary zeros) 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-07 17:26:47 +02:00
Denys Vlasenko
75758c7360 libbb/yescrypt: accept longer salts (up to 84 chars) 
function                                             old     new   delta
cryptpw_main                                         214     223      +9
chpasswd_main                                        347     356      +9
passwd_main                                          931     934      +3
yescrypt_r                                          1084    1056     -28
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 3/1 up/down: 21/-28)             Total: -7 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-07 17:08:32 +02:00
Denys Vlasenko
63025e8bca libbb/yescrypt: remove forgotten SHA256 HMAC header file 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-07 10:51:13 +02:00
Denys Vlasenko
f464be22bd libbb/yescrypt: make it possible to set constant parameters, and set YESCRYPT_RW 
function                                             old     new   delta
yescrypt_kdf32_body                                 1052    1420    +368
yescrypt_r                                          1133    1084     -49
static.smix                                          762       -    -762
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 1/1 up/down: 368/-811)         Total: -443 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-07 10:39:14 +02:00
Denys Vlasenko
c11730490a libbb/yescrypt: remove redundant SHA256 HMAC implementation 
function                                             old     new   delta
hmac_blocks                                            -      88     +88
static.PBKDF2_SHA256                                 176     213     +37
yescrypt_kdf32_body                                 1046    1052      +6
static.smix                                          759     762      +3
hmac_block                                            88      64     -24
HMAC_SHA256_Final                                     53       -     -53
HMAC_SHA256_Buf                                       58       -     -58
HMAC_SHA256_Init                                     159       -    -159
------------------------------------------------------------------------------
(add/remove: 1/3 grow/shrink: 3/1 up/down: 134/-294)         Total: -160 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-07 08:21:44 +02:00
Denys Vlasenko
1a0913d57c libbb: factor out HMAC code from TLS 
function                                             old     new   delta
hmac_block                                             -      88     +88
hmac_peek_hash                                         -      61     +61
hmac_end                                               -      50     +50
hmac_begin                                           140     177     +37
hmac_hash_v                                            -      30     +30
.rodata                                           105799  105787     -12
hmac_sha_precomputed                                  54       -     -54
hmac_sha_precomputed_v                                69       -     -69
hmac                                                  83       -     -83
------------------------------------------------------------------------------
(add/remove: 5/3 grow/shrink: 1/1 up/down: 266/-218)           Total: 48 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-07 07:44:01 +02:00
Denys Vlasenko
e2091c9842 libbb: add two more forgotten source files 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-07 04:57:16 +02:00
Denys Vlasenko
a2a5db41a3 libbb/pw_ascii64.c: add forgotten source file 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-07 00:04:10 +02:00
Denys Vlasenko
53de6e6150 libbb/yescrypt: use common ascii64 encoding routine 
function                                             old     new   delta
num2str64_lsb_first                                   33      46     +13
yescrypt_r                                          1235    1133    -102
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/1 up/down: 13/-102)           Total: -89 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-06 22:43:28 +02:00
Denys Vlasenko
5e17e3c6f4 libbb: shuffle ascii64 code around, shrink i2a64() 
function                                             old     new   delta
num2str64_4chars_msb_first                             -      55     +55
num2str64_lsb_first                                    -      33     +33
i2a64                                                 42      25     -17
to64                                                  33       -     -33
to64_msb_first                                        55       -     -55
------------------------------------------------------------------------------
(add/remove: 2/2 grow/shrink: 0/1 up/down: 88/-105)           Total: -17 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-06 21:59:03 +02:00
Denys Vlasenko
f3a1b7be72 libbb/yescrypt: remove one NOINLINE, add copyright headers, merge two source files 
function                                             old     new   delta
pw_encrypt                                           945     974     +29
yes_crypt                                             50       -     -50
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 1/0 up/down: 29/-50)            Total: -21 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-06 20:59:00 +02:00
Denys Vlasenko
0574928c85 libbb/yescrypt: remove unused prefetching code 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-06 20:08:53 +02:00
Denys Vlasenko
aebe6f7132 libbb/yescrypt: remove inlines (whcih gcc detects anyway) and dead ifderfs 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2025-07-06 19:47:29 +02:00