Add doc-typehints to class properties found by the PropertyDocumentation
sniff to improve the documentation.
Once the sniff is enabled it avoids that new code is missing type
declarations. This is focused on documentation and does not change code.
Improve a mixed type to string
Change-Id: Id994553eaeac181775ac782423ff53928ad45466
Add doc-typehints to class properties found by the PropertyDocumentation
sniff to improve the documentation.
Once the sniff is enabled it avoids that new code is missing type
declarations. This is focused on documentation and does not change code.
Change-Id: Ifbc2ce0c68865c5d32689e56c6215a5099f7478b
Unused since addition of class property in 6906724935 (r100779)
Unused since dynamic creation in 0a21e2de12 (r82783)
Change-Id: I72c7dab67ef12d229fb232311e404467260d742d
Also remove @var from const, the type is given by the value of the const
and does not need documentation.
Change-Id: I65636f2b97b44387c4320ebfb4be6c81d6f771b9
Add doc-typehints to class properties found by the PropertyDocumentation
sniff to improve the documentation.
Once the sniff is enabled it avoids that new code is missing type
declarations. This is focused on documentation and does not change code.
Change-Id: Ib6081f5519d2294bb14f81bf399f9c45315f2b69
CodexModule::processStyle() looks at the path of the style file to
detect whether it's an already-flipped Codex file. In
I11c6a81a1ba34fe10f4b1c98bf76f0db40c1ce98 we broke this logic so that it
was comparing a full path (prefixed with MW_INSTALL_PATH) to a relative
path (not prefixed), so the detection always failed and we'd flip every
file. For Codex files, this meant we double-flipped the RTL files back
to LTR.
Follow-Up: I11c6a81a1ba34fe10f4b1c98bf76f0db40c1ce98
Bug: T373676
Change-Id: I49f14dcc503a3279362559197f12b2852276fb5e
Why:
* Maintenance scripts in core are mostly untested and testing them
will help to avoid regressions.
What:
* Create CommandLineInstallerTest.
Bug: T371167
Change-Id: Ia9ef03326d7c25b7eb310c191034932fffcbff8c
Why:
* Maintenance scripts in core have low test coverage
* Improving this will reduce the chances of regressions and bugs
What:
* Create CreateBotPasswordTest which fully tests
createBotPassword.php maintenance script.
* While doing this, address a PHP warning that appears when the
user does not specify the 'grants' option.
Bug: T371167
Change-Id: I8256c278b8397de896906e5714d478883b518ba0
Why:
* Maintenance scripts in core have a low percentage of test coverage
* Testing these scripts helps avoid regressions and bugs
What:
* Create DeleteOrphanedRevisionsTest which fully tests the
maintenance script.
Bug: T371167
Change-Id: I759a9203c52fd00cdeb5effe38f01190dec1fc80
Why:
* Maintenance scripts in core have poor test coverage
* Improving this coverage will help reduce the chances of bugs
and regressions.
What:
* Create DumpRevTest which mostly covers dumpRev.php
Bug: T371167
Change-Id: I0707bd92abb8b39e257b97aafdadef6bc600bee2
Why:
* Maintenance scripts in core are mostly untested and testing them
will help to avoid regressions.
What:
* Create FixUserRegistrationTest that fully tests the associated
maintenance script.
Bug: T371167
Change-Id: Ifb3594f7dc0055568431002a9180df7db4da9692
Why:
* Maintenance scripts in core have low test coverage, and
increasing the test coverage will help avoid regressions and
bugs.
What:
* Create RenameUserTest which tests the renameUser.php
maintenance script for when invalid arguments are provided.
Bug: T371167
Change-Id: I778f45e74708d1ad25b8bda918f5c3ca03e4668d
Why:
* Maintenance scripts in core have low test coverage, and testing
them is important to avoid regressions and bugs.
What:
* Create ResetAuthenticationThrottleTest which tests the script
for invalid or missing options, as well as resetting the
throttles for temporary account creation and name acquiration.
Bug: T371167
Change-Id: Ied9619f12f3f41040b1837e0923f8c7fb345175c
Different skins have different values for <p>'s spacing making toggle
arrow hard to vertically align correctly with heading paragraph, this
resets it to the symmetric spacing of Vector-2010.
Admittedly this isn't that clean solution but the other solution
would be more intervention on the PHP and also LivePreview side,
turning parseAsBlock() to parse() and taking care of Wikibase
which can't be done in rush so let's have a temporarily fix
at least for now.
Bug: T373658
Change-Id: Ie0d8014d7716b11f04c7b0de782b8ce1d15ff0f7
> Given all called same-class methods are de-facto and liberally claimed,
> and that we keep the coverage limited to the subject class, it maintains
> the spirit and intent by listing the class as a whole instead.
>
> PHPUnit offers a more precise tool when you need it (i.e. when testing
> legacy monster/god classes), but for well-written code, the
> class-wide tag is exactly what you want.
>
> We lose useful coverage and waste valuable time on keeping tags
> accurate through refactors, especially private functions (or worse,
> forget to update it).
> Tracking tiny per-method details wastes time in realizing (and
> fixing) when people inevitably don't keep them in sync, and time
> lost in finding uncovered code to write tests to realize it was
> already covered but "not yet claimed".
Ref https://gerrit.wikimedia.org/r/q/owner:Krinkle+is:merged+message:Widen
Change-Id: If90fc5285a067ec8f706d87b2ba1ae85020e2ba0
