Commit graph

105996 commits

Author SHA1 Message Date
Umherirrender
769bdbf091 docs: Fix nullable documentation for class properties
Change-Id: I6d0577124d852103f485ffdc819876a13f6641c3
2021-09-24 00:54:53 +00:00
jenkins-bot
1ed7ad4ffb Merge "sql.php: Fix typos" 2021-09-24 00:17:03 +00:00
DannyS712
2d1c35caca resourceloader: drop some unneeded startup compatibility checks
Remove check for window.JSON, redundant to check for es5
strict mode.

Remove check for window.addEventListener, we also check for
querySelector which is a newer part of the same API.

Bug: T290293
Change-Id: I95e62c7c1ed8f98f9df9e94fef86dda9aa77326b
2021-09-23 23:15:00 +00:00
Reedy
62181c53ac sql.php: Fix typos
Change-Id: I8de1d70039390a3e204dddac9d445187b4bf554d
2021-09-23 23:12:28 +00:00
jenkins-bot
e532630b11 Merge "mediawiki.util: Update addPortletLink to support 'text-wrapper' option" 2021-09-23 22:47:39 +00:00
jenkins-bot
93e2497411 Merge "Fix code example in IDatabase::makeList() documentation" 2021-09-23 22:09:40 +00:00
jenkins-bot
62d9c60273 Merge "Detect and monitor against multiple Parser invocation during edit requests" 2021-09-23 22:01:43 +00:00
Cindy Cicalese
eed48e402b Detect and monitor against multiple Parser invocation during edit requests
Bug: T288707
Change-Id: I0cca8f9bcf1d6e964b8b06c0c4490e83f4fb1de5
2021-09-23 16:12:40 -05:00
jenkins-bot
96ad399733 Merge "htmlform: Fix checkmatrix row vertical alignment" 2021-09-23 18:52:11 +00:00
Bartosz Dziewoński
b7b1ea669e htmlform: Fix checkmatrix row vertical alignment
The labels were not aligned with the info icons.

Change-Id: Ife0accc5bf88d486a0ef6ca4e5c2303a251869f5
2021-09-23 18:19:22 +00:00
bwang
d4d7635979 mediawiki.util: Update addPortletLink to support 'text-wrapper' option
- Add Skin::getOptions and Skin::getPortletLinkOptions, which are used
  to provide skin options to mw.util.
- Add SkinFactory::getSkinOptions, which is used by
  Skin::getPortletLinkOptions.

Depends-On: Ib23360e3439abc828404c1de8e0906915ee7d8b6
Bug: T289163
Change-Id: I801e7d583cb0b0c7da51f4da503268be736bb60c
2021-09-23 19:03:36 +01:00
jdlrobson
87e96b995a Update RELEASE_NOTES with replacements
Follow up to d93f45b034

Change-Id: Icb0222486cd7ffecfa03fb893312a17e4b947b63
2021-09-23 08:59:58 -07:00
Ammarpad
d93f45b034 Remove deprecated skin methods 3
* getAllowedSkins()
 * makeVariablesScript()
 * getSkinNames()

Bug: T287776
Change-Id: I518cabdf11fb6c6d317ca70b58418ef683a8baaa
2021-09-23 08:54:45 -07:00
jenkins-bot
292fa3ae54 Merge "Remove deprecated skin methods 2" 2021-09-23 15:19:43 +00:00
jenkins-bot
eddaa60142 Merge "Expand set of data returned by SkinTemplate::getTemplateData" 2021-09-23 15:19:38 +00:00
Lucas Werkmeister
9aab315946 Fix code example in IDatabase::makeList() documentation
The example had two syntax errors and was also misleading about the
quoting of input values.

Change-Id: Ib553a47fd49fdafe7ac159a89254498685f50cd4
2021-09-23 15:59:37 +02:00
Translation updater bot
e343ada8ab Localisation updates from https://translatewiki.net.
Change-Id: Id98a0c6fafa35d1134b5e990ad2e27d22749a149
2021-09-23 12:11:40 +02:00
Ammarpad
3ef920574e Expand set of data returned by SkinTemplate::getTemplateData
Added 4 boolean values
 * is-anon
 * is-article
 * is-mainpage
 * is-specialpage

Bug: T289221
Change-Id: Ieb5398c3505602dfbf77d97f24f3d19f703924b8
2021-09-23 07:23:05 +01:00
Ammarpad
4583cf0e0b Remove deprecated skin methods 2
* getLogo()
* subPageSubtitle()
* getSearchLink()
* mainPageLink()

Bug: T287777
Change-Id: I67108ef9c7bc608d767456723b9c7e078b317e41
2021-09-23 07:04:49 +01:00
jenkins-bot
c5d1233cd2 Merge "OutputHandler: Omit debug() call for common case" 2021-09-23 03:49:11 +00:00
jenkins-bot
64bad9f75c Merge "Update doctrine/dbal for PHP >= 7.3 from 3.0.0 to 3.1.2" 2021-09-23 03:49:05 +00:00
jenkins-bot
2b50f650cd Merge "Update doctrine/dbal for PHP < 7.3 from 2.10.4 to 2.13.3" 2021-09-23 03:49:00 +00:00
jenkins-bot
62d96c38c7 Merge "Revert "resourceloader: add local variable for mw.loader"" 2021-09-23 02:11:53 +00:00
jenkins-bot
7dbf025e76 Merge "resourceloader: Move mw.loader.getModuleNames to mediawiki.base" 2021-09-23 00:59:10 +00:00
jenkins-bot
9dcdb87f6f Merge "resourceloader: remove return from mw.Message constructor" 2021-09-23 00:54:43 +00:00
Krinkle
28173a23b7 Revert "resourceloader: add local variable for mw.loader"
This reverts commit 0faa22fc6d.

Reason for revert: Gzip is usually (and in this case) more efficient at
natively deduplicating repeated strings when transferring code from
server to client, than is possible through manual abbreviating through
a variable.

Fresnel confirmed this patch reduces JS transfer size by 10B. Not much,
but enough for the optimisation to not be needed.

Change-Id: I4ad22ca1220f33f018a6bc7e3da8389246cf5f9c
2021-09-23 00:45:48 +00:00
DannyS712
220932ef0f resourceloader: remove return from mw.Message constructor
When invoked as a constructor, the created object gets returned
anyway. When not invoked as a construct (eg with
`var demo = mw.Message( mw.messages, 'brackets', [ 'param' ] )`
the `this` value is the global `mw` object, which is unexpected.

Using mw.Message as a method call is not supported, and it
causes other problems (the .format, .map, .key, and .parameters
properties get set on the global `mw` object) but those are left
to be dealt with separately.

This follows-up r89076 (6a408d444c) where it was added for no
apparent reason.

Change-Id: Ie25758f92df0a33e66c266e007a1b81f077a9790
2021-09-23 00:33:07 +00:00
jenkins-bot
7e6156c16c Merge "Use PageUpdater's fluent interface as in some parts of our codebase" 2021-09-23 00:30:38 +00:00
jenkins-bot
5400a9e6de Merge "Fix $wgDisableOutputCompression and $phase checks in OutputHandler" 2021-09-22 23:57:04 +00:00
DannyS712
5b8b5bfb84 resourceloader: Move mw.loader.getModuleNames to mediawiki.base
It's not needed as part of the startup code, just for some modules
(in core the only place its used is in the mediawiki.inspect module)
and thus does not need to be defined so early, it can go in the
mediawiki.base module that is an implicit dependency of all
regular modules, where it can be loaded concurrently and take
advantage of the ResourceLoader module caching system.

Also tweak the documentation, the returned array is known to be
an array of strings.

Should have no effect on the functionality.

Change-Id: I18f5fae876a8b90f66b9c555d393169a5525f1af
2021-09-22 23:47:33 +00:00
Derick Alangi
2432cc2bb4 Use PageUpdater's fluent interface as in some parts of our codebase
Some methods in the PageUpdater's class implements the fluent interface
design pattern. Use the fluent interface where need be.

Change-Id: If76a4b8c5070c20ed40038a4ee78e2d677de5180
2021-09-23 00:31:33 +01:00
Timo Tijhof
faf2233cf4 OutputHandler: Omit debug() call for common case
Folllows-up I4c2d478b492ff17.

* MW_ENTRY_POINT can only be undefined in very early WebStart/Setup
  code. In code outside those files, and by the time MW_SETUP_CALLBACK
  OutputHandler run, this is always filled in to at least "unknown".

* Inline extra code to the less common conditional block.

Bug: T290776
Change-Id: Ia7fa6cb0ff156ed6cb0212443ac3a97c91982d4b
2021-09-23 00:19:57 +01:00
Reedy
75706c4f22 Update doctrine/dbal for PHP >= 7.3 from 3.0.0 to 3.1.2
Change-Id: I5a4adf69dd5726bdb0586a1545712ef6dd8daea3
2021-09-22 23:13:18 +00:00
Reedy
ad49bffd76 Update doctrine/dbal for PHP < 7.3 from 2.10.4 to 2.13.3
Change-Id: Ic6c4f49c66d3f3990a15615cc5b085e5134df8d3
2021-09-22 23:13:05 +00:00
Aaron Schulz
64a4d6e74f Fix $wgDisableOutputCompression and $phase checks in OutputHandler
The config variable check from 6c81f0b868d2 needed a negation.

The phase check from 374bdc0f7c should have been a conjuction.

Also add some debug logging statements.

Follow-up to 6c81f0b868d2 and 374bdc0f7c.

Bug: T290776
Change-Id: I4c2d478b492ff17bdad76bf75119b5926f7917e8
2021-09-22 13:41:47 -07:00
jenkins-bot
7a545309c7 Merge "Hiding fallback button depends on HTML order" 2021-09-22 20:12:57 +00:00
jenkins-bot
b2a2022fd5 Merge "Remove deprecated skin methods (1)" 2021-09-22 19:34:20 +00:00
Ammarpad
3bd39c50a6 Remove deprecated skin methods (1)
* privacyLink()
* aboutLink()
* disclaimerLink()
* makeUrl()
* getIndicatorsHTML()

Bug: T287777
Change-Id: Ie04e4c4e063d7f61653e55a914ed7a623efda550
2021-09-22 19:06:48 +01:00
Alexander Vorwerk
1b06034ca6 Hard deprecate SkinTemplate::getPersonalToolsList()
deprecated since 1.35 and unused

Bug: T291576
Change-Id: Ifcfd70b71060b7d3cf32fcb9c3bcad6f7bcfabff
2021-09-22 19:59:44 +02:00
jenkins-bot
43f1dc2095 Merge "Hard deprecate Skin::getSkinStylePath" 2021-09-22 17:54:28 +00:00
Ammarpad
69be37d1be Hard deprecate Skin::getSkinStylePath
Bug: T270754
Change-Id: I128cc73131a0d4f3858c1b4f350e1d10e99726b3
2021-09-22 18:27:32 +01:00
Reedy
0eb23b5cc9 MysqlUpdater: Add updatelog entries for dropDefault
Currently, this update is run every time update.php is run,
because mysqli usually returns ""

Change-Id: I9f862138b5e024798b27cfd4814810cbca43ae38
2021-09-22 16:08:27 +00:00
Martin Urbanec
408999928d
HTMLTitleTextField: Remove B&C code
Bug: T288181
Change-Id: Iec9225d0f0fe47dd972f6c302ca803e65b8232a7
2021-09-22 00:48:59 -07:00
Translation updater bot
579fea47f8 Localisation updates from https://translatewiki.net.
Change-Id: Ida2deeecc002e6dc84a85fbcfe50d0c3388dcf10
2021-09-22 07:59:18 +02:00
DannyS712
db49026745 ActivityUpdateJob: accept PageReference
For both LinkTarget and PageReference, just extract
namespace and dbkey and pass those in the array
of parameters to Job::__construct().

Allows a bunch of simplification to WatchedItemStore.

Bug: T291531
Change-Id: Id150d0c62af38d4b3d17e5698866127c6e04717e
2021-09-21 23:30:51 +00:00
DannyS712
20aa78f213 Drop deprecated BeforeResetNotificationTimestamp hook
Deprecated in 1.37 and unused

Allows a bunch of cleanup for WatchedItemStore.

Bug: T271715
Change-Id: I328cf49c3e85da2069b620f8c63670d93608a784
2021-09-21 23:09:18 +00:00
jenkins-bot
44c0eb82b3 Merge "API: Fix null docs in ApiBase" 2021-09-21 20:32:58 +00:00
jenkins-bot
53e12704ec Merge "Update block option heading text to match design" 2021-09-21 19:15:49 +00:00
Umherirrender
e27cb5e468 API: Fix null docs in ApiBase
Change-Id: I63399b1ee2f2c8d6f7f6a5781a5a61de5d21ede8
2021-09-21 17:57:56 +00:00
jenkins-bot
6b7edbbbb5 Merge "build: Update wikimedia/purtle from 1.0.7 to 1.0.8" 2021-09-21 16:21:39 +00:00