Brion Vibber
94c04f7cd1
Provisional revert of r89406, r89414: reference-related warnings need cleanup before applying code like this
...
Per CR http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89406#c17545 :
'Here is a third one: Strict Standards: Only variables should be passed by reference in /www/sandwiki/includes/Wiki.php on line 177 '
Offending bit is this:
- SpecialPageFactory::executePath( $this->context->title, $this->context );
+ SpecialPageFactory::executePath( $this->getTitle(), $this->getContext() );
That function demands reference paramters for $title and $context, which is being violated here where we now pass function return values:
public static function executePath( Title &$title, RequestContext &$context, $including = false ) {
The $title does sometimes get replaced within the function body, but $context does not appear to ever be replaced (its *contents* are modified, which does not require passing by reference)
If replacing it is something it should be doing, then we need to be able to replace it upstream presumably, so $this->getTitle() probably isn't appropriate.
The $context probably should have the reference simply removed.
2011-06-03 18:48:59 +00:00
Brion Vibber
d97e37bbe6
Revert r89409: provided a default Database->listTables() implementation that didn't actually check the database, thus missing extension tables, any custom tables, any other tables being managed deliberately, and would be missing a matching table prefix if any.
2011-06-03 18:39:10 +00:00
Huji
e83e6eb004
Extension to r89419, I was too excited fixing the bug
2011-06-03 16:20:00 +00:00
Huji
9e93d5bd0d
Extension to r89419, removing a bugous CSS code
2011-06-03 16:17:08 +00:00
Huji
2ff74954bf
(bug 29263) Add LTR class to the shared CSS to be used for left-to-right text such as SQL queries shown in dberrortext and similiar messages in RTL environements
2011-06-03 16:15:07 +00:00
Happy-melon
23bb7c3ba6
Follow-up r89406 CR: another use of RequestContext::__get()
2011-06-03 14:36:06 +00:00
Jure Kajzer
7b23ec9c87
* suggestion for using tables.sql parsing instead of database query for tables list needed for phpunit
...
* would be better option IMO since the database is not necesserally dedicated to MW install
2011-06-03 11:43:54 +00:00
Happy-melon
295f513e8b
More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so let's leave the calls in with a wfDeprecated() for a while...
2011-06-03 11:04:49 +00:00
Alexandre Emsenhuber
f33f9ec7ee
Don't execute the loop if there's no X-Forwarded-For header, also don't use isset() to check only for null
2011-06-03 10:55:38 +00:00
Happy-melon
6e7eb67b43
Start unpicking r85288 (magic __get() accessor for RequestContext). Instead, bring back some of r86872 (abstract base class for classes providing access to RequestContext methods), which is a more 'classical' solution.
2011-06-03 10:54:13 +00:00
Alexandre Emsenhuber
8f7038afe3
Deprecated wfGetAgent(), use $wgRequest->getHeader( 'User-Agent' ) instead
2011-06-03 10:41:53 +00:00
Alexandre Emsenhuber
c9bad93715
Removed usage of error suppression operator
2011-06-03 10:20:45 +00:00
Roan Kattouw
35dbdb618f
(bug 29105) Splitlines completely messes up selection of inserted text. This is not a problem in practice (WikiEditor doesn't have multiline insertions with splitlines enabled since r89402), but just in case it ever becomes a problem I'm disabling selection of inserted text altogether when splitlines is enabled; instead, the cursor will be moved to the end of the inserted text.
2011-06-03 10:08:06 +00:00
Roan Kattouw
7f043049b9
(bug 29104) Fix r86622: make splitlines default to false, makes much more sense
2011-06-03 09:56:01 +00:00
Roan Kattouw
274346d691
(bug 29121) jquery.suggestions uses jquery.autoEllipsis but didn't have it in its dependency list, causing JS errors in non-Vector skins
2011-06-03 09:51:48 +00:00
Chad Horohoe
cb569f094f
Fix some of the weird freaky interaction between ApiBlockTest and BlockTest.
...
* By using the same summary for both, we allow both sets of tests to pass with --filter Block
* Just testing includes/BlockTest.php still passes
2011-06-03 06:22:18 +00:00
Chad Horohoe
5cca2119e3
rvv: r89398. Tim wants me to wait
2011-06-03 05:44:28 +00:00
Chad Horohoe
3465e3f083
Kill off action=raw from index.php
...
* One less entry point to worry about
* Completely obsolete by load.php and api.php
* Left $wgDebugRawPage in place, also affects load.php requests (docs already reflect)
* Affects dumpHTML (probably broken anyway, has anyone RL-ified this?), and two abandoned/obsolete extensions
2011-06-03 05:39:32 +00:00
Tim Starling
97ff30ddb4
(bug 28840) If the query string hits bug 28235, redirect to a safer URL instead of showing an unhelpful error message. IE 6 will only use the extension of the final destination for its cache filename.
2011-06-03 05:32:51 +00:00
Chad Horohoe
db833df9dc
Remove useless bootstrap inclusions
2011-06-03 04:25:21 +00:00
Chad Horohoe
ebff6207a7
Fix for r85229: getOutput() instead of getOut(), leftover $wgOut usage.
2011-06-03 04:22:14 +00:00
Mark A. Hershberger
1fb4ff1dd8
Apply a patch adapted from the one on Bug #16794
...
This patch should allow you to use the $wgSharedDB [with Postgres]
normally, as you would with mysql. Basically this patch creates a
second connection with the shared database and when a query is
made, we check on which connection we should send it.
Patch from Luca Fulchir
2011-06-03 04:10:33 +00:00
Chad Horohoe
7830a165d4
Missing ,
2011-06-03 04:05:04 +00:00
Chad Horohoe
46caa4d6df
Add Maintenance and FakeMaintenance to the autoloader for paranoia
2011-06-03 03:59:27 +00:00
Mark A. Hershberger
9be60e5725
forward port r88929
2011-06-03 03:41:11 +00:00
Chad Horohoe
4081fcabad
Kill $wgWikiFarm. Only use in a wmf code path, and I can't find any evidence of this being use in WMF anywhere.
2011-06-03 03:38:52 +00:00
Chad Horohoe
5063ec99ac
Fix for r89166: need self
2011-06-03 03:36:36 +00:00
Krinkle
b192c2637e
Move fixes for config-error-box to mw-infobox in order to apply for warnings as well. And removed redundant clear: left. Poke r88465, 86060, r88109
2011-06-03 02:26:31 +00:00
Mark A. Hershberger
f8aec598e0
Fix for bug #28172 (“wfGetDB called when it shouldn't be”).
...
forward ported from r88936 and r89374.
2011-06-03 01:06:07 +00:00
Krinkle
439a38eca2
typo from r78201
2011-06-03 01:04:24 +00:00
Jure Kajzer
2967a44864
* fixed table duplication for phpunit testing
2011-06-02 22:23:05 +00:00
Chad Horohoe
c8eb28b2b3
Revert r88648 per CR
2011-06-02 20:15:00 +00:00
Mark A. Hershberger
a6722cc9aa
w/s changes.
2011-06-02 19:32:45 +00:00
Sam Reed
9574e81006
Followup r89348
...
Fix code style, and remove hint that variable may be multi
2011-06-02 18:39:55 +00:00
Max Semenik
7ad10e271d
Don't duplicate tables starting with unittest_ which can be left if a previous run ended with a fatal on SQLite
2011-06-02 17:58:34 +00:00
Mark A. Hershberger
bf52ea8762
follow up r88502 with a fix to resource loader to restore tochidden
...
removal addition.
2011-06-02 16:38:55 +00:00
Roan Kattouw
ec83e2da6e
Revert r88722 (allow multiple values for letype): this won't play nice with query indexing
2011-06-02 16:13:42 +00:00
Platonides
b83905dae3
Fix for r89263: this to $this
2011-06-02 16:10:48 +00:00
Mark A. Hershberger
60074b053a
Revert r88502 since this can be done with a gadget
2011-06-02 16:02:04 +00:00
Roan Kattouw
ab24b1f826
Fix regression in r84638, causing ArticleDeleteComplete to be called twice on file deletions. doDeleteArticle() already calls it, there's no need for FileDeleteForm::doDelete() to call it again
2011-06-02 15:42:23 +00:00
Platonides
eeb16a279e
Close wfProfileIn
...
Exit point missed by r85204
2011-06-02 15:39:24 +00:00
Jeroen De Dauw
5e3b5c0f54
added @ßince tag
2011-06-02 14:38:14 +00:00
Antoine Musso
e90b8ed010
Add Debug hook as a new feature of 1.19
...
Release notes were not updated by r88843
2011-06-02 14:17:00 +00:00
Antoine Musso
7c71f70e7c
properly move the jpegmeta.js file from util to libs.
...
Follow up r89083 (code change)
Fix r89084 (file move without history, reverted by r89334)
2011-06-02 13:44:27 +00:00
Antoine Musso
a056174195
revert r89084 (file moved without keeping history)
2011-06-02 13:40:05 +00:00
Robin Pepermans
8bd13cb41c
Fix encoding (followup r89330)
2011-06-02 13:23:21 +00:00
Robin Pepermans
7f0f80af2e
Follow-up to r89329: Add MessagesRoa_rup.php as fallback to 'rup'
2011-06-02 13:14:16 +00:00
Robin Pepermans
80a2b74f34
Renaming 'roa-rup' to 'rup' (see also bug 15988), and adding 'roa-rup' to $wgDummyLanguageCodes. I'm going to add MessagesRoa_rup.php as fallback, and update extension translations as well.
2011-06-02 13:10:06 +00:00
Alexandre Emsenhuber
0f23b01fe5
Removed useless call to wfLogProfilingData() since profiling is disabled in command-line mode
2011-06-02 08:18:52 +00:00
Alexandre Emsenhuber
983ff14075
Removed obsolete comment that was mentioning $wgInputEncoding and $wgOutputEncoding
2011-06-02 08:17:12 +00:00
