* Update extensions/DiscussionTools from branch 'REL1_43'
to 3af0166f131a8147c05c1045df3edfbc51690172
- Add signature range markers to the DOM
Without these, the client side code is unable to
extract comment message bodies. In theory there can
be multiple signatures in one comment, but in practice
we only care about the last one.
Change-Id: I515a2878eb5aef88d05d8b62462e91500907a73a
(cherry picked from commit 7fb4369ae8c283caa2a41a27f809b091124c0b4b)
* Update extensions/OATHAuth from branch 'REL1_43'
to cf039f8e5a199b9fd2a093ef3a35b7c7aca76221
- Fix multi-key handling
Follow up on the multiple-authenticators work by replacing
the user's 2FA module (of which there could only be one) with
the user's 2FA keys in various places.
Functional changes:
* Add OATHUser::getKeysForModule() and a shortcut for the TOTP
module (for typehint friendliness)
* Filter modules for TOTP only in various places:
** ApiOATHValidate (which could maybe be more generic in the
longer term, but would need some sort of support flag - it
will definitely not work with WebAuthn).
** Lots of places that did the same filtering manually.
* Do not throw in various places when the user has multiple kinds
of keys:
** OATHUser::addKey()
** OATHUserRepository::loadKeysFromDatabase()
* Keep throwing in OATHUserRepository::createKey() (which is what
gates the use of multiple authenticators currently, and we want
to preserve that until further UX improvements) but use an error
page rather than an error.
Code cleanup:
* Replace OATHUser::setKeys() (only used in a single place, to
remove a key) with removeKey().
* Hard-deprecate OATHUser::getModule() and remove its uses.
* Remove OATHUser::setModule(). Instead, use the first key in
getModule().
WebAuthn part of the change: Ib9a686171da67b334e80524629df406d10903391
Bug: T242031
Change-Id: I70241b9cfc036ea6439bf30ed724c1377a78d5c0
(cherry picked from commit 511127a8edea3c6ac390fb8ff1269d6e07a2f845)
* Update extensions/OATHAuth from branch 'REL1_43'
to a8c75338a5abe48a727fd498da7b2e0ffe688dbd
- Mark OATHUser::getModule() as deprecated
Bug: T242031
Change-Id: Iff8c459f391938848bc80ac288f0c41e3e627abc
* Update extensions/OATHAuth from branch 'REL1_43'
to c5191316484de480ed151190be24feec81877819
- OATHManage: Drop use of OATHUser::getModule()
Bug: T242031
Change-Id: Idb71e383e18f9fc7948aed12e9bd32ce511f4aa7
* Update extensions/OATHAuth from branch 'REL1_43'
to b3b5c9e75482ef46937b4948246acbb39fac8e5c
- Don't share OATHAuth devices for all non-attached users
* Do not load keys for users where the central ID keys is 0.
* Throw an error instead of allowing the use of createKey() for users
without a central ID.
* Mark persist() as deprecated. The only remaining use of that will not
save a key for a user that does not already have them, so no need to
check for the ID there.
* Use the cached central ID value instead of always looking it up.
* Update tests to use the local central ID provider. I consider the
reason why this is needed to be a CentralAuth bug, but this is easier
than fixing CentralAuth.
Bug: T379442
Bug: T379439
Change-Id: I1a1fff62208ccc580273843f0f479ab337703823
* Update extensions/OATHAuth from branch 'REL1_43'
to 4035ebce6361c19025074eee14d5a6cd156f0670
- OATHUser: Use UserIdentity where applicable
Depends-on: I562d6347f34691f1717d92b476618108af3de956
Change-Id: If0147e03ab7b7f43e6a261b673350317193389c1
* Update extensions/OATHAuth from branch 'REL1_43'
to 575646a7f223c1310fe4aceaa2063339ef2634d7
- Rename Special:OATHAuth to Special:AccountSecurity for en and zh
Bug: T401771
Change-Id: If9cfc192944e32b5ab968ed160603bd43314a723
* Update extensions/OATHAuth from branch 'REL1_43'
to 044d3fdc8c8930d823a255eb1106493884fe0ebd
- OATHAuth: Set Chinese primary special page alias to the English primary
Bug: T399285
Change-Id: Ifcdc8c2736c83194f516cdc555868479ce9893eb
* Update extensions/OATHAuth from branch 'REL1_43'
to 2d129e97d3f74862fb73ef2f3e25f587ffc0c655
- OATHManager: Look up user details in execute() instead of constructor
Change-Id: I5db5d7e49553c30f4a76c01d39955821c6f82df6
* Update extensions/OATHAuth from branch 'REL1_43'
to 913e1d4085fad285ab627dd9261ddff97f0509b8
- ApiOATHValidate: Remove use of getModule()
Change-Id: I5fee274e792f087aedf30259069203d8e1f24d10
* Update extensions/OATHAuth from branch 'REL1_43'
to aa3bd6bafa5c355517e01ef9b36479690a1e1691
- Backlink keys back to a module
Adds a new API function to get the module that a particular key is
registered for. This will allow replacing a bunch of User::getModule()
calls with per-key equivalents, which is required so that a single user
can have multiple key types enabled.
Bug: T242031
Depends-On: I6dffa329c923aab1bef59b4c2808a2ad15a6cb19
Change-Id: Iae064c660bb04fee42df0892a5b53bdd8a7457ad
* Update extensions/OATHAuth from branch 'REL1_43'
to 6823c915324478b377177366c9cc035d341f8aa1
- Allow injecting services to Modules
And as a bonus tweak OATHModuleRegistry error handling.
Change-Id: I4e3ca0092115e22ab7e7703e1682d68fbcc06af4
* Update skins/MinervaNeue from branch 'REL1_43'
to d85b666a8d7e9f3604a45ebca07694f616388286
- Localisation updates from https://translatewiki.net.
Change-Id: Ib4e0a7bbec537f26b08a4b82a99f456537247109
* Update skins/Vector from branch 'REL1_43'
to e1106da2830f08b2b1dff4abf22f1209568f44bf
- Localisation updates from https://translatewiki.net.
Change-Id: I3f4985fc2423adb69efaa41703c9d9df275ad3ca
* Update extensions/VisualEditor from branch 'REL1_43'
to 6791d900ccbca8e86f33cb50ad717908f245dde2
- Localisation updates from https://translatewiki.net.
Change-Id: Ie19414472397d29ced9844ef36e17d617b349b5d
* Update extensions/WikiEditor from branch 'REL1_43'
to 797d2308f3859747477061a21fe6ad079086b9ac
- Localisation updates from https://translatewiki.net.
Change-Id: I328fd81900735bb6d905c0b8042424cf2b699faf
* Update extensions/Thanks from branch 'REL1_43'
to 76da6580d69a76f08b3b792f70cf5e6dfa9d0266
- Localisation updates from https://translatewiki.net.
Change-Id: I93a6422470b86ae95947f1c0606344409de9e06e
* Update extensions/Scribunto from branch 'REL1_43'
to 9ecb7d2137664b7034b21c364a11b7be8c919598
- Localisation updates from https://translatewiki.net.
Change-Id: I7f785ee91ebb77197879f024cf19adbf0b2e7c34
* Update extensions/OATHAuth from branch 'REL1_43'
to ad3c7084074dce5a5725e5e454aceb4a2adf1e08
- Localisation updates from https://translatewiki.net.
Change-Id: I07c1720f7e8d36cf341c6baf27ebb6becf1b3c6b
* Update extensions/Linter from branch 'REL1_43'
to 5cf4aa3b35535eaf7716d2e8c1df5866f036c08e
- Localisation updates from https://translatewiki.net.
Change-Id: Ic6879439e95d20d432d77f7d707d682d0ffa1fb7
* Update extensions/LoginNotify from branch 'REL1_43'
to 78d82f1c47581f417cb9603b61064dfac25042c0
- Localisation updates from https://translatewiki.net.
Change-Id: I78a85bba97969c2202228cb6af57bea763aee57a
* Update extensions/InputBox from branch 'REL1_43'
to 1f17a7f553e2db192177587b938323c6ff61ca06
- Localisation updates from https://translatewiki.net.
Change-Id: I60e612674c919726279e0d911ff2df1976960517
* Update extensions/Gadgets from branch 'REL1_43'
to d40e72fbc4421f4e872dcff5a8b30cbf1aeaf5c8
- Localisation updates from https://translatewiki.net.
Change-Id: I3d263126573e8d59073b253c1a2c50e5bc08fe0d
* Update extensions/Echo from branch 'REL1_43'
to fa663a91674df5611ad636a52bd5c474a1b91da3
- Localisation updates from https://translatewiki.net.
Change-Id: I7204e7a260069dd6e9ce88f2978f94dcd5d49df7
* Update extensions/DiscussionTools from branch 'REL1_43'
to afcf393cf51decd21f521c0b21ddddf86a90ac57
- Localisation updates from https://translatewiki.net.
Change-Id: Icbb33683669eac996f83ac6b41400578672f7218
* Update extensions/ConfirmEdit from branch 'REL1_43'
to 9b1fb3940f31049dadaa2af9c8f0178d485cfc1e
- Localisation updates from https://translatewiki.net.
Change-Id: I7f2f8dbc5912f74946ebb710f1aad62a293e366c
* Update extensions/CodeEditor from branch 'REL1_43'
to 97bb077f5362c323fd2990b9674acbb32ca9940e
- Localisation updates from https://translatewiki.net.
Change-Id: I8c6fc1cd357dfec47df423781573ba49e9babc2f
* Update extensions/CiteThisPage from branch 'REL1_43'
to 67deb0d45747ccb790d6a8bb0dfedb4f9242a92a
- Localisation updates from https://translatewiki.net.
Change-Id: I16d4bdd55907bacdda9189ee18e1e380b09f8286
* Update extensions/Cite from branch 'REL1_43'
to 82c4c7cead69a0e7cd856453ad44fbdc33c0283f
- Localisation updates from https://translatewiki.net.
Change-Id: Ifabd57de1d1e9f96e94899901de3a0474aa3f46a
* Update extensions/CategoryTree from branch 'REL1_43'
to 54404edb0ec52e4095c3b66775b3fe24e737eda3
- Localisation updates from https://translatewiki.net.
Change-Id: I1127b835083927efc9da7c9633c546ef1876faef
* Update extensions/AbuseFilter from branch 'REL1_43'
to 6a8897924d8eae87b84b9b3da9d47f57849000fb
- Localisation updates from https://translatewiki.net.
Change-Id: Ie1e32f54bbbac1c464c0cfabe0fde38c3207baff
* Update extensions/Echo from branch 'REL1_43'
to 4ee6bc43c7a8311d773053c4ab7ffe545d4dbcad
- tests: Remove unused "ext.echo.mobile" dependency from unit test
This prevents the Echo unit tests from working in CI when an
extension depends on Echo but not MobileFrontend. Normally, we'd
fix this by skipping relevant tests, but in this case there are no
relevant tests.
Follows-up I2f923e509d (T342907) which removed the
test_NotificationBadge.js file, but left behind this unused
"ext.echo.mobile" dependency.
Follows-up Ie4a87f3b80 (T299780), which fixed a similar issue before:
> The test for `ext.echo.mobile` in particular though was never
> executed in CI specifically because:
> > Undefined module: 'mobile.startup'
Bug: T389998
Change-Id: I6360a6e1d0d599611718a1e171159f52949d1a56
(cherry picked from commit dd8b29beddef3f6077f97443b15ed18e7718ab5f)
When running tests, there is no need to differentiate between extensions
and skins. When generating coverage, CI uses extensions:unit and
skins:unit, they only differ by the paths they filter.
This change extensions:unit to no more filter path, it would then
discover tests under $IP/skins/. In CI, this will let us switch skins
to use the same job used by extensions therefore simplifying the stack.
Bug: T395470
Bug: T402398
Change-Id: Ifaeb8c2e278acca89a92187ac39a6c0e1eb503f9
(cherry picked from commit 515e35d5b0b3e66e63f8209447aa3888b18a442f)
Why:
* The release branches of MediaWiki have their PHPUnit tests fail
in WMF CI because the 'ext.pageviewinfo' module from PageViewInfo
fails to be validated due to the missing Graph extension
dependency
* To unblock CI on the release branches, we should just skip any
tests on this module.
** This is hacky, but there isn't a way for an extension to tell
ResourcesTest that it's module should be skipped for tests
What:
* Update ResourcesTest::getAllModules to skip tests on the
'ext.pageviewinfo' module
Bug: T404729
Change-Id: I34d7a1b4769811968e61b3d022cff95e37e7a987
* Update skins/Vector from branch 'REL1_43'
to 897b393f719522b8a26edbf65bfb9f69c12c377f
- Localisation updates from https://translatewiki.net.
Change-Id: I19af0c0bdb341611ec226dce8e73ae6dd8cb2a75
* Update skins/MinervaNeue from branch 'REL1_43'
to 2d1ab02e18feb0ecd36b6e93167b54bd327d750f
- Localisation updates from https://translatewiki.net.
Change-Id: I24958bc2ab1dd5275fee660ee8ee179c3bd9ab36
* Update extensions/VisualEditor from branch 'REL1_43'
to 12df20285d232207beb0fc900cf25f87b72ec783
- Localisation updates from https://translatewiki.net.
Change-Id: If10fd09950ac516c1a0dc49569b4e89f21c7bb1c
* Update extensions/WikiEditor from branch 'REL1_43'
to 7048111b64854139b57123a7c77e1cad65cfec15
- Localisation updates from https://translatewiki.net.
Change-Id: I349d6bf7d89542822c4a3992874ff508beb34b8d
* Update extensions/Thanks from branch 'REL1_43'
to 01bd784430053843a4e73a0ed97a33e3b0c57c4c
- Localisation updates from https://translatewiki.net.
Change-Id: I2cc0d0c2f7f3c0e3972f92a6983b7b716fbacd94
* Update extensions/OATHAuth from branch 'REL1_43'
to c444263d054ece78c499505822750f655f15c422
- Localisation updates from https://translatewiki.net.
Change-Id: Ie43439c53b6fd748d90e4714f6a728df16bcaab2
* Update extensions/Linter from branch 'REL1_43'
to 5157239d23ea60c905879a28a63932aca777ab1b
- Localisation updates from https://translatewiki.net.
Change-Id: I486ac9e8d2df138ec210d6a3fb9cf3f95739df46
