Commit graph

97105 commits

Author SHA1 Message Date
jenkins-bot
cef4fe007e Merge "mailmap: Add mailmap entry for Majavah's real name" 2020-06-21 00:30:56 +00:00
jenkins-bot
daff5b8e5a Merge "API: Use MediaWikiServices::getAuthManager in various Api classes" 2020-06-20 23:23:07 +00:00
Umherirrender
3d45f17398 API: Use MediaWikiServices::getAuthManager in various Api classes
Change-Id: I0af2e5fe91097077eeaf83027494065a0c1a6c04
2020-06-20 23:04:17 +00:00
jenkins-bot
3bb48799e3 Merge "media: Remove truthy check on array in FormatMetadata" 2020-06-20 22:08:44 +00:00
jenkins-bot
fe89b9041a Merge "rdbms: Remove is_array check on typed argument in DatabasePostgres" 2020-06-20 21:15:48 +00:00
Umherirrender
4f45c8b2de media: Remove truthy check on array in FormatMetadata
Change-Id: Iafe3741e619437d9fb72c46882395983b4de27b0
2020-06-20 20:54:38 +00:00
Umherirrender
d5259a9449 rdbms: Remove is_array check on typed argument in DatabasePostgres
Change-Id: I0d5b79c1453c4600cb7351aefd1e07d7d2f59044
2020-06-20 20:52:01 +00:00
jenkins-bot
ba443c4a93 Merge "WebRequest: Rewrite language handling in getAcceptLang()" 2020-06-20 18:09:33 +00:00
Umherirrender
f6617ba4b7 WebRequest: Rewrite language handling in getAcceptLang()
Change-Id: Ifcf0bc4c416d9b0a61d6ae82a184ba53b4f36016
2020-06-20 17:48:27 +00:00
Taavi Väänänen
09f59e629e mailmap: Add mailmap entry for Majavah's real name
Change-Id: I2ac25fa550cf1950482cd5892875699d465b58c2
2020-06-20 19:57:25 +03:00
jenkins-bot
f3b0ee76c5 Merge "Simplify overly complex data providers in HtmlTest" 2020-06-20 14:57:49 +00:00
jenkins-bot
3d9acfbb68 Merge "Improve param documentation of UserDupes maintenance script" 2020-06-20 14:55:35 +00:00
jenkins-bot
110d0cbd71 Merge "Remove is_scalar check on array" 2020-06-20 14:55:28 +00:00
jenkins-bot
f9056e3eca Merge "Remove null check on type hinted argument" 2020-06-20 14:53:06 +00:00
jenkins-bot
ad4a3ba45f Merge "skins: Allow skins to load script modules via Skin class options" 2020-06-19 21:14:24 +00:00
Umherirrender
606c5731d7 Improve param documentation of UserDupes maintenance script
Change-Id: I13ba7bf206309c67cffe2e4c0f67d7be3d884f5f
2020-06-19 19:29:49 +02:00
Umherirrender
8919239236 Remove is_scalar check on array
is_array is called before is_scalar and arrays are not scalar

Change-Id: I73e65ac8bce95e31a2c5da7a48a212ce35fb4f40
2020-06-19 19:23:17 +02:00
Umherirrender
2280d96cdc Remove null check on type hinted argument
Change-Id: I2d98662cc325a69b3a139df65d390d801684b4fd
2020-06-19 19:18:28 +02:00
jenkins-bot
7ba2e0aed3 Merge "Clarify that addModuleStyles is for style-only modules" 2020-06-19 16:33:17 +00:00
jenkins-bot
148615b891 Merge "Swap null and is_int check to get the expected warn message" 2020-06-19 15:59:13 +00:00
jenkins-bot
f5ac95db35 Merge "Fix combination of (int) and ??" 2020-06-19 15:59:06 +00:00
jenkins-bot
7c620e02dc Merge "Check for INF instead of false for message exif-maxaperturevalue-value" 2020-06-19 15:58:59 +00:00
Lucas Werkmeister
5ba809c214 Clarify that addModuleStyles is for style-only modules
“the styles of … ResourceLoader modules” suggests to me that this method
can be used with any ResourceLoader module(s), and their style parts
will be loaded as <link rel=stylesheet> while JavaScript parts will load
as usual, but this is not in fact the case: if ResourceLoaderClientHtml
encounters a module type other than LOAD_STYLES in the moduleStyles
modules, it logs an error and skips the module.

Change-Id: If0e709311c1b777f6d99cb714f19307c1015ec01
2020-06-19 17:29:48 +02:00
Umherirrender
17a5d5a84b Fix combination of (int) and ??
(int) has higher precedence as ?? and that means the array key is always
casted first and the error suppression part of ?? cannot work

https://www.php.net/manual/en/language.operators.precedence.php

Change-Id: Iee7dc9297c0745ce48295f637a7591ce9385aa4d
2020-06-19 17:28:22 +02:00
Umherirrender
abb1ccbb47 Swap null and is_int check to get the expected warn message
!is_int also true for null, so swap the conditions

Change-Id: I99c4c9e6f724430faf9b4e28ca98fe60f5a9d6aa
2020-06-19 17:25:03 +02:00
jenkins-bot
c82316a824 Merge "Remove falsy check after new call" 2020-06-19 09:08:37 +00:00
jenkins-bot
cbb680d6c2 Merge "Simplify use of ?? in MWLBFactory" 2020-06-19 09:07:06 +00:00
Umherirrender
47f422d59f Check for INF instead of false for message exif-maxaperturevalue-value
** cannot return false, but INF

Change-Id: Ib08a94720fb70b845753b6640e3c0ff5e6894322
2020-06-19 08:51:39 +00:00
Translation updater bot
c0a0483789 Localisation updates from https://translatewiki.net.
Change-Id: I9e95a1588c7e49ec198d88f3f805c990c24c3658
2020-06-19 08:37:25 +02:00
jenkins-bot
b71eae200a Merge "Add missing special page aliases for Persian" 2020-06-18 23:44:58 +00:00
jenkins-bot
6c8f3c6950 Merge "title: Don't query/create LinkCache service when not needed" 2020-06-18 23:24:16 +00:00
jenkins-bot
cc5d33ce68 Merge "Fix display of multiple licenses on Special:Version/License" 2020-06-18 23:04:34 +00:00
Huji Lee
faea641ff2 Add missing special page aliases for Persian
This also sorts the aliases in the same order as MessagesEn.php

Bug: T255824
Change-Id: I45f0c40deb3e9538bc6920f81a07d2f5cc82524c
2020-06-18 22:52:38 +00:00
jenkins-bot
39f5bc31ef Merge "build: Update eslint-config-wikimedia to 0.16.2" 2020-06-18 21:28:17 +00:00
jenkins-bot
ac248391ef Merge "SpecialChangeContentModel: Always use POST method for both forms" 2020-06-18 21:00:12 +00:00
jdlrobson
ae9c1d32ac skins: Allow skins to load script modules via Skin class options
This option parallels the styles option. This reduces the need for skins
to extend getDefaultModules and groups skin scripts in a consistent
fashion.

Change-Id: Iaf12d575e691597dea398627f6d34cb425dbf9bb
2020-06-18 20:02:42 +00:00
Ed Sanders
ceb2cd2fe8 build: Update eslint-config-wikimedia to 0.16.2
Use jsduck config.

Change-Id: I3a1a0c8f0ca535c9661b3774498866fdb98a4255
2020-06-18 19:12:10 +00:00
Ed Sanders
08510de602 api-testing: Use wikimedia/mocha eslint config
Change-Id: Iec346d87f252c66fbff1e0fa522d7440df6f1764
2020-06-18 19:20:33 +01:00
Umherirrender
148e7e3940 Remove falsy check after new call
A new call can never return null or false

Change-Id: I792eb6c912828919c02bc5990f129d00accd0ab6
2020-06-18 19:41:01 +02:00
Umherirrender
4c216537df Simplify use of ?? in MWLBFactory
When the left side of ?? is wrapped with [] the array has always one
item and that means it is always true and then used

Move the use of the array key into the existing isset
The empty array for $serversCheck is the default

Change-Id: I2ec95026b3cd5a72dcaf540f369b140fd7b69a53
2020-06-18 17:17:37 +00:00
jenkins-bot
c6a3d5cc6a Merge "Remove unused Title::newFromText in Linker::formatLinksInComment" 2020-06-18 16:46:15 +00:00
jenkins-bot
836400235f Merge "parser: Remove return from callback for Sanitizer::removeHTMLtags" 2020-06-18 16:46:06 +00:00
jenkins-bot
9b2bb87930 Merge "Remove unneeded null check from WebRequest::normalizeUnicode" 2020-06-18 16:45:57 +00:00
jenkins-bot
31b338058d Merge "Remove falsy check after new call" 2020-06-18 16:21:06 +00:00
jenkins-bot
c089a7edaa Merge "UserFactory: Document that newFromName expects a validation constant" 2020-06-18 12:52:16 +00:00
Thiemo Kreuz
b1850a49a7 title: Don't query/create LinkCache service when not needed
It seems in the vast majority of cases (when $flags is 0 and
$this->mArticleID is already known) none of the conditions is true, and
this service is not needed. As this is a very basic, heavily used method
I feel it's worth avoiding unnecessary calls like this.

Change-Id: Ib668071ffe029f3318e110b9f791e400a2becc7a
2020-06-18 14:01:42 +02:00
Translation updater bot
2e6680c412 Localisation updates from https://translatewiki.net.
Change-Id: I2b9e836ca779d16430fb3651dee1a2562d0b0224
2020-06-18 08:35:43 +02:00
jenkins-bot
bd4065ed9b Merge "WikiPage::doEditUpdates - accept a RevisionRecord object" 2020-06-18 01:24:33 +00:00
Reedy
69a9055556 Fix display of multiple licenses on Special:Version/License
Bug: T255736
Change-Id: I7a29f8c4dbb47a9b1be0ff5cdf7ebdb8e0a10339
2020-06-18 01:54:12 +01:00
Bartosz Dziewoński
7f0be4f03b Fix redirects using Special:MyLanguage etc. when using a mobile domain
'wgInternalRedirectTargetUrl' should be set using getLinkURL()
(which doesn't contain the domain) instead of getFullURL().
This is already the case for normal article redirects (see how
'wgInternalRedirectTargetUrl' is set in Article.php).

Bug: T255620
Change-Id: I77473bedd52bc51c8ef53d6bc695b6bf2ebd0bfd
2020-06-17 22:41:49 +00:00