This test was not running and a comment said
it was broken.
This patch refactors the test.
Bug: T180989
Change-Id: I46b73371e5fd65860fce6cc101bad6abfa20e91d
As a follow-up to T171338, the other uses of the message were ignored.
This change adds the protection log to these uses; that is, history and
image pages.
Bug: T174889
Change-Id: Ib9f22d6e06c372c4a32e77a08c846d768853bc21
Whether the lock() acquisition failing is a huge problem depends
on what the caller is doing. Let the caller do any logging it needs.
Bug: T180793
Change-Id: I3d05138d312d8b973df153bb511e69619d663c9d
Errors when parsing XMP information blocks broadly indicate that the
file is somehow malformed. This is generally a content issue rather than
an operational issue.
Bug: T118799
Change-Id: I3c7992343f28db75cd9ec0701c1eceebf6db2d08
The number of issues with the new interface is unacceptable and we
will not be able to fix them reasonably quickly. See subtasks of
T180538 for the list of issues, raised both by the Wikimedia community
and by WMF employees.
I should have pushed back harder against the merging of this half-baked
change with the promise that we'll fix it later. I convinced myself
that the regressions were not so noticeable and that the issues that
were pointed out will in fact be fixed by someone. Predictably,
however, regressions were bad and the only person fixing the issues
was me.
I am not going to work nights to make this page decent again within a
reasonable timeframe; I'm not sure if I'd even be able to since many
issues are problems with the design rather than the implementation. No
one else seems to be working on improving it, therefore I am reverting
the change.
On the bright side, this work has resulted in a number of improvements
to HTMLForm and Preferences code, which are not being reverted here:
<https://gerrit.wikimedia.org/r/#/q/topic:T117781>.
If anyone reattempts this, I recommend gating the new interface behind
a configuration variable and URL parameter, like we did with
$wgOOUIEditPage in the past, and testing thoroughly in production
before enabling it for everyone.
* Revert "Special:Preferences: Use OOjs UI"
This reverts commit 486e566cfe.
* Revert "Preferences: Show preview of edit fonts in edit font selector"
This reverts commit 6634ff729d.
* Revert "Follow-Up Iae63b6994: Add missing editfont dependency"
This reverts commit ce42fdf151.
* Revert "Preferences: Improve visual appearance by “unboxing” sections"
This reverts commit c9415bb005.
* Revert "Remove box-shadow from preference panels for ooui-apex"
This reverts commit a934b82ca2.
* Revert "Preferences: Don't show the watchlist token; just link to ResetTokens"
This reverts commit e8c9102fc7.
* Revert "mw.special.preferences: Make the "Basic information" section more compact"
This reverts commit d48b7260f3.
* Revert "mw.special.preferences: Widen the dropdown of the "Time zone" field"
This reverts commit afd5f1417e.
Bug: T117781
Bug: T180538
Change-Id: I44b5daea1828f71881b5bd35218f5ecb7ab7f36e
Looks like we've got at least one test failure at the moment
(being fixed in Ibb1a59e373740772). Let's use Travis CI to also
check if there are other failures behind it.
Change-Id: Iec9857ee04b4811e912f2f43aed1e5a9fce0a2c4
> There was 1 error:
>
> 1) HashBagOStuffTest::testEvictionAdd
> A non-numeric value encountered
>
> tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php:106
This warning is new in PHP 7.1, however the behaviour is not new.
This code was already not behaving as it should have. Concatenation
preceeds addition/multiplication. As such, this was producing
(int)-10 each time instead of (str)"key0" through (str)"key10".
Change-Id: Ibb1a59e373740772f02dfec77ee7ebd9d181d852
* Renamed ns:-2 and added previous name as alias for backwards
compatibility.
* Renamed NS_TEMPLATE_TALK.
* Added "utilizador/utilizadora" as alias for NS_USER for backwards
compatibility.
* NS_MEDIAWIKI added to avoid issues.
* Renamed NS_PROJECT_TALK and added old naming as alias for backwards
compatibility.
Author: <https://www.mediawiki.org/wiki/User:Athena_in_Wonderland>.
Bug: T180052
Change-Id: I85431339bf24520063077db49d5e9f6b2666bc23
When comparing and when saving the query, normalize the 'invert'
state so that it represents the **effective** state of the filters.
If there are no namespaces, then 'invert' is irrelevant.
Make sure we ignore that state when it is irrelevant when we save
saved queries and when we compare the current state to a saved query.
Change-Id: If80b50c3d2b90b5116b6b0018a8d56bce2deb7c4
Also removed useless line from testLockTSE(). That would have needed
to be using $this->internalCache and those locks are freed immediately.
Bug: T180035
Change-Id: Ida1a923f779aaf8410da76643457d2200da6cb20
This renders in Doxygen as a blank page in the "Modules" sidebar,
doesn't seem to serve any purpose.
No mentions of "Globalsettings" or "Global settings" elsewhere
in the repository.
Change-Id: I2c03b4190c899f2acff400d63bbd3df09f8d49d1
Unused, their values have been hard-coded since 1.27.
No uses anywhere in Wikimedia Git, besides their definition
in this file.
Change-Id: I6689274d0ad028e2c468560816ab753b345048e9
